similar to: [PATCH 0/2] fix kernel crash with macvtap on top of LRO

On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: > On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > > > From: Ben Hutchings <bhutchings at solarflare.com> > > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > > > > > If the consensus is still that we must

On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: > On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > > > From: Ben Hutchings <bhutchings at solarflare.com> > > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > > > > > If the consensus is still that we must

On Mon, 2013-06-17 at 11:05 +0930, Rusty Russell wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: > >> On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > >> > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > >> > > From: Ben Hutchings

On Mon, 2013-06-17 at 11:05 +0930, Rusty Russell wrote: > "Michael S. Tsirkin" <mst at redhat.com> writes: > > On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: > >> On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > >> > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > >> > > From: Ben Hutchings

On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: > > From: Ben Hutchings <bhutchings at solarflare.com> > > Date: Thu, 7 Feb 2013 16:20:46 +0000 > > > > > If the consensus is still that we must preserve packets exactly (aside > > > from the usual modifications by IP routers)

"Michael S. Tsirkin" <mst at redhat.com> writes: > On Wed, Jun 12, 2013 at 03:56:36PM +0100, Ben Hutchings wrote: >> On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote: >> > On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote: >> > > From: Ben Hutchings <bhutchings at solarflare.com> >> > > Date: Thu, 7 Feb 2013

On Wed, Dec 17, 2014 at 01:20:54PM -0500, Vladislav Yasevich wrote: > Now that UFO is split into v4 and v6 parts, we can bring > back v4 support. Continue to handle legacy applications > by selecting the ipv6 fagment id but do not change the > gso type. This allows 2 legacy VMs to continue to communicate. > > Based on original work from Ben Hutchings. > > Fixes:

On Wed, Dec 17, 2014 at 01:20:54PM -0500, Vladislav Yasevich wrote: > Now that UFO is split into v4 and v6 parts, we can bring > back v4 support. Continue to handle legacy applications > by selecting the ipv6 fagment id but do not change the > gso type. This allows 2 legacy VMs to continue to communicate. > > Based on original work from Ben Hutchings. > > Fixes:

On Wed, Dec 17, 2014 at 09:43:51PM -0500, Vlad Yasevich wrote: > On 12/17/2014 05:41 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 17, 2014 at 01:20:54PM -0500, Vladislav Yasevich wrote: > >> Now that UFO is split into v4 and v6 parts, we can bring > >> back v4 support. Continue to handle legacy applications > >> by selecting the ipv6 fagment id but do not

On Wed, Dec 17, 2014 at 09:43:51PM -0500, Vlad Yasevich wrote: > On 12/17/2014 05:41 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 17, 2014 at 01:20:54PM -0500, Vladislav Yasevich wrote: > >> Now that UFO is split into v4 and v6 parts, we can bring > >> back v4 support. Continue to handle legacy applications > >> by selecting the ipv6 fagment id but do not

On Thu, 2014-01-16 at 01:38 -0800, Michael Dalton wrote: [...] > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h [...] > @@ -2401,6 +2416,23 @@ static inline int netif_copy_real_num_queues(struct net_device *to_dev, > #endif > } > > +#ifdef CONFIG_SYSFS > +static inline unsigned int get_netdev_rx_queue_index( > + struct netdev_rx_queue *queue) >

On Thu, 2014-01-16 at 01:38 -0800, Michael Dalton wrote: [...] > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h [...] > @@ -2401,6 +2416,23 @@ static inline int netif_copy_real_num_queues(struct net_device *to_dev, > #endif > } > > +#ifdef CONFIG_SYSFS > +static inline unsigned int get_netdev_rx_queue_index( > + struct netdev_rx_queue *queue) >

On Thu, 2014-01-16 at 11:07 -0800, Michael Dalton wrote: > On Jan 16, 2014 at 10:57 AM, Ben Hutchings <bhutchings at solarflare.com> wrote: > > Why write a loop when you can do: > > i = queue - dev->_rx; > Good point, the loop approach was done in get_netdev_queue_index -- > I agree your fix is faster and simpler. I'll fix in next patchset. It's

On Thu, 2014-01-16 at 11:07 -0800, Michael Dalton wrote: > On Jan 16, 2014 at 10:57 AM, Ben Hutchings <bhutchings at solarflare.com> wrote: > > Why write a loop when you can do: > > i = queue - dev->_rx; > Good point, the loop approach was done in get_netdev_queue_index -- > I agree your fix is faster and simpler. I'll fix in next patchset. It's

On Tue, Sep 29, 2020 at 3:32 PM Willem de Bruijn <willemdebruijn.kernel at gmail.com> wrote: > > On Tue, Sep 29, 2020 at 4:00 AM <xiangxia.m.yue at gmail.com> wrote: > > > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this interface added to them. Now when

The virtio net protocol supports UFO but does not provide for passing a fragment ID for fragmentation of IPv6 packets. We used to generate a fragment ID wherever such a packet was fragmented, but currently we always use ID=0! v2: Add blank lines after declarations Ben. Ben Hutchings (2): drivers/net: Disable UFO through virtio drivers/net,ipv6: Select IPv6 fragment idents for virtio UFO

The virtio net protocol supports UFO but does not provide for passing a fragment ID for fragmentation of IPv6 packets. We used to generate a fragment ID wherever such a packet was fragmented, but currently we always use ID=0! v2: Add blank lines after declarations Ben. Ben Hutchings (2): drivers/net: Disable UFO through virtio drivers/net,ipv6: Select IPv6 fragment idents for virtio UFO

On Tue, Nov 11, 2014 at 12:17:26PM +0000, Ben Hutchings wrote: > On Tue, 2014-11-11 at 10:58 +0000, Stefan Hajnoczi wrote: > > Commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4 ("drivers/net: Disable > > UFO through virtio") breaks live migration of KVM guests from older to > > newer host kernels: > > > >

On Tue, Nov 11, 2014 at 12:17:26PM +0000, Ben Hutchings wrote: > On Tue, 2014-11-11 at 10:58 +0000, Stefan Hajnoczi wrote: > > Commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4 ("drivers/net: Disable > > UFO through virtio") breaks live migration of KVM guests from older to > > newer host kernels: > > > >

UFO support in the kernel applies to both IPv4 and IPv6 protocols with the same device feature. However some devices may not be able to support one of the offloads. For this we split the UFO offload feature into 2 pieces. NETIF_F_UFO now controlls the IPv4 part and this series introduces NETIF_F_UFO6. As a result of this work, we can now re-enable NETIF_F_UFO on virtio_net devices and restore