similar to: [PATCH] utils/isohybrid.c: usage text change, s/AFP/APM/

Hi, i have implemented in xorriso the equivalents of isohybrid.c options --mac and --uefi. There remains the question how to ensure that the submitted MBR is prepared for the 32 byte mock-up of an APM Block0. I see in git of may 2012 that all mbr/isohdp[fp]x*.bin begin by 33 ed 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90

> Hi, > > > Not being compatible with EFI/GPT is already a problem for the Perl > > variant. > > The relation of both is: > > isohybrid.in/.pl is being left behind. > http://git.kernel.org/cgit/boot/syslinux/syslinux.git/tree/utils/Makefile > has: > SCRIPT_TARGETS += isohybrid.pl # about to be obsoleted > > isohybrid.c replaces it feature-wise

It is "APM" Apple Partition Map, not "AFP" Apple Filing Protocol Reported-by: Thomas Schmitt <scdbackup at gmx.net> --- utils/isohybrid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/isohybrid.c b/utils/isohybrid.c index 05afd29..15f63fc 100644 --- a/utils/isohybrid.c +++ b/utils/isohybrid.c @@ -236,7 +236,7 @@ printh(void) printf(FMT,

Hi, Geert Stappers: > Reported-by: Thomas Schmitt <scdbackup at gmx.net> > utils/isohybrid.c | 2 +- It would be somewhat ridiculous to fix only this. {:) Can you point me to an example how a well acceptable patch set should look like ? I expect about half a dozen separate bug fixes to be needed. (Is there a tutorial "SYSLINUX from Git for Dummies" ?) Have a nice day :)

Hi, following will be 6 patch proposals for isohybrid.c 1: Encode GPT partition names as UTF-16LE 2: Correct blocking factor in APM partition block counts 3: Correct end block address of first GPT partition 4: Write GPT backup to the very end of the image 5: Change all fseek(3) to fseeko(3) 6: Introduce option --mbr and make isohybrid.c compilable standalone If the form needs adjustments,

On 2014?05?12? 22:38, H. Peter Anvin wrote: > That is because it needs to use fseeko() and use off_t. Do you mean it does need a patch for isohybrid.c. And the patch looks like: #if _FILE_OFFSET_BITS == 64 fseeko(...) #else fseek(...) Regards, Kai > > On May 11, 2014 11:53:17 PM PDT, Kang Kai <Kai.Kang at windriver.com> wrote: >> On 2014?05?12? 10:49, H. Peter

> Hi, > > > All the "isohybrid.exe" I know of are based on the Perl variant. > > I just got one from > http://www.filewatcher.com/m/isohybrid.exe.39568-0.html > > Its strings seem not to stem from isohybrid.pl. > > Digging in slitaz source brought a shell script (that would be > variant #5 then): >

On 2014?05?12? 10:49, H. Peter Anvin wrote: > On 05/11/2014 06:56 PM, Kai Kang wrote: >> When call isohybrid with option '-u', it overflows on a 32 bits host. It >> seeks to 512 bytes before the end of the image to install gpt header. If >> the size of image is larger than LONG_MAX, it overflows fseek() and >> cause error: >> >> isohybrid:

When call isohybrid with option '-u', it overflows on a 32 bits host. It seeks to 512 bytes before the end of the image to install gpt header. If the size of image is larger than LONG_MAX, it overflows fseek() and cause error: isohybrid: image-x86-64-20140505110100.iso: seek error - 8: Invalid argument Replace fseek with fseeko to fix this issue. Signed-off-by: Kai Kang <kai.kang at

Hi, > All the "isohybrid.exe" I know of are based on the Perl variant. I just got one from http://www.filewatcher.com/m/isohybrid.exe.39568-0.html Its strings seem not to stem from isohybrid.pl. Digging in slitaz source brought a shell script (that would be variant #5 then): http://hg.slitaz.org/wok/file/313b384e2a06/syslinux/stuff/tools/isohybrid.sh But isohybrid.exe must

Hi, hpa: > The right thing to do is compile it with #define _FILE_OFFSET_BITS 64 > and change fseek to fseeko with the appropriate type being off_t. And for GPT names it should really use 16-bit UTF-16LE characters and not 8-bit characters padded up by the same number of random bytes from the program memory. See e.g.:

It seems unwise to offer future programmers fseek(3) calls for copy+paste. They are simply insufficient for large image files. This change switches all calls of fseek(3) to fseeko(3) and takes care that the offset value if of type off_t. --- utils/isohybrid.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/utils/isohybrid.c b/utils/isohybrid.c index

No #if. On May 12, 2014 6:26:18 PM PDT, Kang Kai <Kai.Kang at windriver.com> wrote: >On 2014?05?12? 22:38, H. Peter Anvin wrote: >> That is because it needs to use fseeko() and use off_t. > >Do you mean it does need a patch for isohybrid.c. And the patch looks >like: > >#if _FILE_OFFSET_BITS == 64 > fseeko(...) >#else > fseek(...) > >

When call isohybrid with option '-u', it overflows on a 32 bits host. It seeks to 512 bytes before the end of the image to install gpt header. If the size of image is larger than LONG_MAX, it overflows fseek() and cause error: isohybrid: wrlinux-image-x86-64-20140505110100.iso: seek error - 8: Invalid argument Check the offset and call fseek() multi-times if offset is too large.

Hi, Ady: > > > http://www.syslinux.org/archives/2014-June/022259.html me: > > Already reported in may and diagnosed by hpa: > > http://www.syslinux.org/archives/2014-May/022041.html: > > > The right thing to do is compile it with #define _FILE_OFFSET_BITS 64 > > > and change fseek to fseeko with the appropriate type being off_t. Ady: > This has been

Hi, Ian Bannerman: > I did not know the Perl version did not support the EFI/Mac changes. Comparing the help texts of http://git.kernel.org/cgit/boot/syslinux/syslinux.git/tree/utils/isohybrid.c and http://git.kernel.org/cgit/boot/syslinux/syslinux.git/tree/utils/isohybrid.in shows that the latter lacks: -u --uefi Build EFI bootable image -m --mac Add AFP table support

Hello Recently while playing with bigger iso images (>2G) looks like isohybrid from syslinux-4.02 fails. Sometimes tunning heads/sectors (-h/-s) works, because no padding is needed depending of size of the image. Some debug info provided, if more info is needed please just ask. # isohybrid -v pandereta-2010.09.13-i686.iso catalogue offset: 326 ve[0]: 1, cs: 1 ve[1]: 0, cs: 1 ve[2]: 25927,

I'm going to get the hang of this mailing list eventually. Apologies for any duplicate emails.. >Ian Bannerman: >> While I did know the .exe variant was not official / untrusted, >Is there a special reason for this ? (Except the known bugs which affect Linux binaries, too.) Not really. I had never found a convincing source for it and had seen previous list entries like this

Hi, H. Peter Anvin: > It means that the .iso can be booted from a partition using any of the > standard MBRs (not necessarily altmbr), But the --partok MBRs (isohdpp*) stem from altmbr ? If so: don't they need the partition number patched in ? (If not: i have to rethink the link to article "Mbr" at http://www.syslinux.org/wiki/index.php/Isohybrid#MBR_selection ) >

That is because it needs to use fseeko() and use off_t. On May 11, 2014 11:53:17 PM PDT, Kang Kai <Kai.Kang at windriver.com> wrote: >On 2014?05?12? 10:49, H. Peter Anvin wrote: >> On 05/11/2014 06:56 PM, Kai Kang wrote: >>> When call isohybrid with option '-u', it overflows on a 32 bits >host. It >>> seeks to 512 bytes before the end of the image to