similar to: [PATCH 2/4 v3] com32/disk: Code cleanup at disk_write_sectors and disk_read_sectors.

Rework disk library to work on a firmware independent way. Each specific implementation goes through subdirs like "bios/" and "efi/" respectively. Signed-off-by: Paulo Alcantara <pcacjr at zytor.com> --- com32/include/syslinux/disk.h | 50 +++- com32/lib/Makefile | 2 + com32/lib/syslinux/disk.c | 583

This patch will improve the flow at disk_write_sectors and disk_read_sectors. It does that by creating a table of values respective to the operation. Besides, read and write operations are pretty similar to each other, so I redesigned the routines to avoid duplication. Signed-off-by: Raphael S.Carvalho <raphael.scarv at gmail.com> --- com32/include/syslinux/disk.h | 18 ++++

This patch will improve the flow at disk_write_sectors and disk_read_sectors significantly, but it *will* introduce bugs if either of the above functions gets called before disk_get_params. --- com32/include/syslinux/disk.h | 21 +++++ com32/lib/syslinux/disk.c | 170 +++++++++++++++++++++-------------------- 2 files changed, 108 insertions(+), 83 deletions(-) diff --git

From: Raphael S. Carvalho <raphael.scarv at gmail.com> My commit 09f4ac33 broke 'com32/lib/syslinux/disk.c' __lowmem doesn't work for declarations outside the core. Using __lowmem outside the core wouldn't have the desired effect, then lmalloc must be used instead to store dapa into the correct section (".lowmem"). Reported-by: Dark Raven <drdarkraven at

Hi Peter, Please pull the following changes. Paulo, I had to revert your "pxe: resolve names via DNS from protected-mode code" change because dns_resolv() is only implemented for PXELINUX and causes undefined symbol references for ISOLINUX, etc. Feel free to make the change again on top of the revert. The following changes since commit e7bd19def830e8341b1a100956345f1028740b9e:

eparam will only be used if EBIOS is available on the underlying disk. If not so, then there is no reason to allocate eparam. --- com32/lib/syslinux/disk.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/com32/lib/syslinux/disk.c b/com32/lib/syslinux/disk.c index 093751a..554bed3 100644 --- a/com32/lib/syslinux/disk.c +++ b/com32/lib/syslinux/disk.c @@ -73,7

On Fri, 06 Sep, at 01:00:55AM, Raphael S.Carvalho wrote: > eparam will only be used if EBIOS is available on the underlying disk. > If not so, then there is no reason to allocate eparam. > --- > com32/lib/syslinux/disk.c | 13 +++++++------ > 1 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/com32/lib/syslinux/disk.c b/com32/lib/syslinux/disk.c > index

Previous version had some issues in case of error situations, among those: - backup gpt header was not read if reading of primary failed - alternating nature of lba_cur and lba_alt was ignored This patch fixes this and extends the gpt handling. The current behavior is: - try primary header; if unreadable or checksum fails (or sanity checks fail unless relax flag is set) - try secondary header

eparam would only be used if EBIOS is available. If it is not, then there is no reason to allocate eparam. Signed-off-by: Raphael S.Carvalho <raphael.scarv at gmail.com> --- com32/lib/syslinux/disk.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/com32/lib/syslinux/disk.c b/com32/lib/syslinux/disk.c index 093751a..d96acbf 100644 ---

On Tue, 17 Sep, at 04:42:24PM, Raphael S.Carvalho wrote: > eparam would only be used if EBIOS is available. > If it is not, then there is no reason to allocate eparam. > > Signed-off-by: Raphael S.Carvalho <raphael.scarv at gmail.com> > --- > com32/lib/syslinux/disk.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git

Hello, the following patches should get multidisk access working. The syntax accepted is the following: (hdx,y)/path/to/file where x is the disk number and start at 0 and the y is the partition number starting at 1. So (hd0,1) is the first partition of the first disk. the other accepted syntax is using MBR's 32 bits disk signature so for example: (mbr:0x12345678,2)/foo/bar would address

Fix breakage in the "hide" option support patch: - The code which initialized the global variable "dapa" was lost in commit 81c203f2, therefore EBIOS access did not work properly. Fixed by removing the global variable completely and moving all bounce buffer handling into read_sector() and write_sector(). - write_sector() copied data to the bounce buffer, but then

From: Raphael S. Carvalho <raphael.scarv at gmail.com> MultiFS depends on the availability of partiter to find a partition. Signed-off-by: Raphael S. Carvalho <raphael.scarv at gmail.com> --- com32/chain/Makefile | 2 +- com32/chain/chain.c | 4 +- com32/chain/mangle.c | 4 +- com32/chain/mangle.h | 2 +-

Hi all, I use XP on my laptop PC, with 30 GB HD (single partition), and a 3.5" hard drive (not a stick), accessed through a USB encasing, partitioned as five logical drives. I have successfully set up syslinux to boot several Ubuntu versions from the primary USB hard drive partition, and no problems there. The problem is, I would like to have an entry in the menu, like "Boot from

From: "Raphael S. Carvalho" <raphael.scarv at gmail.com> MultiFS depends on the availability of partiter to find a partition. Cc: Gene Cumm <gene.cumm at gmail.com> Signed-off-by: Raphael S. Carvalho <raphael.scarv at gmail.com> Signed-off-by: Paulo Alcantara <pcacjr at zytor.com> --- com32/chain/Makefile | 2 +- com32/chain/chain.c

Here is a partial patch that I'm using to illustrate a few questions that I have. Looking at the gpllib write_sectors (com32/gpllib/disk/write.c) it looks like the allocated size is wrong; size is in sectors so we should adjust the alloc/memcpy by size*SECTOR. Also, comparing core/diskio.c it looks like the registers aren't even setup right. In the patch below I put an #if 0 around the

As partiter doesn't deallocate itself after finish (anymore), it should be deleted after each loop iteration. diff --git a/com32/chain/chain.c b/com32/chain/chain.c index c08ec6e..f86cd7d 100644 --- a/com32/chain/chain.c +++ b/com32/chain/chain.c @@ -64,27 +64,23 @@ static int is_phys(uint8_t sdifs) static int find_by_sig(uint32_t mbr_sig, struct part_iter **_boot_part) { - struct

This is a bit updated set of chain.c32 changes that simplifies a few things (and in partiter part), fixes few minor issues and adds a few new features. Details are in the following commits, below is the summary and pull details at the end. Shao - any chance to peek over them ? Most of those are relatively simple changes and well tested, though of course something might have slipped my attention.

This small set fixes few bugs, improves gpt handling (under buggy conditions) and implements strict flag with more fine grained control which should fix issues with sanity checks against disk sizes. If this set is allright I'd want to do what I mentioned in older discussion with Ady - backport missing patches from 6.x to 5.x and 4.x so all versions have up to date chain version. Michal

This is a continuation to the library creation effort for syslinux. I added the necessary ops required to read partitions and sectors off the disk. I'm using it with my com32 module. I did change the interface for read_disk a bit, so it takes a disk_info argument. This way I can maintain multiple instances of read handlers, for example if I'm reading and comparing stuff from two different