similar to: [PATCH] nv50: disable dedicated ubo upload method

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 22 ++++++++++++++++++- src/gallium/drivers/nouveau/nv50/nv50_context.h | 1 + src/gallium/drivers/nouveau/nv50/nv50_vbo.c | 29 ++++++++++++++++++++++++- 3 files changed, 50 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_context.c

On Sat, Oct 10, 2015 at 3:41 PM, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote: > This patch looks fine except that it should be a bit more normalized. I > mean, sometimes you break when PUSH_SPACE fails, sometimes not. Same for > PUSH_SPACE calls, sometimes you add it sometimes not. Meh. We need to get our error checking situation straight, but this isn't the patch to

We still have to push everything out, might as well kick earlier and flip pushbufs when we know we'll need it. This resolves some issues with the new policy of making sure that we always leave a bit of room at the end for fences. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> Cc: mesa-stable at lists.freedesktop.org --- src/gallium/drivers/nouveau/nv50/nv50_shader_state.c | 9

The number of vertex buffers has nothing to do with the number of bound constbufs. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> Cc: "10.4 10.3" <mesa-stable at lists.freedesktop.org> --- src/gallium/drivers/nouveau/nv50/nv50_context.c | 5 +++-- src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

Since we upload all parameters on every program / constbuf change, we don't have to reserve space and can just use the whole buffer. Doesn't apply to the buffer holding immediates. --- src/gallium/drivers/nv50/nv50_program.c | 39 ++++++++---------------------- src/gallium/drivers/nv50/nv50_program.h | 6 ++-- 2 files changed, 14 insertions(+), 31 deletions(-) diff --git

Thomas, OK, thanks for the update. I don't have a working machine with NV graphics that supports UBOs. Could you compile and run a test program for me if I wrote it? Though it may appear to not work for UBO offsets other than 0, there may be another pattern here, such as multiple of page size or something crazy like that. If we can find more information, it may help other developers. Patrick

Hey guys, I'm using the dolphin emulator from time and the stable version works reasonable well with current nvidia cards and nouveau.The git version got an overhaul however and now uses opengl3 and ubos (without ubo it uses a glUniform fallback). The ubo support works with the blobs. There are probably a few bugs with ubo one might be because of ubo access+offset (glBindBufferRange) as this

We need to invert the viewport translate/scale parameters when the state tracker thinks we have Y_0_TOP. If these cases, we have do to bypass mode by setting an identity viewport transform for x, z and inversion for y, or p.e. clear_with_quad won't work correctly. Clipping for xy in NDC space needs to be disabled then. --- src/gallium/drivers/nv50/nv50_context.h | 1 +

nv30 seems to not support dma objects with offset, so simply extend the query_heap to cover the entire notifier, and use a offset in nv30_context_kick_notify. Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com> --- src/gallium/drivers/nouveau/nouveau_buffer.c | 14 +- src/gallium/drivers/nouveau/nouveau_context.h | 5 +

Fixes the piglits which check that gl_VertexID includes the base vertex offset: arb_draw_indirect-vertexid elements gl-3.2-basevertex-vertexid Note that this leaves out the original G80, for which this will continue to fail. It could be fixed by passing a driver constbuf value in, but that's beyond the scope of this change. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> Cc:

https://bugs.freedesktop.org/show_bug.cgi?id=67215 Priority: medium Bug ID: 67215 Assignee: nouveau at lists.freedesktop.org Summary: UBO access seems to mask address on nouveau Severity: normal Classification: Unclassified OS: Linux (All) Reporter: wickmarkus at web.de Hardware: x86-64 (AMD64)

Oh and just for the sake of completeness the problem occurs in the form of wrongly rendered textures in front of a black screen. The objects only are fusible for a second and them disappear sometimes they appear at the wrong position or are rotated. If you compile dolphin with GLEW_ARB_uniform_buffer_object replaced with false in Source/Plugins/Plugin_VideoOGL/Src/Render.cpp the problems won't

I myself am not that well-versed in c and opengl - especially opengl - I can read and write basic c code but that's my limit. The problem only appears when using an offset that's not zero.If you want to debug the issue you could very well use the dolphin-emu and apitrace. You can find one apitrace here http://markus.members.selfnet.de/dolphin/dolphin-emu.trace (~48M) The only 2 reasons I

On Tue, Jun 17, 2014 at 2:34 AM, Maarten Lankhorst <maarten.lankhorst at canonical.com> wrote: > nv30 seems to not support dma objects with offset, so simply extend the query_heap to cover the > entire notifier, and use a offset in nv30_context_kick_notify. It would be great if you could detail the list of transformations that were done in the commit description, as well as what the

--- This is still a WIP. Just wanted to get people's opinions. It's also not bullet-proof. Unfortunately nouveau_bo_wait [which is in turn called by nouveau_bo_map] can trigger a kick, so technically we have to have a lock around any nouveau_bo_map. My strategy here was to add locks around all the user-accessible APIs while leaving all the internal stuff unlocked. When waiting for a

Hi, On 22-02-16 16:24, Ilia Mirkin wrote: > On Mon, Feb 22, 2016 at 9:50 AM, Hans de Goede <hdegoede at redhat.com> wrote: >> Hi, >> >> >> On 22-02-16 15:22, Ilia Mirkin wrote: >>> >>> On Mon, Feb 22, 2016 at 9:17 AM, Hans de Goede <hdegoede at redhat.com> >>> wrote: >>>> >>>> Hi, >>>>

On Mon, Feb 22, 2016 at 9:50 AM, Hans de Goede <hdegoede at redhat.com> wrote: > Hi, > > > On 22-02-16 15:22, Ilia Mirkin wrote: >> >> On Mon, Feb 22, 2016 at 9:17 AM, Hans de Goede <hdegoede at redhat.com> >> wrote: >>> >>> Hi, >>> >>> On 22-02-16 14:47, Ilia Mirkin wrote: >>>> >>>>

Hello, > On 22 Feb 2016, at 15:22, Ilia Mirkin <imirkin at alum.mit.edu> wrote: > >> On Mon, Feb 22, 2016 at 9:17 AM, Hans de Goede <hdegoede at redhat.com> wrote: >> Hi, >> >>> On 22-02-16 14:47, Ilia Mirkin wrote: >>> >>>> On Mon, Feb 22, 2016 at 8:45 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote: >>>>

Hi, On 22-02-16 15:22, Ilia Mirkin wrote: > On Mon, Feb 22, 2016 at 9:17 AM, Hans de Goede <hdegoede at redhat.com> wrote: >> Hi, >> >> On 22-02-16 14:47, Ilia Mirkin wrote: >>> >>> On Mon, Feb 22, 2016 at 8:45 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote: >>>> >>>> INPUT is for shader inputs which come from fixed

On Mon, Feb 22, 2016 at 9:17 AM, Hans de Goede <hdegoede at redhat.com> wrote: > Hi, > > On 22-02-16 14:47, Ilia Mirkin wrote: >> >> On Mon, Feb 22, 2016 at 8:45 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote: >>> >>> INPUT is for shader inputs which come from fixed function loaders. >>> This is not what you want. You want CONST. Stick