similar to: RFC: LLVM Assembly format for ThinLTO Summary

On Thu, May 3, 2018 at 2:58 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: > Hi Teresa, > > I have re-read your proposal, and I'm not getting how you plan to > represent combined summaries with this. Unless I'm missing something, there > doesn't seem to be a way to write out summaries that is independent of the > global values that they relate to. Is that

Hi Peter, Thanks for your comments, replies below. Teresa On Wed, Apr 25, 2018 at 2:08 PM Peter Collingbourne <peter at pcc.me.uk> wrote: > Hi Teresa, > > Thanks for sending this proposal out. > > I would again like to register my disagreement with the whole idea of > writing summaries in LLVM assembly format. In my view it is clear that this > is not the right

On Mon, Apr 30, 2018 at 10:21 AM Peter Collingbourne <peter at pcc.me.uk> wrote: > On Mon, Apr 30, 2018 at 8:32 AM, Teresa Johnson <tejohnson at google.com> > wrote: > >> Hi Peter, >> Thanks for your comments, replies below. >> Teresa >> >> On Wed, Apr 25, 2018 at 2:08 PM Peter Collingbourne <peter at pcc.me.uk> >> wrote: >>

Hi Teresa, I have re-read your proposal, and I'm not getting how you plan to represent combined summaries with this. Unless I'm missing something, there doesn't seem to be a way to write out summaries that is independent of the global values that they relate to. Is that something that you plan to address later? Peter On Tue, Apr 24, 2018 at 7:43 AM, Teresa Johnson <tejohnson at

Hi Teresa, Thanks for sending this proposal out. I would again like to register my disagreement with the whole idea of writing summaries in LLVM assembly format. In my view it is clear that this is not the right direction, as it only invites additional complexity and more ways for things to go wrong for no real benefit. However, I don't have the energy to argue that point any further, so I

On Thu, May 3, 2018 at 3:10 PM, Teresa Johnson <tejohnson at google.com> wrote: > > > On Thu, May 3, 2018 at 2:58 PM, Peter Collingbourne <peter at pcc.me.uk> > wrote: > >> Hi Teresa, >> >> I have re-read your proposal, and I'm not getting how you plan to >> represent combined summaries with this. Unless I'm missing something, there

Hi, My main concern is this one: > Currently, I am emitting the summary entries at the end, after the metadata nodes. Note that the ModuleSummaryIndex is not currently referenced from the Module, and isn’t currently created when parsing the Module IR bitcode (there is a separate derived class for reading the ModuleSummaryIndex from bitcode). This is because they are not currently used at the

On Thu, May 3, 2018 at 3:21 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: > On Thu, May 3, 2018 at 3:10 PM, Teresa Johnson <tejohnson at google.com> > wrote: > >> >> >> On Thu, May 3, 2018 at 2:58 PM, Peter Collingbourne <peter at pcc.me.uk> >> wrote: >> >>> Hi Teresa, >>> >>> I have re-read your proposal,

On Mon, Apr 30, 2018 at 8:32 AM, Teresa Johnson <tejohnson at google.com> wrote: > Hi Peter, > Thanks for your comments, replies below. > Teresa > > On Wed, Apr 25, 2018 at 2:08 PM Peter Collingbourne <peter at pcc.me.uk> > wrote: > >> Hi Teresa, >> >> Thanks for sending this proposal out. >> >> I would again like to register my

On Tue, May 1, 2018 at 9:00 AM, Teresa Johnson <tejohnson at google.com> wrote: > > > On Mon, Apr 30, 2018 at 10:21 AM Peter Collingbourne <peter at pcc.me.uk> > wrote: > >> On Mon, Apr 30, 2018 at 8:32 AM, Teresa Johnson <tejohnson at google.com> >> wrote: >> >>> Hi Peter, >>> Thanks for your comments, replies below.

Hi Teresa Thanks for the proposal. Serializing out the summary in a readable format is very help for debugging and development. Some comments inline. > On Apr 24, 2018, at 7:43 AM, Teresa Johnson via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi everyone, > > I started working on a long-standing request to have the summary dumped in a readable format to text, and

Hi Mehdi, thanks for the comments, responses and a tweaked proposal below. Teresa On Tue, May 1, 2018 at 11:37 AM, Mehdi AMINI <joker.eph at gmail.com> wrote: > Hi, > > My main concern is this one: > > > Currently, I am emitting the summary entries at the end, after the > metadata nodes. Note that the ModuleSummaryIndex is not currently > referenced from the Module,

Hi Teresa, Awesome to see - looking forward to it! On Tue, Apr 24, 2018 at 7:44 AM Teresa Johnson via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi everyone, > > I started working on a long-standing request to have the summary dumped in > a readable format to text, and specifically to emit to LLVM assembly. > Proposal below, please let me know your thoughts. > >

On Thu, May 3, 2018 at 3:08 PM Peter Collingbourne via llvm-dev < llvm-dev at lists.llvm.org> wrote: > On Thu, May 3, 2018 at 2:44 PM, Mehdi AMINI <joker.eph at gmail.com> wrote: > >> >> >> Le mar. 1 mai 2018 à 16:50, Teresa Johnson <tejohnson at google.com> a >> écrit : >> >>> Hi Mehdi, thanks for the comments, responses and a

Le mar. 1 mai 2018 à 16:50, Teresa Johnson <tejohnson at google.com> a écrit : > Hi Mehdi, thanks for the comments, responses and a tweaked proposal below. > Teresa > > On Tue, May 1, 2018 at 11:37 AM, Mehdi AMINI <joker.eph at gmail.com> wrote: > >> Hi, >> >> My main concern is this one: >> >> > Currently, I am emitting the summary

> On May 1, 2018, at 4:50 PM, Teresa Johnson via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi Mehdi, thanks for the comments, responses and a tweaked proposal below. Teresa > > On Tue, May 1, 2018 at 11:37 AM, Mehdi AMINI <joker.eph at gmail.com <mailto:joker.eph at gmail.com>> wrote: > Hi, > > My main concern is this one: > > >

On Thu, May 3, 2018 at 2:44 PM, Mehdi AMINI <joker.eph at gmail.com> wrote: > > > Le mar. 1 mai 2018 à 16:50, Teresa Johnson <tejohnson at google.com> a > écrit : > >> Hi Mehdi, thanks for the comments, responses and a tweaked proposal >> below. Teresa >> >> On Tue, May 1, 2018 at 11:37 AM, Mehdi AMINI <joker.eph at gmail.com> wrote:

> On May 3, 2018, at 2:58 PM, Teresa Johnson <tejohnson at google.com> wrote: > > > > On Thu, May 3, 2018 at 2:16 PM, Steven Wu <stevenwu at apple.com <mailto:stevenwu at apple.com>> wrote: > > >> On May 1, 2018, at 4:50 PM, Teresa Johnson via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >>

Le jeu. 3 mai 2018 à 15:52, Peter Collingbourne <peter at pcc.me.uk> a écrit : > > > On Thu, May 3, 2018 at 3:29 PM, David Blaikie <dblaikie at gmail.com> wrote: > >> >> >> On Thu, May 3, 2018 at 3:08 PM Peter Collingbourne via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> >>> On Thu, May 3, 2018 at 2:44 PM, Mehdi AMINI

On Thu, May 3, 2018 at 3:52 PM Peter Collingbourne <peter at pcc.me.uk> wrote: > On Thu, May 3, 2018 at 3:29 PM, David Blaikie <dblaikie at gmail.com> wrote: > >> >> >> On Thu, May 3, 2018 at 3:08 PM Peter Collingbourne via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> >>> On Thu, May 3, 2018 at 2:44 PM, Mehdi AMINI