similar to: [ThinLTO] static library failure with object files with the same name

Hi Johan, ld64 only calls functions from llvm/include/llvm-c/lto.h (defined in llvm/tools/lto/lto.cpp) For instance ThinLTOCodeGenerator::addModule is called through thinlto_codegen_add_module(). Apple hasn't released the code for ld64 in Xcode 9 yet, did you check if it is fixed in Xcode 9? (I think I remember fixing it in ld64 but I'm not totally sure...). >From what I can see

On Wed, Sep 6, 2017 at 1:10 PM, Johan Engelen via llvm-dev <llvm-dev at lists.llvm.org> wrote: > On Tue, Sep 5, 2017 at 11:34 PM, Davide Italiano <dccitaliano at gmail.com> > wrote: >> >> On Tue, Sep 5, 2017 at 2:09 PM, Teresa Johnson <tejohnson at google.com> >> wrote: >> > >> > Hi Johan, >> > >> > Right, per the bug

On Fri, Sep 8, 2017 at 9:04 PM, Johan Engelen <jbc.engelen at gmail.com> wrote: > > On Thu, Sep 7, 2017 at 5:44 PM, Mehdi AMINI <joker.eph at gmail.com> wrote: > >> Hi Johan, >> >> ld64 only calls functions from llvm/include/llvm-c/lto.h (defined >> in llvm/tools/lto/lto.cpp) >> >> For instance ThinLTOCodeGenerator::addModule is called

On Tue, Sep 5, 2017 at 2:09 PM, Teresa Johnson <tejohnson at google.com> wrote: > > Hi Johan, > > Right, per the bug this is fixed in lld (and was already handled in gold-plugin), but I guess not in ld64. Note that lld and gold-plugin use the new LTO API, while ld64 (and probably other linkers) are still using the legacy libLTO (which is what ThinLTOCodeGenerator.cpp is part of).

Hi all, I am trying to add ThinLTO to the LDC compiler. It seems to work well on Mac (XCode 8) and Ubuntu (ld.gold + LLVMgold plugin). However, I am running into trouble with module-scope inline assembly blocks. I have a module ASM with a function `foo` defined in an inline assembly block (and an LLVM IR `declare @foo()` for it). There is also a "normal" function `void

2017-05-02 8:42 GMT-07:00 Duncan P. N. Exon Smith <dexonsmith at apple.com>: > +Teresa, Mehdi > > On May 2, 2017, at 08:31, James Henderson <jh7370.2008 at my.bristol.ac.uk> > wrote: > > Hi, > > We have been investigating an issue when running LTO with our proprietary > linker, which links against libLTO dynamically. The issue is that when we > pass

I've created a review for your patch Mehdi: https://reviews.llvm.org/D37961 First time using `arc`, so hope things went well. - Johan On Tue, Sep 12, 2017 at 5:25 AM, Mehdi AMINI <joker.eph at gmail.com> wrote: > Hi Johan, > > 2017-09-11 14:21 GMT-07:00 Johan Engelen <jbc.engelen at gmail.com>: > >> On Fri, Sep 8, 2017 at 9:04 PM, Johan Engelen

The fix (https://reviews.llvm.org/D37961) does not work. From what I have learned thusfar, the module identifier is used as filename sometimes (I think when writing an intermediate module index summary), and so a bunch of lit tests fail with the "fix". I'll look further into fixing this, any help is appreciated. ( One thing that may be important is to have a deterministic suffix.

It is expected and not unusual to need to update the lit test in such case. I'd need to see exactly which test breaks and how to know though. Best, -- Mehdi 2017-09-18 13:17 GMT-07:00 Johan Engelen <jbc.engelen at gmail.com>: > The fix (https://reviews.llvm.org/D37961) does not work. From what I > have learned thusfar, the module identifier is used as filename sometimes >

On Mon, Oct 3, 2016 at 4:27 PM, Teresa Johnson <tejohnson at google.com> wrote: > > > On Mon, Oct 3, 2016 at 6:53 AM, Johan Engelen via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Hi all, >> I am trying to add ThinLTO to the LDC compiler. It seems to work well >> on Mac (XCode 8) and Ubuntu (ld.gold + LLVMgold plugin). >> However, I am

With `save-temps` as plugin option, I get extra files for the MAIN module (called `a.o`): `a.o.opt.bc` and `a.thinlto.bc`. The `a.thinlto.bc` file contains nothing, only `source_filename = ...` . The `a.o.opt.bc` (this looks like the result after ThinLTO importing and optimization) contains the assembly block that it should not have: ``` module asm "\09.text" module asm

Hi, We have been investigating an issue when running LTO with our proprietary linker, which links against libLTO dynamically. The issue is that when we pass -time-passes via the lto_codegen_debug_options function in the LTO C API, no time information is produced during compilation. The reason for this is that time information is stored in state owned by a ManagedStatic instance, and is only

Le jeu. 22 mars 2018 à 16:46, Steven Wu <stevenwu at apple.com> a écrit : > Hi Katya > > Thanks for investigating this. Here is my thought inline. > > On Mar 22, 2018, at 1:32 AM, katya.romanova at sony.com wrote: > > > Hello, > > I am sending the following proposal to discuss issues and solutions > regarding data races in concurrent ThinLTO processes. >

> On Mar 26, 2018, at 8:54 PM, Mehdi AMINI <joker.eph at gmail.com> wrote: > > > > Le jeu. 22 mars 2018 à 16:46, Steven Wu <stevenwu at apple.com <mailto:stevenwu at apple.com>> a écrit : > Hi Katya > > Thanks for investigating this. Here is my thought inline. > >> On Mar 22, 2018, at 1:32 AM, katya.romanova at sony.com

Hi Katya Thanks for investigating this. Here is my thought inline. > On Mar 22, 2018, at 1:32 AM, katya.romanova at sony.com wrote: > > > Hello, > > I am sending the following proposal to discuss issues and solutions regarding data races in concurrent ThinLTO processes. > > This caught my attention when we encountered a race condition in ThinLTO with caching. >

From: stevenwu at apple.com <stevenwu at apple.com> Sent: Monday, March 26, 2018 11:58 PM To: Mehdi AMINI <joker.eph at gmail.com> Cc: Romanova, Katya <katya.romanova at sony.com>; Teresa Johnson <tejohnson at google.com>; Rafael Espíndola <rafael.espindola at gmail.com>; Peter Collingbourne <peter at pcc.me.uk>; Hans Wennborg <hans at chromium.org>; Reid

Hello, I am sending the following proposal to discuss issues and solutions regarding data races in concurrent ThinLTO processes. This caught my attention when we encountered a race condition in ThinLTO with caching. While looking into how ThinLTO deals with the problem of cache files reads/writes/deletes I spotted a lot of problems: some of them are related to data races, others - to

The plugin version (and LLVM) are LLVM 3.9.0 (the release source tarball). I've attached the source files and the temporary files generated. `a.o` is the "MAIN" module. `b.o` is the "ASM" module. The error I get is: /usr/bin/ld: error: a.o.thinlto.o: multiple definition of 'foo' /usr/bin/ld: b.o.thinlto.o: previous definition here (the files depend on D runtime

On Mon, Mar 26, 2018 at 6:03 PM, <katya.romanova at sony.com> wrote: > Hi Steven, > > Look at my replies inline (below your comments). > > Katya. > > > > *From:* stevenwu at apple.com <stevenwu at apple.com> > *Sent:* Thursday, March 22, 2018 4:46 PM > *To:* Romanova, Katya <katya.romanova at sony.com> > *Cc:* Teresa Johnson <tejohnson at

> On Mar 26, 2018, at 6:03 PM, katya.romanova at sony.com wrote: > > Hi Steven, > Look at my replies inline (below your comments). > Katya. > > From: stevenwu at apple.com <mailto:stevenwu at apple.com> <stevenwu at apple.com <mailto:stevenwu at apple.com>> > Sent: Thursday, March 22, 2018 4:46 PM > To: Romanova, Katya <katya.romanova at sony.com