similar to: [RFC][ThinLTO] llvm-dis ThinLTO summary dump format

On Fri, Jun 2, 2017 at 12:18 PM, Peter Collingbourne via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Why do we need a custom dumping format for the summary? Since we already > need the YAML format anyway, wouldn't it be better to extend that to cover > the entire summary? > IMO it is useful/convenient to be able to see the summary in the llvm-dis output. Teresa >

On Fri, Jun 2, 2017 at 12:39 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: > On Fri, Jun 2, 2017 at 12:29 PM, Teresa Johnson <tejohnson at google.com> > wrote: > >> On Fri, Jun 2, 2017 at 12:18 PM, Peter Collingbourne via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> >>> Why do we need a custom dumping format for the summary? Since

Oh I just see that there were already a bunch of answers. I missed the thread, sorry. So basically my intuitive approach on this is close to what I perceive Peter's position is: - don't create a new format if there is already one. - if you really have a good reason to create a new format, it should replace the existing one (i.e. don't maintain two). - ideally we should be able to

2017-06-05 14:27 GMT-07:00 David Blaikie via llvm-dev < llvm-dev at lists.llvm.org>: > I know there's been a bunch of discussion here already, but I was > wondering if perhaps someone (probably Teresa? Peter?) could: > > 1) summarize the current state > 2) describe the end-goal > 3) describe what steps (& how this patch relates) are planned to get to (2) > >

On Wed, Jun 7, 2017 at 8:58 AM, Charles Saternos <charles.saternos at gmail.com > wrote: > Alright, now it outputs YAML in the following format: > > --- > NamedGlobalValueMap: > X: > - Kind: GlobalVar > Linkage: ExternalLinkage > NotEligibleToImport: false > Live: false > a: > - Kind:

2017-06-06 13:38 GMT-07:00 David Blaikie <dblaikie at gmail.com>: > > > On Tue, Jun 6, 2017 at 1:26 PM Mehdi AMINI <joker.eph at gmail.com> wrote: > >> 2017-06-05 14:27 GMT-07:00 David Blaikie via llvm-dev < >> llvm-dev at lists.llvm.org>: >> >>> I know there's been a bunch of discussion here already, but I was >>> wondering if

Great! For the hotness, try creating a small test case with a very hot loop that iterates many times. Let me know if you are still having trouble. While the llvm-dis serialization is being discussed, I suppose at the very least this can go in with the rest of the existing YAML summary dumping and get emitted from llvm-lto2 using the patch Peter attached. Peter - do you want to add that to

On Mon, Jul 17, 2017 at 6:11 AM Charles Saternos via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hey @chandlerc and @dblaikie, > > Any updates on this in relation to "[PATCH] D34080: [ThinLTO] Add > dump-summary command to llvm-lto2 tool"? > Sorry you've kind of got stuck in the middle of this - but I'm still hoping to hear/understand the pushback on

Hi everyone, I started working on a long-standing request to have the summary dumped in a readable format to text, and specifically to emit to LLVM assembly. Proposal below, please let me know your thoughts. Thanks, Teresa *RFC: LLVM Assembly format for ThinLTO

On Thu, May 3, 2018 at 2:58 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: > Hi Teresa, > > I have re-read your proposal, and I'm not getting how you plan to > represent combined summaries with this. Unless I'm missing something, there > doesn't seem to be a way to write out summaries that is independent of the > global values that they relate to. Is that

Hi Teresa Thanks for the proposal. Serializing out the summary in a readable format is very help for debugging and development. Some comments inline. > On Apr 24, 2018, at 7:43 AM, Teresa Johnson via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi everyone, > > I started working on a long-standing request to have the summary dumped in a readable format to text, and

Hi Peter, Thanks for your comments, replies below. Teresa On Wed, Apr 25, 2018 at 2:08 PM Peter Collingbourne <peter at pcc.me.uk> wrote: > Hi Teresa, > > Thanks for sending this proposal out. > > I would again like to register my disagreement with the whole idea of > writing summaries in LLVM assembly format. In my view it is clear that this > is not the right

Hi Teresa, I have re-read your proposal, and I'm not getting how you plan to represent combined summaries with this. Unless I'm missing something, there doesn't seem to be a way to write out summaries that is independent of the global values that they relate to. Is that something that you plan to address later? Peter On Tue, Apr 24, 2018 at 7:43 AM, Teresa Johnson <tejohnson at

On Thu, May 3, 2018 at 3:10 PM, Teresa Johnson <tejohnson at google.com> wrote: > > > On Thu, May 3, 2018 at 2:58 PM, Peter Collingbourne <peter at pcc.me.uk> > wrote: > >> Hi Teresa, >> >> I have re-read your proposal, and I'm not getting how you plan to >> represent combined summaries with this. Unless I'm missing something, there

On Thu, May 3, 2018 at 3:21 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: > On Thu, May 3, 2018 at 3:10 PM, Teresa Johnson <tejohnson at google.com> > wrote: > >> >> >> On Thu, May 3, 2018 at 2:58 PM, Peter Collingbourne <peter at pcc.me.uk> >> wrote: >> >>> Hi Teresa, >>> >>> I have re-read your proposal,

Hi Teresa, Thanks for sending this proposal out. I would again like to register my disagreement with the whole idea of writing summaries in LLVM assembly format. In my view it is clear that this is not the right direction, as it only invites additional complexity and more ways for things to go wrong for no real benefit. However, I don't have the energy to argue that point any further, so I

Hi Teresa, Awesome to see - looking forward to it! On Tue, Apr 24, 2018 at 7:44 AM Teresa Johnson via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi everyone, > > I started working on a long-standing request to have the summary dumped in > a readable format to text, and specifically to emit to LLVM assembly. > Proposal below, please let me know your thoughts. > >

Hi, My main concern is this one: > Currently, I am emitting the summary entries at the end, after the metadata nodes. Note that the ModuleSummaryIndex is not currently referenced from the Module, and isn’t currently created when parsing the Module IR bitcode (there is a separate derived class for reading the ModuleSummaryIndex from bitcode). This is because they are not currently used at the

On Mon, Apr 30, 2018 at 10:21 AM Peter Collingbourne <peter at pcc.me.uk> wrote: > On Mon, Apr 30, 2018 at 8:32 AM, Teresa Johnson <tejohnson at google.com> > wrote: > >> Hi Peter, >> Thanks for your comments, replies below. >> Teresa >> >> On Wed, Apr 25, 2018 at 2:08 PM Peter Collingbourne <peter at pcc.me.uk> >> wrote: >>

On Mon, Apr 30, 2018 at 8:32 AM, Teresa Johnson <tejohnson at google.com> wrote: > Hi Peter, > Thanks for your comments, replies below. > Teresa > > On Wed, Apr 25, 2018 at 2:08 PM Peter Collingbourne <peter at pcc.me.uk> > wrote: > >> Hi Teresa, >> >> Thanks for sending this proposal out. >> >> I would again like to register my