similar to: [PATCH] opusfile configury fixes.

Includes - A make debug target that disables optimizations and enables assertions, - Proper ./configure switches for the optional features, - A configuration summary, - libtool versioning information, - Visibility and warning flags, - API documentation, and - Support for out-of-tree builds. Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu> --- .gitignore | 29 +++++

The autogen.sh o

Don't force automake 1.11 AM_SILENT_RULES on folks who don't have it. diff --git a/configure.ac b/configure.ac index 6a65fcc..36ac6c6 100644 --- a/configure.ac +++ b/configure.ac @@ -20,7 +20,7 @@ ?AC_INIT(src/flac/main.c) ?AM_INIT_AUTOMAKE(flac, 1.2.1) -AM_SILENT_RULES([yes]) +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) ?# Don't automagically regenerate autoconf/automake

Citeren Arnaud Quette <aquette op alioth.debian.org>: > Log: > Optionaly enable silent build rules, using AM_SILENT_RULES, only if > it's supported (requires automake 1.11) Why do we need a new branch for this? As far as I can see, only the below lines are really needed > +dnl Currently, we only (force) enable silent rules if available > +dnl Verbose mode can be

recent autotools require calling AM_PROG_AR before LT_INIT this macro needs to be conditionally defined as it is not present in old versions. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 754c458..ff7bf11 100644 --- a/configure.ac +++ b/configure.ac @@ -25,10 +25,10 @@ AC_CONFIG_MACRO_DIR([m4]) AM_INIT_AUTOMAKE([foreign

Only marginally useful, but some like it... This makes tests print "PASS" in green, and "FAIL" in red, when possible: The autogen.sh snippet ensures that this automake-1.11 feature is disabled when building-from-clone on a system with too-old automake. This *does* modify a source file (and a version-controlled one at that), but only when building from source on e.g. RHEL*

flac configury does a XIPH_ADD_CFLAGS([-Wextra]) around line 426, however it unconditionally adds -Wextra some lines before that too. The attached patch removes that unconditional addition of -Wextra which (i) removes duplicate addition, and (ii) allows older gcc versions to compile the tree peacefully. Please consider applying. -- O.S. -------------- next part -------------- diff --git

Hello Jonathan, I am unable to apply your patch cleanly on tip. Timothy/opus-dev, This patch has some conflicts with my ARM patch that does fft optimizations http://lists.xiph.org/pipermail/opus/2015-March/002904.html http://lists.xiph.org/pipermail/opus/2015-March/002905.html One of us probably has to rebase depending on which patch goes into opus first. Regards, Vish On 1 March 2015 at

Thanks to Jean-Marc and Tim explaining 'git rebase -i' to me, I've factored my reorganization of the Opus Intrinsics configury into a number of hopefully more comprehensible (and thus more reviewable) pieces. This applies to the current tip of Opus Master in git. Viswanath's Ne10 changes require some slight modification to apply on top of these patches, but nothing major.

On 3 March 2015 at 21:59, Jonathan Lennox <jonathan at vidyo.com> wrote: > Viswenath, > > My patch should be against the tip, but it?s the very recent tip, > including some changes this past Friday (27 Feb). I mentioned in the IRC > room a problem I discovered in creating my patch, and then later improved > the fix Tim had made for the problem. Where do you get conflicts

Hi all, I see this in configure.ac: AC_ARG_WITH(sysroot, AS_HELP_STRING([--with-default-sysroot], [Add --sysroot=<path> to all compiler invocations.]),, withval="") AC_DEFINE_UNQUOTED(DEFAULT_SYSROOT,"$withval", [Default <path> to all compiler invocations for --sysroot=<path>.]) The macro seems to suggest that I should write

Thanks to the reminder from Dan Berrange, here's a patch to make build output less verbose, by default. E.g., instead of the redundant multi-line compilation/linking commands, you'll see something like this by default: CC guestfsd-fsck.o CC guestfsd-grep.o CC guestfsd-grub.o CC guestfsd-glob.o CC guestfsd-guestfsd.o CC guestfsd-headtail.o CC

On 3 March 2015 at 22:17, Jonathan Lennox <jonathan at vidyo.com> wrote: > > On Mar 3, 2015, at 11:08 PM, Viswanath Puttagunta > <viswanath.puttagunta at linaro.org> wrote: > > > > On 3 March 2015 at 21:59, Jonathan Lennox <jonathan at vidyo.com> wrote: >> >> Viswenath, >> >> My patch should be against the tip, but it?s the very recent

I started with: - Mac OS X 10.5.8 - Xcode installed - OCaml from GODI - qemu from git autoconf is really ancient (2.61). It doesn't have AM_SILENT_RULES and although we tried to make things work when autoconf lacks this by having: m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])]) AM_SILENT_RULES([yes]) # make --enable-silent-rules the default. this nevertheless

Viswenath, My patch should be against the tip, but it?s the very recent tip, including some changes this past Friday (27 Feb). I mentioned in the IRC room a problem I discovered in creating my patch, and then later improved the fix Tim had made for the problem. Where do you get conflicts merging it to tip? In terms of merging, you posted your patch before I posted mine, so probably I should be

From: "Richard W.M. Jones" <rjones at redhat.com> Earlier versions of automake complain if they get a configuration parameter which they don't understand. The error is: configure.ac:27: error: option 'serial-tests' not recognized Use some m4 hackery to work around this. --- configure.ac | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff

Hello Jonathan, Just FYI, I started doing review of your patch and will get back to you in few days. After review, I would like to rebase your patch (as necessary) myself and do some testing.. and re-submit. Regards, Vish On 4 March 2015 at 09:00, Viswanath Puttagunta <viswanath.puttagunta at linaro.org> wrote: > > On 3 March 2015 at 22:17, Jonathan Lennox <jonathan at

Avoids the warning: libtoolize: Remember to add 'LT_INIT' to configure.ac. This is the new name for AC_PROG_LIBTOOL, so I removed that. However to use this macro we must enable AC_USE_SYSTEM_EXTENSIONS. (AC_GNU_SOURCE was removed back in 2011). --- configure.ac | 5 +++++ m4/guestfs-progs.m4 | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac

On Mar 3, 2015, at 11:08 PM, Viswanath Puttagunta <viswanath.puttagunta at linaro.org<mailto:viswanath.puttagunta at linaro.org>> wrote: On 3 March 2015 at 21:59, Jonathan Lennox <jonathan at vidyo.com<mailto:jonathan at vidyo.com>> wrote: Viswenath, My patch should be against the tip, but it?s the very recent tip, including some changes this past Friday (27 Feb). I

The autoreconf tool is provided by autoconf to do what custom autogen.sh scripts in many projects used to do. Only it is more robust and widely tested. It has been available for several years, too. No reason to rely on custom code for this. Signed-off-by: Max Horn <max at quendi.de> --- Makefile.am | 2 - autogen.sh | 168