similar to: [PATCH] btrfs-progs: do not send stream into a terminal

Short options have to be repeated at the getopt_long call. Signed-off-by: David Sterba <dsterba@suse.cz> --- btrfsck.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/btrfsck.c b/btrfsck.c index 088b9f4..2e81adc 100644 --- a/btrfsck.c +++ b/btrfsck.c @@ -3499,7 +3499,7 @@ int main(int ac, char **av) while(1) { int c; - c = getopt_long(ac, av, "",

This commit adds a command line option to enable sending streams which make use of the new end-cmd semantic if multiple snapshots are sent back-to-back. The goal is to use the <end cmd> as an indication to stop reading the input stream. So far, the receiver could only use EOF to recognize the end. If the new command line option ''-e'' is set, this commit requires a kernel

New option to subvolume list that acts as a global filter and applies the other filters to either live subvolumes or the uncleaned ones. The path to the deleted subvolumes is lost at the deletion time, sample output looks like: ID 259 gen 7 top level 0 path <FS_TREE>/DELETED Signed-off-by: David Sterba <dsterba@suse.cz> --- btrfs-list.c | 24 +++++++++++++++++++++---

A way of disabling features that are on by default in case it''s not wanted, eg. due to lack of support in the used kernel. Signed-off-by: David Sterba <dsterba@suse.cz> --- mkfs.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mkfs.c b/mkfs.c index cd0af9ef8b4f..f825e1b6bc2d 100644 --- a/mkfs.c +++ b/mkfs.c @@ -1168,7 +1168,11 @@ static int

Signed-off-by: David Sterba <dsterba@suse.cz> --- man/btrfs.8.in | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/man/btrfs.8.in b/man/btrfs.8.in index 6cb3662e28bb..b6203483296e 100644 --- a/man/btrfs.8.in +++ b/man/btrfs.8.in @@ -71,6 +71,8 @@ btrfs \- control a btrfs filesystem .PP \fBbtrfs\fP \fBrescue chunk-recover\fP [\fIoptions\fP] \fI<path>\fP .PP

From: Michal Marek <mmarek@suse.cz> The <ext2fs/ext2_types.h> header does attempt to avoid conflicts with <linux/types.h>, but on ppc64, <asm-generic/int-ll64.h> gets somehow included by other headers. Include <linux/types.h> explicitly, so that <ext2fs/ext2_types.h> notices it. The proper fix would be to fix <ext2fs/ext2_types.h> to not use its own

Extend mkfs options to specify optional or potentially backwards incompatible features. Signed-off-by: David Sterba <dsterba@suse.cz> --- man/mkfs.btrfs.8.in | 9 ++++ mkfs.c | 124 +++++++++++++++++++++++++++++++++++++++++++++++----- 2 files changed, 123 insertions(+), 10 deletions(-) diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in index a3f1503..548e754 100644 ---

On Mon, Jun 15, 2020 at 09:57:18PM -0400, Waiman Long wrote: > In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc() > was incorrectly paired with kzfree(). According to David Sterba, there > isn't any sensitive information in the subvol_info that needs to be > cleared before freeing. So kfree_sensitive() isn't really needed, > use kfree() instead. >

Rename no_space_cache option to nospace_cache to be more consistent with the rest, where the simple prefix ''no'' is used to negate an option. The option has been introduced during the -rc1 cycle and there are has not been widely used, so it''s safe. Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/super.c | 4 ++-- 1 files changed, 2 insertions(+), 2

In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc() was incorrectly paired with kzfree(). According to David Sterba, there isn't any sensitive information in the subvol_info that needs to be cleared before freeing. So kfree_sensitive() isn't really needed, use kfree() instead. Reported-by: David Sterba <dsterba at suse.cz> Signed-off-by: Waiman Long <longman

The condition can be relaxed to accept also 0 which will delete unoccupied chunks and does not need space for the actual data relocation. Until there is an automatic empty chunk reclaim, we can use this as a last resort option under enospc. CC: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: David Sterba <dsterba@suse.cz> --- Also needs progs update, but is not required for the

btree_releasepage is a callback and can be passed unknown gfp flags and then they may end up in kmem_cache_alloc called from alloc_extent_state, slab allocator will BUG_ON when there is HIGHMEM or DMA32 flag set. This may happen when btrfs is mounted from a loop device, which masks out __GFP_IO flag. The check in try_release_extent_state 3399 if ((mask & GFP_NOFS) ==

The messages btrfs: unlinked 123 orphans btrfs: truncated 456 orphans are not useful to regular users and raise questions whether there are problems with the filesystem. Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/inode.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 315a515..41a4d9c 100644 ---

The size of de/compress buffer and LZO1X_MEM_COMPRESS is small enough. Allocating it with kmalloc rather than vmalloc is preferred. This patch depends on my previous patch, “btrfs: fix decompress buffer size”. Signed-off-by: Kyungsik Lee <kyungsik.lee@lge.com> Cc: David Sterba <dsterba@suse.cz> --- fs/btrfs/lzo.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)

A subvolume cannot be deleted via rmdir, but the error code ENOTEMPTY is confusing. Return EPERM instead, as this is not permitted. Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/inode.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index a4167ef..a67dadd 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@

Historical leftovers from the time where kmap() had fixed slots. Signed-off-by: Thomas Gleixner <tglx at linutronix.de> Cc: Alexander Viro <viro at zeniv.linux.org.uk> Cc: Benjamin LaHaise <bcrl at kvack.org> Cc: linux-fsdevel at vger.kernel.org Cc: linux-aio at kvack.org Cc: Chris Mason <clm at fb.com> Cc: Josef Bacik <josef at toxicpanda.com> Cc: David Sterba

The log message level ''critical'' is verbose enough, ''emergency'' beeps on all terminals. Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/volumes.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index b2d1eac..1fd7b5d 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@

On Mon, Mar 19, 2018 at 4:29 PM, David Sterba <dsterba at suse.cz> wrote: > On Mon, Mar 19, 2018 at 05:09:28PM +0200, Michael S. Tsirkin wrote: >> Hello! >> The following code triggered by syzbot >> >> r = get_user_pages_fast(log, 1, 1, &page); >> if (r < 0) >> return r; >> BUG_ON(r != 1); >>

Alex pointed out the consequences after a transaction is not committed when a subvolume is deleted, so in case of a crash before an actual commit happens will let the subvolume reappear. Original post: http://www.spinics.net/lists/linux-btrfs/msg22088.html Josef''s objections: http://www.spinics.net/lists/linux-btrfs/msg22256.html While there''s no need to do a full commit for

Hi, The following series of patches implements in btrfs an ioctl to do out-of-band deduplication of file extents. To be clear, this means that the file system is mounted and running, but the dedupe is not done during file writes, but after the fact when some userspace software initiates a dedupe. The primary patch is loosely based off of one sent by Josef Bacik back in January, 2011.