similar to: [PATCH] btrfs: fix d_off in the first dirent

Hi, Here''s an implementation of NFS support for btrfs. It does not work in one particular case as described in http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg00298.html. This uses the btrfs_iget helper introduced previously. Comments ? --- Signed-off-by: Balaji Rao <balajirrao@gmail.com> diff -r 3f0eee804974 Makefile --- a/Makefile Thu Jun 26 10:34:20 2008 -0400

Hi all, I have a bug with OCFS through configfs : to illustrate this, try : while true ; do ls -l /sys/kernel/config/cluster/ocfs2/heartbeat ; done& while true ; do echo 31> /sys/kernel/config/cluster/ocfs2/heartbeat/dead_threshold ; done& So, I have a kernel crash : BUG: unable to handle kernel NULL pointer dereference at 0000000000000040 IP: [<ffffffffa01fd214>]

Hi all, I have a bug with OCFS through configfs : to illustrate this, try : while true ; do ls -l /sys/kernel/config/cluster/ocfs2/heartbeat ; done& while true ; do echo 31> /sys/kernel/config/cluster/ocfs2/heartbeat/dead_threshold ; done& So, I have a kernel crash : BUG: unable to handle kernel NULL pointer dereference at 0000000000000040 IP: [<ffffffffa01fd214>]

I was just playing with git 1.5.3.8 and btrfs 0.11, and I noticed something odd. If I prepare a very simple repository: $ mkdir foo $ cd foo $ git init Initialized empty Git repository in .git/ $ echo hi > blort $ git add . $ git commit -m create Created initial commit 4ae9415: create 1 files changed, 1 insertions(+), 0 deletions(-) create mode 100644 blort and then

filldir_t can take this, so don't turn de->inode into a 32 bit value. Right now this doesn't make a difference since no ocfs2 inodes overflow that, but it could be a nasty surprise later on if some kernel code is calling ocfs2_dir_foreach_blk() and expecting real inode numbers back... Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com> --- fs/ocfs2/dir.c | 2 +- 1 files

On Mon, Feb 27, 2023 at 08:01:40PM +0100, Conor Armstrong wrote: > I think it has a lot to do with telldir on an NFS share returning a cookie > that is supposed to be unique rather than an actual offset. Problem is, > that cookie is stored as a 31bit hash which can then end up as a negative > signed offset in Samba which is not handled correctly. The cookies are not >

ocfs2_queue_orphans() has an open coded readdir loop which can easily just use a directory accessor function. Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com> --- fs/ocfs2/dir.c | 28 +++++++++++-- fs/ocfs2/dir.h | 7 +-- fs/ocfs2/journal.c | 118 +++++++++++++++++++-------------------------------- 3 files changed, 70 insertions(+), 83 deletions(-) diff --git

I think it has a lot to do with telldir on an NFS share returning a cookie that is supposed to be unique rather than an actual offset. Problem is, that cookie is stored as a 31bit hash which can then end up as a negative signed offset in Samba which is not handled correctly. The cookies are not necessarily consecutive as you move through a directory. On Mon, 27 Feb 2023 at 19:00, Jeremy Allison

I'm trying to get to the bottom of where the normal directory functions differ in results for block storage compared to NFS. I created a short c script to look at the offsets generated for the directory when block storage backed in comparison to NFS backed. block storage backed are always positive: File: 5050, Offset: 9213006461214587617 File: 6567, Offset: 9218690536865144001 File: 4033,

I was flipping through the code recently and noticed that we still have the double whammy of allocating dir entry positions with parent_dir->counter++ and that weird setting of f_pos to 2^31-1. So after enough creates (and deletes :)) in a directory we end up with an entry item whose key is past that value. f_pos gets rewound instead of being set to that magical EOF. readdir() gets stuck

Thanks for the patch, unfortunately when I installed it I had a lot more files missing from the directory listing and I have not taken much time to look at why. But it certainly is the cast that off_t on the IRIX box is 8 bytes in the current OS, however the compilers seem to convert the long values properly so long as overflow does not occur. Thanks to your suggestion on looking at the

Alternately, we could possibly modify the dptr_TellDir function to set a flag somewhere if it ever returns a negative offset. Then any calls to dptr_SeekDir checks if the flag is set and does a slower approach of a RewindDir and then multiple ReadDir & TellDir calls until we get the matching offset. If flag is not set then go with the normal SeekDir call??? On Fri, 17 Feb 2023 at 00:40,

On Thu, Feb 16, 2023 at 08:46:26PM +0100, Conor Armstrong wrote: > I'm trying to get to the?bottom of where the normal directory functions > differ in results for block storage compared to NFS.? > I created a short c script to look at the offsets generated for the > directory when block storage backed in comparison to NFS backed.? > block storage backed are always

Forgot to CC: the list. ----- Forwarded message from Jeremy Allison <jra at samba.org> ----- Cc: jra at samba.org Subject: Re: [Samba] Missing Files/Missing Folders from an NFS Share On Wed, Feb 15, 2023 at 08:06:28PM +0100, Conor Armstrong wrote: > Rowland & Jeremy - thanks for this! > I built a copy of the latest version from github 4.19 and same issue > arises. ? >

On Fri, Feb 17, 2023 at 12:40:25AM +0100, Conor Armstrong wrote: > Ok, starting to make sense now.? In order to fix it.... > I note that the lower level calls are wrapped in dir.c - eg > dptr_SeekDir(...) wraps SeekDir(...) > this might allow for some code to use array indexes instead of NFS cookies > as noted by Chris Chilvers here for the 3.10 kernel: >

I post a patch for comment on ext2-devel for the NFS cookie bug. Did not get any feedback yet. As Ted suggested, it set the cookie to -1 on EOF, even though it is not seek able to there. I only test it with Stephen's "readdir.c". Not have chance to run it on a NFS server yet. Do you have more information about the cache trashing bug? Regards, Chris ===== dir.c 1.5 vs edited

Ok, starting to make sense now. In order to fix it.... I note that the lower level calls are wrapped in dir.c - eg dptr_SeekDir(...) wraps SeekDir(...) this might allow for some code to use array indexes instead of NFS cookies as noted by Chris Chilvers here for the 3.10 kernel: https://lore.kernel.org/all/CAAmbk-e-YQAPo6QyNB0aJyc9qzUShmEC+x5eTR7wqp1ABWADsg at mail.gmail.com/T/ > On the

Hello When using readdir() on a directory with many files or long file names it can happen that it returns the same file name twice. Attached is a program that demonstrates this. I have traced this problem back to linux-2.6.10-rc1-bk18 and all kernels after this one are effected. linux-2.6.10-rc1-bk17 is still okay. If I reverse the following patch in linux-2.6.10-rc1-bk18, readdir() works again

Dual Opteron system running ext3 atop drbd (network RAID) devices, which, in turn, are atop LVM logical volumes. The underlying device is hardware SCSI RAID via a LSILogic HBA. The kernel is vanilla 2.6.13 on a Gentoo-based system. A panic occurred, which contains references to ext3 code. I'm not sure how others manage to get these typed out, but I'm manually typing it from

A user has encountered a NULL pointer kernel oops in btrfs when encountering media errors. The problem has been identified as an unhandled NULL pointer returned from find_get_page(). This modification simply checks for a NULL page, and returns with an error if found (the extent_range_uptodate() function returns 1 on errors). After testing this patch, the user reported that the error with the