similar to: [Patch] Btrfs: use BTRFS_VOL_NAME_MAX for struct btrfs_ioctl_vol_args

The ''char name[BTRFS_PATH_NAME_MAX]'' member of struct btrfs_ioctl_vol_args is passed directly to strlen() after being copied from user. I haven''t verified this, but in theory a userspace program could pass in an unterminated string and cause a kernel crash as strlen walks off the end of the array. This patch terminates the ->name string in all btrfs ioctl functions

Hello I think strlen is unsafe here Regards YZ diff -r 24c661119092 inode.c --- a/inode.c Mon Sep 17 11:25:58 2007 -0400 +++ b/inode.c Thu Sep 20 22:25:34 2007 +0800 @@ -1985,7 +1988,7 @@ static int btrfs_ioctl_snap_create(struc if (copy_from_user(&vol_args, arg, sizeof(vol_args))) return -EFAULT; - namelen = strlen(vol_args.name); + namelen = strnlen(vol_args.name,

Hi everyone, This patchset is the latest approach I''m using for the Ceph storage daemon to keep track of which data has safely committed to disk. The basic idea is to not use the (problematic) user transaction ioctls at all. Instead, the daemon quiesces its own write requests, initiates an async snapshot, and then continues. The snapshot approach is nice because it provides rollback.

Please find the attached patch which replace unsafe strcpy(3) by strncpy(3) functions. regards, Eduardo Silva

>From 03115f064be2e074d84f4e2105d2cdebde10f6ba Mon Sep 17 00:00:00 2001 From: Yi Yang <yi.y.yang at intel.com> Date: Tue, 12 Jul 2011 14:53:50 +0800 Subject: [PATCH] Use a general way to get the default subvolume for btrfs --- extlinux/btrfs.h | 105 +++++++++++++++++++ extlinux/main.c | 304 ++++++++++++++++++++++++++++++++++++++++++++++++------ 2 files changed, 377 insertions(+),

This is the next patch series for scrub userland tools. Change log v1->v2: - commands now reachable as "btrfs scrub ..." instead of "btrfs filesystem scrub ..." - ability to scrub a single device instead of a whole file system - superfluous command line options removed - resume is now a separate command ("scrub resume") instead of "scrub start -r" -

This adds ioctl BTRFS_IOC_GET_FSIDS which reads the fs info through the btrfs-control Signed-off-by: Anand Jain <anand.jain@oracle.com> --- fs/btrfs/super.c | 47 ++++++++++++++++++++++++++++++++++++++----- fs/btrfs/volumes.c | 33 ++++++++++++++++++++++++++++++ fs/btrfs/volumes.h | 2 + include/uapi/linux/btrfs.h | 19 +++++++++++++++++ 4 files changed,

From: Ajesh JS <ajesh.js@hp.com> This patch provides a mechanism to modify the permission of a subvolume in a btrfs file system This helps to apply a policy of having read-write subvolume inside a read-only subvolume. One use case is to have the whole root file system as a read-only subvolume and have /etc as a read-write subvolume inside. Signed-off-by: Ajesh JS <ajesh.js@hp.com>

From: anand jain <anand.jain@oracle.com> Anand Jain (1): [RFC] Add btrfs autosnap feature Makefile | 6 +- autosnap.c | 1553 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ autosnap.h | 81 +++ btrfs-list.c | 140 +++++- btrfs.c | 46 ++- btrfs_cmds.c | 186 +++++++- btrfs_cmds.h | 3 +- scrub.c | 1 + 8 files changed, 1982 insertions(+), 34

Hi Chris, This is the extent of my current queue of Btrfs snapshot/subvol/commit stuff. Most of these were posted several months ago. Can be sent upstream during this merge window? Not having this functionality is becoming a bit of a roadblock for our efforts to keep the Ceph data in a consistent state. These patches are also available from

[root@btrfs progs-unstable]# btrfsctl -A /dev/sdb ioctl returns 0 [root@btrfs progs-unstable]# btrfsctl -A /dev/sdc ioctl returns 0 /dev/sdb has a btrfs, while /dev/sdc is blank. What''s that output supposed to mean ? Is it a bug ? -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info

In snapshot destroy the dentry used for parent was the snapshot dentry itself. Remove d_invalidate since always return EBUSY, making possible to remove a snapshot using the btrfsctl -D option. Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com> --- fs/btrfs/ioctl.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index

Hello, I''ve just pulled btrfs-progs from the new git repo git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git However, when I come to make it fails like so: gcc -Wp,-MMD,./.btrfsctl.o.d,-MT,btrfsctl.o -Wall -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -g -Werror -Os -c btrfsctl.c gcc -g -Werror -Os -o btrfsctl btrfsctl.o ctree.o disk-io.o radix-tree.o extent-tree.o

Add a mount option user_subvol_rm_allowed that allows users to delete a (potentially non-empty!) subvol when they would otherwise we allowed to do an rmdir(2). We duplicate the may_delete() checks from the core VFS code to implement identical security checks (minus the directory size check). Signed-off-by: Sage Weil <sage@newdream.net> --- fs/btrfs/ctree.h | 1 + fs/btrfs/ioctl.c |

E.g. btrfsctl -r -4000m /dev/sda5 results in: ioctl:: Inappropriate ioctl for device Distribution: Ubuntu 10.10 Kernel: 2.6.35-22-generic According to the Synaptic Package manager, the version of btrfs-tools is 0.19+20100601-3 Other information that can be of interest: - I started Ubuntu on a live CD - before invoking the btrfsctl command I invoked apt-get update. I have googled but have not

From: Anand Jain <anand.jain@oracle.com> (This patch is for the review/test not yet for the integration). Here is an implementation of the feature to add label to the subvolume and snapshots. Which would help sysadmin to better manager the subvol and snapshots. This can be done in two ways, one - using attr which is user land only changes but drawback is able to change the label

Good afternoon btrfs, I have been having issues with snapshots not reading the whole file tree below them. I have installed new btrfs-progs from git://git.darksatanic.net/repo/btrfs-progs-unstable.git made and installed them. My tree is: /Btrfs | |__ nfs1 | |__ data |

Hello, This patch series adds an initial implementation of restriper (it''s a clever name for relocation framework that allows to do selective profile changing and selective balancing with some goodies like pausing/resuming and reporting progress to the user. Profile changing is global (per-FS) so far, per-subvolume profiles require some discussion and can be implemented in future.

Thanks for the quick reply! But I still have problems with btrfsctl: > stat /dev/btrfs-control File: `/dev/btrfs-control'' Size: 0 Blocks: 0 IO Block: 4096 block special file Device: ch/12d Inode: 659848 Links: 1 Device type: a,3e Access: (0644/brw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2010-01-09 11:31:15.757979602 +0100

I''ve just finished installing onto an OCZ Agilent v2 SSD with btrfs as filesystem. However to my surprise I''ve hit an ENOSPC condition one one of the partitions within less than a day of uptime, while the filesystem on that partition only reported 50% to be in use, which is far from the 75% limit people mention on the ML. Note that this occurs using a vanilla 2.6.32-rc5 kernel