similar to: [PATCH] btrfs: cleanup d_obtain_alias useage

People kept reporting NFS issues, specifically getting ESTALE alot. I figured out how to reproduce the problem SERVER mkfs.btrfs /dev/sda1 mount /dev/sda1 /mnt/btrfs-test <add /mnt/btrfs-test to /etc/exports> btrfs subvol create /mnt/btrfs-test/foo service nfs start CLIENT mount server:/mnt/btrfs /mnt/test cd /mnt/test/foo ls SERVER echo 3 > /proc/sys/vm/drop_caches CLIENT ls

Hi, Here''s an implementation of NFS support for btrfs. It does not work in one particular case as described in http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg00298.html. This uses the btrfs_iget helper introduced previously. Comments ? --- Signed-off-by: Balaji Rao <balajirrao@gmail.com> diff -r 3f0eee804974 Makefile --- a/Makefile Thu Jun 26 10:34:20 2008 -0400

Apparently we don''t actually close the files until we return to userspace, so stop using vfs_read in send. This is actually better for us since we can avoid all the extra logic of holding the file we''re sending open and making sure to clean it up. This will fix people who have been hitting too many files open errors when trying to send. Thanks, Signed-off-by: Josef Bacik

This happens on a freshly created btrfs filesystem in a raid10 (4x1TB) configuration with three subvolumes and 1.5 TB data. When I try to snapshot one of the subvolumes (with 100 GB of data), it says that the snapshot creation failed and I get the following error message: btrfs: could not do orphan cleanup -116 After the failure: - The snapshot exists in `btrfs subvolume list'' - The

btrfs_ilookup is unused, which is good because a normal filesystem should never have to use ilookup anyway. Remove it. Signed-off-by: Christoph Hellwig <hch@lst.de> Index: btrfs-unstable/ctree.h =================================================================== --- btrfs-unstable.orig/ctree.h 2008-08-30 11:08:58.000000000 -0300 +++ btrfs-unstable/ctree.h 2008-08-30 11:09:10.000000000

We currently set sb->s_flags |= MS_POSIXACL unconditionally, which is incorrect -- it tells the VFS that it shouldn''t set umask because we will, yet we don''t set it ourselves if we aren''t using POSIX ACLs, so the umask ends up ignored. Signed-off-by: Chris Ball <cjb@laptop.org> --- fs/btrfs/super.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

Currently orphan cleanup only ever gets triggered if we cross subvolumes during a lookup, which means that if we just mount a plain jane fs that has orphans in it, they will never get cleaned up. This results in panic''s like these http://www.kerneloops.org/oops.php?number=1109085 where adding an orphan entry results in -EEXIST being returned and we panic. In order to fix this, we

The return value of btrfs_lookup_dentry is checked so that the panic such as illegal address reference should not occur. Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com> --- V1->V2: unnecessary BUG_ON was deleted V2->V3: to return -ENOENT instead of NULL when no entry was found, return value of btrfs_lookup_dentry is changed. fs/btrfs/inode.c | 10 +++++++---

In fixing how we deal with bad inodes, we had a regression in the orphan cleanup code, since it expects to get a bad inode back. So fix it to deal with getting -ESTALE back by deleting the orphan item manually and moving on. Thanks, Reported-by: Simon Kirby <sim@hostway.ca> Signed-off-by: Josef Bacik <josef@redhat.com> --- fs/btrfs/inode.c | 36

Clean up btrfs_lookup_dentry() to never return NULL, but PTR_ERR(-ENOENT) instead. This keeps the return value convention consistent. Callers who use btrfs_lookup_dentry() require a trivial update. create_snapshot() in particular looks like it can also lose a BUG_ON(!inode) which is not really needed - there seems less harm in returning ENOENT to userspace at that point in the stack than there

Good morning, I'm trying to build ocfs2-1.4.7 against a Centos 5.3 distro with a 2.6.30 kernel. I get the following errors during compilation. make[1]: Entering directory `/root/src/ocfs2-1.4.7/fs' make -C ocfs2 stamp-md5 make[2]: Entering directory `/root/src/ocfs2-1.4.7/fs/ocfs2' make[2]: Leaving directory `/root/src/ocfs2-1.4.7/fs/ocfs2' make -C ocfs2/cluster stamp-md5

Hello all, I know it''s a Prototype question, but I hope someone can tell me what I''m doing wrong (I hope Prototype gets documented soon ;-( Problem: using a onComplete callback with Ajax.PeriodicalUpdater (using scriptaculous 1.5 with Prototype 1.4) Works: function fooBar() { Element.hide(''foobar''); } new

Under Centos 5.X, how can I determine with 100% certainty what driver is associated with a given device other than referencing dmesg? For example, what tool can I use to tell for sure what driver is attached to my eth0 device? I have searched the web, but could not find anything that answered my question. Geoff Galitz Blankenheim NRW, Deutschland http://www.galitz.org

>From a quick look at the source code, it looks like onComplete is only called when the whole thing is done - in the case of Updater, right after the update, in the case of PeriodicalUpdater, right after it has been stopped. It looks like you need to pass your callback method as an ''insertion'' method in the options. This takes two parameters, the first will probably be the

The only call that PeriodicalUpdater will make periodically to you is the insertion call. I think of onComplete as being ''I''ve done everything I was going to do'', which for Updater is right after it''s done a single update, but for PeriodicalUpdater, it''s after it''s finished all of its updates, so you''ll only get it once for any call

changes from v3: 1, move codes that checks inode allocation bit to subfunction ocfs2_test_inode_bit(). 2, release the suballoc lock just after we get it. we should release it asap and doing so doesn't affect functionility. 3, add inode alloc slot validation. Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com> -- dlmglue.c | 45 +++++++++++++++++ dlmglue.h | 2

#against V6, corrects some format problem pointed out by checkpatch.pl. For nfs exporting, ocfs2_get_dentry() returns the dentry for fh. ocfs2_get_dentry() may read from disk(when inode not in memory) without any cross cluster lock. this leads to load a stale inode. this patch fixes above problem. solution is that in case of inode is not in memory, we get the cluster lock(PR) of alloc inode

#against V6.2, add indentation. For nfs exporting, ocfs2_get_dentry() returns the dentry for fh. ocfs2_get_dentry() may read from disk(when inode not in memory) without any cross cluster lock. this leads to load a stale inode. this patch fixes above problem. solution is that in case of inode is not in memory, we get the cluster lock(PR) of alloc inode where the inode in question is allocated

changes from v4: 1, let suballoc lock covers the checking of the group. 2, add/correct some log messages. 3, use ocfs2_read_group_descriptor() instead of diry reading the group. Signed-off-by: Wengang Wang <wen.gang.wang at oracle.com> -- dlmglue.c | 45 ++++++++++++++++ dlmglue.h | 2 export.c | 77 +++++++++++++++++++++++++-- inode.c | 24 ++++++++

Each of these drivers has a copy of the same trivial helper function to convert the pointer argument and then call the native ioctl handler. We now have a generic implementation of that, so use it. Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org> Acked-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen at linux.intel.com>