similar to: Making the tests faster

When possible, make the disk image format explicit when invoking tools or using add-drive. This avoids warnings from qemu about the unspecified format for the image, and also makes qemu slightly faster (skipping the disk image probing). Tests checking the image probing are not touched. This changes also: - old-style invocations of tools (`$tool $filename`) into new style (`$tool -a $filename`)

By adding common CLEANFILES and DISTCLEANFILES variables to common-rules.mk, we can remove these from most other Makefiles, and also clean files more consistently. Note that bin_PROGRAMS are already cleaned by 'make clean', so I removed cases where these were unnecessarily added to CLEANFILES. --- .gitignore | 1 + Makefile.am | 6

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- align/Makefile.am | 2 +- builder/Makefile.am | 2 +- builder/website/Makefile.am | 2 +- cat/Makefile.am | 4 ++-- common-rules.mk | 8 ++++---- customize/Makefile.am | 2 +- df/Makefile.am | 4 ++-- diff/Makefile.am | 2 +-

Prune from the list of sources where to extract messages various sources with no messages: - .pl and .pm files, as they do not contain messages: almost all the .pl files are tests, and the only .pm file is the Perl Sys::Guestfs module, which wraps the XS extension - dummy.c sources; they are empty sources used to build OCaml-only targets using automake - gperf generated sources - C/OCaml

On Fri, Feb 09, 2018 at 06:01:53PM +0000, Richard W.M. Jones wrote: > My contention is that the libguestfs git repository is too large and > unwieldy. There are too many separate, unrelated projects and as a > result of that the source has too many dependencies and takes too long > to build and test. > > The project divides (sort of) naturally into layers -- the library, >

If you have a struct containing ?field?, eg: type t = { field : int } then previously to pattern-match on this type, eg. in function parameters, you had to write: let f { field = field } = (* ... use field ... *) In OCaml >= 3.12 it is possible to abbreviate cases where the field being matched and the variable being bound have the same name, so now you can just write: let f {

Just code motion. This commit makes it clearer what is a utility and what is part of the library. It also makes it clear that we should rename: guestfs-internal-frontend.h -> utils.h guestfs-internal-frontend-cleanups.h -> cleanups.h (?) but this commit does not make that change. --- .gitignore | 10 ++--- Makefile.am

I'm pleased to announce the latest stable release of libguestfs, a library and a set of tools for reading, writing, managing, inspecting, rescuing, resizing and aligning disk images, and offline and live virtual machines. There are many new features and bug fixes in this release; see the release notes below. You can get libguestfs 1.18.0 from: Main website: http://libguestfs.org Source:

The new module ‘Std_utils’ contains only functions which are pure OCaml and depend only on the OCaml stdlib. Therefore these functions may be used by the generator. The new module is moved to ‘common/mlstdutils’. This also removes the "<stdlib>" hack, and the code which copied the library around. Also ‘Guestfs_config’, ‘Libdir’ and ‘StringMap’ modules are moved since these are

Add a bash function 'prepend' for intelligently prepending elements to paths. eg: prepend PYTHONPATH "/foo" would set PYTHONPATH to "/foo" or "/foo:<previous-contents-of-PYTHONPATH>" Tested by: (1) Building and testing libguestfs twice: first without libguestfs installed as a system library, and then with it installed. (2) Examining the output of

Look for libint/gettext and link to it; this properly detects whether libint is part of libc. --- align/Makefile.am | 1 + builder/Makefile.am | 2 ++ cat/Makefile.am | 4 ++++ configure.ac | 3 +++ customize/Makefile.am | 2 +- df/Makefile.am | 1 + diff/Makefile.am | 1 + edit/Makefile.am | 1 + erlang/Makefile.am

On Tue, Nov 04, 2014 at 04:35:26PM +0100, Pino Toscano wrote: > Look for libint/gettext and link to it; this properly detects whether > libint is part of libc. I'm a little confused by this patch, and also worried that it may be reverting commit 75514ab57a. Does this require gettextize? Rich. > --- > align/Makefile.am | 1 + > builder/Makefile.am | 2 ++ >

Hardcoding -ltinfo breaks on distros that do not build the sep library (which is the default ncurses behavior). Use pkg-config to look up the right libraries regardless of how the distro built things. --- builder/Makefile.am | 5 +++-- configure.ac | 18 ++++++------------ customize/Makefile.am | 2 +- mllib/Makefile.am | 6 +++--- resize/Makefile.am | 2 +-

In tools except guestfish, we don't use ncurses, or even curses, just 2 termcap functions and a global variable. These are provided by libtinfo, so just link to that. In guestfish we use readline which needs ncurses. Leave that alone. --- builder/Makefile.am | 2 +- configure.ac | 12 ++++++------ customize/Makefile.am | 2 +- mllib/Makefile.am | 6 +++---

Certain functions are intended to be internal only, but we currently export them anyway. This change moves them into a separate section of guestfs.h protected by a GUESTFS_PRIVATE variable. This change also enables private structs, but doesn't implement any. This change only affects the C api. Language bindings aren't affected, but probably should be in the future. --- align/Makefile.am

I am trying to install the libguestfs python bindings in my virtualenv. Since this cannot be done through PIP, I was trying to do the following: https://github.com/libguestfs/libguestfs/commit/fcbfc4775fa2a44020974073594a745ca420d614 To get to building the python dist, I did the following: git clone https://github.com/libguestfs/libguestfs.git git checkout 1.28.5 ./autogen.sh --disable-php

On Thu, Jan 17, Richard W.M. Jones wrote: > On Wed, Jan 16, 2013 at 05:51:53PM +0100, Olaf Hering wrote: > > On Mon, Jan 14, Olaf Hering wrote: > > > This is a first attempt to build libguestfs with just a ocaml bytecode > > > compiler. The three tools written in ocaml will be build only when an > > > ocamlopt compiler is available. > > Here is a more

On Thursday 12 February 2015 17:49:55 Margaret Lewicka wrote: > * Replace LD_LIBRARY_PATH with DYLD_LIBRARY_PATH for Darwin > * Remove the -lcrypt flag for Darwin (unsupported) > --- > configure.ac | 13 +++++++++++++ > run.in | 10 +++++----- > v2v/link.sh.in | 2 +- > 3 files changed, 19 insertions(+), 6 deletions(-) > > diff --git a/configure.ac

>> I am trying to install the libguestfs python bindings in my >> virtualenv. Since this cannot be done through PIP, > > The PIP problem is https://bugzilla.redhat.com/show_bug.cgi?id=1075594 > Unfortunately we are stuck here because the pypi website still has a > license that we cannot live with (it would have the effect of > assigning all work we upload to them). They

--- builder/Makefile.am | 18 +++++++++++++- configure.ac | 2 ++ mllib/Makefile.am | 60 +++++++++++++++++++++++++++++++--------------- ocaml/Makefile.am | 28 +++++++++++++++------- ocaml/examples/Makefile.am | 13 ++++++++++ resize/Makefile.am | 18 +++++++++++++- sparsify/Makefile.am | 18 +++++++++++++- sysprep/Makefile.am | 18