similar to: [PATCH] x86: fix null pointer dereference in intel_get_extended_msrs()

No, just no. You do not use goto to skip a code block. You do not return an obvious variable from a singly-inlined function and give the function a return value. You don't put unexplained comments about kmalloc in code which doesn't do dynamic allocation. And you don't leave stray warnings around for no good reason. Also, when possible, it is better to use block scoped variables

No, just no. You do not use goto to skip a code block. You do not return an obvious variable from a singly-inlined function and give the function a return value. You don't put unexplained comments about kmalloc in code which doesn't do dynamic allocation. And you don't leave stray warnings around for no good reason. Also, when possible, it is better to use block scoped variables

Dump mce log by ERST when mc panic We have implemented basic ERST logic before. Now linux3.0 as dom0 has included APEI logic. Hence it''s time to add mce apei interface and enable APEI ERST feature. With it, it can save mce log by ERST method when mc panic. Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> diff -r ca2f58c2dfea xen/arch/x86/cpu/mcheck/mce.c ---

Xen/MCE: vMCE injection In our test for win8 guest mce, we find a bug that no matter what SRAO/SRAR error xen inject to win8 guest, it always reboot. The root cause is, current Xen vMCE logic inject vMCE# only to vcpu0, this is not correct for Intel MCE (Under Intel arch, h/w generate MCE# to all CPUs). This patch fix vMCE injection bug, injecting vMCE# to all vcpus. Signed-off-by: Liu,

All, Can you use the global variables set in the [globals] section of the extension.conf file in other configuration files? Here is an example: I have a file called globalvars.conf that I include in the [globals] section in extension.conf. I would like either (a) that the global variables being defined in this section can be used from voicemail.conf or (b) that I can include the

Please consider adding the following to the next R release (I understand that it's too late for R-2.1.0). It adds the menu item `Search R Site' in the `Help' menu in Rgui (which calls RSiteSearch() on the input string). Best, Andy --- R-beta/src/gnuwin32/rui.c 2005-03-06 09:41:40.000000000 -0500 +++ R-beta-new/src/gnuwin32/rui.c 2005-04-12 08:21:55.001824500 -0400 @@ -65,7 +65,8 @@

Currently number of error reporting register banks is hardcoded to 6 on AMD processors. This may break in virtualized scenarios when a hypervisor prefers to report fewer banks than what the physical HW provides. Since number of supported banks is reported in MSR_IA32_MCG_CAP[7:0] that''s what we should use. Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> ---

Currently number of error reporting register banks is hardcoded to 6 on AMD processors. This may break in virtualized scenarios when a hypervisor prefers to report fewer banks that the physical HW provides. Since number of supported banks is reported in MSR_IA32_MCG_CAP[7:0] that''s what we should use. Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> ---

Debian bug 812166[0] reported this build failure due to Wmisleading-indentation with gcc-6: non-fatal.c: In function 'init_nonfatal_mce_checker': non-fatal.c:103:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] switch (c->x86_vendor) { ^~~~~~ non-fatal.c:97:5: note: ...this 'if' clause, but it is not if (

Jan, This patch just used to stick all 1''s to MCi_CTL, it should not involve much argue, so I sent it separately. Thanks, Jinsong ==================== Xen/MCE: stick all 1''s to MCi_CTL of vMCE This patch is a middle-work patch, prepare for future new vMCE model. It remove mci_ctl array, and keep MCi_CTL all 1''s. Signed-off-by: Liu, Jinsong

Heya All, Im having difficulties compiling rsync. when i run 'make' the build errors out on me. I run configure without any fancy options. The same goes for the make command. I have had this error, or a similar one since version 2.5.1 op to at least v2.5.5 I am using "-O3 -mcpu=i686 -march=i686" as additional compiler flags, however removing them does not make difference.

Hello for all, I'm looking for someone that are using icecast on AIX (my oslevel 4.3.3.0, and gcc 2.95.3.0), or someone could help me. I'm trying to compile icecast and get some error, see below... Thank's Anibal ------------------- # ./configure loading cache ./config.cache Building icecast-1.3.12... checking for a BSD compatible install... ./install-sh -c checking whether

Hi Andi, This is a set of updates for the firstfloor patch queue. Quick rundown: revert-mm-x86_64-mm-account-for-module-percpu-space-separately-from-kernel-percpu.patch separate-module-percpu-space.patch Update the module percpu accounting patch fix-ff-allow-percpu-variables-to-be-page-aligned.patch Make sure the percpu memory allocation is page-aligned

Hi Andi, This is a set of updates for the firstfloor patch queue. Quick rundown: revert-mm-x86_64-mm-account-for-module-percpu-space-separately-from-kernel-percpu.patch separate-module-percpu-space.patch Update the module percpu accounting patch fix-ff-allow-percpu-variables-to-be-page-aligned.patch Make sure the percpu memory allocation is page-aligned

On an i686 with glibc 2.5 installed I'm not able to compile rsync 3.0.2 and later. rsync 3.0.0 was no problem, this compiled. Also on an x86_64 with glibc 2.7 installed rsync compiled. Here is a script of the failing comilation: Script started on Sat May 10 07:33:39 2008 teddy@mail /usr/src/rsync-HEAD-20080508-0612GMT $ mkdir build teddy@mail /usr/src/rsync-HEAD-20080508-0612GMT $ cd build

Since writing this I've recompiled with zlib 1.1.4 and everything appears smooth. Since this is intermittant, I'll send it off anyways in the hops that someone else may see it. It also *might* apply to the "known issues" entry about "unexpected close." (Similar symptoms, but it may just be a shared codepath on the messages. Note that the dumped len in my output(4)

Boris, Here is the updated patch for determining number of regiter banks on AMD plus a patch removing shared_bank array, as you suggested. Offline/online testing didn''t show any issues. Boris Ostrovsky (2): x86/mce: Replace shared_bank array with is_shared_bank() helper x86/mce: Use MCG_CAP MSR to find out number of banks on AMD arch/x86/kernel/cpu/mcheck/mce_amd.c | 38

Hello all, I am trying to get Icecast working on my FreeBSD box. I did the following: ./configure --with-crypt The output looked good, there were no errors, I was instructed to run `make`, I did so and received the following: -- make all-recursive Making all in src Making all in authenticate gcc -DHAVE_CONFIG_H -I. -I. -I../.. -D_REENTRANT -I../../src -pthread -pthreads -g -Wall -c

Hi Ingo, Please pull a few more cpus4096 changes. Most are fairly lightweight with the biggest change being to use cpumask_var_t's for the domain and pending_mask cpumask's in irq_desc. It also deals with this cpu_evtchn_mask bss space bump: 65536 +2031616 2097152 +3100% cpu_evtchn_mask(.bss) Everything merges into tip/master cleanly. Thanks! Mike The following changes since

Hi Ingo, Please pull a few more cpus4096 changes. Most are fairly lightweight with the biggest change being to use cpumask_var_t's for the domain and pending_mask cpumask's in irq_desc. It also deals with this cpu_evtchn_mask bss space bump: 65536 +2031616 2097152 +3100% cpu_evtchn_mask(.bss) Everything merges into tip/master cleanly. Thanks! Mike The following changes since