similar to: [Bug 63263] New: X server crash in nouveau_xv.c:NVPutImage (NVCopyNV12ColorPlanes)

The 'w' argument to NVCopyNV12ColorPlanes is used to index into the source image. line_len is rounded up to 8 on NV50+, so if the source image (+ left offset) is not rounded to 8, NVCopyNV12ColorPlanes could read past the end of the array and crash X. This change can cause the last few horizontal pixels of dst to not be initialized, but they should be truncated by the renderer anyways.

int i is accessed outside immediate scope so leave declaration at the highest common scope level: 1073: int ret, i; ... // Highest common scope ... 1193: if (newTTSize <= destination_buffer->size) { ... // Used in this scope ... 1248: } else { ... // Used in this scope ... 1316: }

The control flow was: if (!y) { ppix = ... } if (y) { ... } else if (x) { use ppix for something } else { use ppix for something } Merge the if(!y) block with the two else branches. This avoids a false-positive in the clang static analyzer, it can't know that !y and x are mutually exclusive. The result looks something like this: if (y) { ... } else { ppix = ... if (x) {

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nouveau_xv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 8eafcf0..567e30c 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -552,8 +552,11 @@ NVCopyNV12ColorPlanes(unsigned char *src1, unsigned char *src2, if (e) { unsigned short *vud = (unsigned

Warning reported by gcc 8.2: nouveau_xv.c: In function ‘NVPutImage’: nouveau_xv.c:1369:7: warning: declaration of ‘ret’ shadows a previous local [-Wshadow] int ret = BadImplementation; ^~~ nouveau_xv.c:1073:6: note: shadowed declaration is here int ret, i; ^~~ Fixes: a50bba6 ("xv: misc cleanups") Cc: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Rhys Kidd

memcpy() goes from taking 45% to 66% of total function time, which translates to a 30% decrease in NVPutImage runtime. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nouveau_xv.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 567e30c..5569b7c 100644 --- a/src/nouveau_xv.c +++

- added lots of comments, discussed comments with ahuillet and refined comments - replaced two constants with MACROs - no changes to actual code diff --git a/src/nv_video.c b/src/nv_video.c index cf4f88d..d9ee700 100644 --- a/src/nv_video.c +++ b/src/nv_video.c @@ -25,6 +25,15 @@ #include "nv_include.h" #include "nv_dma.h" +/* +2046 is the maximum image size in one

Hi all, these are the remaining unapplied patches of the ARM HDLCD patch series. Changes in v7: - rebased on b61ed421d2c85b5b106c63f2c14f8aa162b282f0; - turn more printk and panic into early_printk and early_panic. Changes in v6: - rebased on 77d3a1db3196b1b5864469f8d3f41d496800c795; - remove useless initializations to NULL in lfb_init; - more compact checks in lfb_init. Changes in v5: - move

On 01/07/2013 12:51 PM, syslinux-bot for Matt Fleming wrote: > Commit-ID: 15a67011987c341814533ac4d8e23c9a72dc7605 > Gitweb: http://www.syslinux.org/commit/15a67011987c341814533ac4d8e23c9a72dc7605 > Author: Matt Fleming <matt.fleming at intel.com> > AuthorDate: Mon, 7 Jan 2013 14:42:16 +0000 > Committer: Matt Fleming <matt.fleming at intel.com> > CommitDate:

http://bugs.freedesktop.org/show_bug.cgi?id=19860 Summary: xv texture adaptor kills X Product: xorg Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org ReportedBy:

Hi there, I got a problem when trying to read in a .cel file using ReadAffy(). R codes: require(affy) ReadAffy(filenames="CH1.CEL") It failed and I got the error, Error in read.celfile.header(as.character(filenames[[1]])) : Is CH1.CEL really a CEL file? tried reading as text, gzipped text, binary, gzipped binary, command console and gzipped command console formats Also, I tried

For now pixmaps will only be tiled if driver pixmaps are being used and we're told to with the NOUVEAU_CREATE_PIXMAP_TILED usage hint. Signed-off-by: Francisco Jerez <currojerez at riseup.net> --- src/nouveau_exa.c | 31 ++++++++++++++++++++----------- src/nv50_exa.c | 6 +++--- src/nv50_xv.c | 2 +- src/nv_proto.h | 2 +- src/nv_type.h | 1 + 5 files

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Full log below, but most notably: - Better 30bpp handling - DP-MST hotplug support - DRI3/Present support in the presence of rotated RandR screens - Updates for various Xorg API changes - Autoconf cleanups Adam Jackson (1): modesetting: Validate the atom for enum properties Ilia Mirkin (10): man: remove reference to glamor under

Fixes warning with gcc 8.2: nouveau_xv.c: In function ‘NVInitVideo’: nouveau_xv.c:2247:68: warning: passing argument 2 of ‘vlCreateAdaptorXvMC’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] adaptorsXvMC[0] = vlCreateAdaptorXvMC(pScreen, textureAdaptor[0]->name); ~~~~~~~~~~~~~~~~~^~~~~~ In file included from

ssh-keyscan may, under very specific circumstances, be vulnerable to something akin to a buffer overflow. It's probably impossible to exploit, though, if only because ssh-keyscan is not usually run on very large untrusted input files. ssh-keyscan uses an fgets() wrapper that uses an unsigned int to keep track of the length of a buffer holding the current line. On machines with sufficient

Hi, This patch implements a minimal getpwnam() function in tftpd.c. The reason for the patch is that I needed tftpd to work in my embedded system, which are without libnss*. The patch has been tested, and works for me. Please consider it. Best regards, jules -- Jules Colding <JuBColding at yorkref.com> York Refrigeration diff -urN tftp-hpa-0.34.orig/tftpd/Makefile

On Sat, 19 Jan 2019 at 18:32, Ilia Mirkin <imirkin at alum.mit.edu> wrote: > Is vlCreateAdaptorXvMC just silly, or does it really want to take > ownership of the name pointer? > vlCreateAdaptorXvMC( ) doesn't need to take over ownership of the name pointer, so yes - I guess it's being silly in one respect by not being specific about const. > > On Sat, Jan 19, 2019

Is vlCreateAdaptorXvMC just silly, or does it really want to take ownership of the name pointer? On Sat, Jan 19, 2019 at 6:30 PM Rhys Kidd <rhyskidd at gmail.com> wrote: > > Fixes warning with gcc 8.2: > > nouveau_xv.c: In function ‘NVInitVideo’: > nouveau_xv.c:2247:68: warning: passing argument 2 of ‘vlCreateAdaptorXvMC’ discards ‘const’ qualifier from pointer target type

Silences warning with gcc 8.2: nouveau_xv.c: In function ‘NVInitVideo’: nouveau_xv.c:2247:68: warning: passing argument 2 of ‘vlCreateAdaptorXvMC’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] adaptorsXvMC[0] = vlCreateAdaptorXvMC(pScreen, textureAdaptor[0]->name); ~~~~~~~~~~~~~~~~~^~~~~~ In file included

Hi! With current git version of xorg-server when I try to compile xf86-video-nouveau I got these errors: nouveau_exa.lo nouveau_exa.c: In function 'nouveau_exa_create_pixmap': nouveau_exa.c:325:3: warning: 'Xcalloc' is deprecated (declared at /usr/include/xorg/os.h:225) nouveau_exa.c:331:2: warning: 'Xcalloc' is deprecated (declared at /usr/include/xorg/os.h:225)