similar to: patch for backlight control with gt 525M (c0)

Reviewed-by: Lyude Paul <lyude at redhat.com> (Also note to Mark: this is my way of letting you know someone fixed the regression with backlight controls upstream, looking into the weird bright screen after resume issue) On Sun, 2023-03-26 at 22:54 +0200, Hans de Goede wrote: > The nouveau code used to call drm_fb_helper_initial_config() from > nouveau_fbcon_init() before calling

The nouveau code used to call drm_fb_helper_initial_config() from nouveau_fbcon_init() before calling drm_dev_register(). This would probe all connectors so that drm_connector->status could be used during backlight registration which runs from nouveau_connector_late_register(). After commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") the fbdev emulation code, which

Several nvidia-based systems don't support backlight control via the standard ACPI control mechanisms. Instead, it's necessary for the driver to modify the backlight control registers directly. This patch adds support for determining whether the registers appear to be in use, and if so registers a kernel backlight device to control them. The backlight can then be controlled via

Known issues before merge: - Currently requires acpi_backlight=vendor kernel param - 0x5e always valid? Signed-off-by: Roy Spliet <r.spliet at student.tudelft.nl> Tested-by: Rick Hendricksen --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 20 +++++++++++++++++--- drivers/gpu/drm/nouveau/nouveau_display.c | 4 ++++ drivers/gpu/drm/nouveau/nouveau_display.h | 7 +++++++ 3 files

Patches 1-5 are Reviewed-by: Karol Herbst <kherbst at redhat.com> I think it might be worth to test those patches on a system without any backlight devices just to verify we don't break things, but the code looked good already, so maybe we don't really need to test. On Thu, Aug 23, 2018 at 3:21 AM, Lyude Paul <lyude at redhat.com> wrote: > Remember, ida IDs start at 0, not

Signed-off-by: Faris Alsalama <farisbenbrahem at gmail.com> --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c index 89eb460..dd1cc9b 100644 --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c @@ -232,6

fixes d9c0aadc5aa241df26ce8301d34a8418919fb5ae Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drm/nouveau/nouveau_backlight.c | 7 +++++++ drm/nouveau/nv50_display.c | 4 ++-- drm/nouveau/nv50_display.h | 4 ++++ 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drm/nouveau/nouveau_backlight.c b/drm/nouveau/nouveau_backlight.c index 380f3402..057708da

Remember, ida IDs start at 0, not 1! Signed-off-by: Lyude Paul <lyude at redhat.com> Cc: stable at vger.kernel.org Cc: Jeffery Miller <jmiller at neverware.com> Cc: Karol Herbst <kherbst at redhat.com> --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c

Remember, ida IDs start at 0, not 1! Signed-off-by: Lyude Paul <lyude at redhat.com> Reviewed-by: Karol Herbst <kherbst at redhat.com> Cc: stable at vger.kernel.org --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c index

This series fixes some issues with nouveau's backlight support that were causing kernel panics on module reloads, specifically on systems with nouveau handling the backlight of one of the displays. While we're at it, let's cleanup nouveau_backlight.c as well Lyude Paul (5): drm/nouveau: Check backlight IDs are >= 0, not > 0 drm/nouveau: Move backlight device into

fixes d9c0aadc5aa241df26ce8301d34a8418919fb5ae Suggested-by: Ben Skeggs <skeggsb at redhat.com> Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drm/nouveau/nouveau_backlight.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drm/nouveau/nouveau_backlight.c b/drm/nouveau/nouveau_backlight.c index 380f3402..55172655 100644 ---

The Apple GMUX is the one managing the backlight, so there is no need for Nouveau to register its own backlight interface. v2: Do not split information message on two lines as it prevents from grepping it, as pointed out by Lukas Wunner v3: Add a missing end-of-line character to the printed message Signed-off-by: Pierre Moreau <pierre.morrow at free.fr> ---

From: Pierre Moreau <pierre.morrow at free.fr> The Apple GMUX is the one managing the backlight, so there is no need for Nouveau to register its own backlight interface. v2: Do not split information message on two lines as it prevents from grepping it, as pointed out by Lukas Wunner Signed-off-by: Pierre Moreau <pierre.morrow at free.fr> ---

The Apple GMUX is the one managing the backlight, so there is no need for Nouveau to register its own backlight interface. Signed-off-by: Pierre Moreau <pierre.morrow at free.fr> --- drm/nouveau/nouveau_backlight.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drm/nouveau/nouveau_backlight.c b/drm/nouveau/nouveau_backlight.c index 41330e4..94ac3cb 100644 ---

On Thu, Jun 30, 2016 at 12:30:56PM +0100, Chris Wilson wrote: > Backlights controlled by i915.ko and only associated with its connectors > and also only associated with the intel_drmfb fbcon, controlled by > i915.ko. In this situation, we already handle adjusting the backlight > when the fbcon is blanked/unblanked and do not require backlight trying > to do the same. > >

Currently, every backlight interface created by Nouveau uses the same name, nv_backlight. This leads to a sysfs warning as it tries to create an already existing folder. This patch adds a incremented number to the name, but keeps the initial name as nv_backlight, to avoid possibly breaking userspace; the second interface will be named nv_backlight1, and so on. Bugzilla:

Currently, every backlight interface created by Nouveau uses the same name, nv_backlight. This leads to a sysfs warning as it tries to create an already existing folder. This patch adds a incremented number to the name, but keeps the initial name as nv_backlight, to avoid possibly breaking userspace; the second interface will be named nv_backlight1, and so on. Bugzilla:

On Sun, Nov 13, 2016 at 08:57:06PM +0100, Pierre Moreau wrote: > From: Pierre Moreau <pierre.morrow at free.fr> > > Currently, every backlight interface created by Nouveau uses the same name, > nv_backlight. This leads to a sysfs warning as it tries to create an already > existing folder. This patch adds a incremented number to the name, but keeps > the initial name as

On Thu, Aug 04, 2016 at 12:02:23PM +0300, Jani Nikula wrote: > On Tue, 12 Jul 2016, Daniel Vetter <daniel at ffwll.ch> wrote: > > On Thu, Jun 30, 2016 at 12:30:56PM +0100, Chris Wilson wrote: > >> Backlights controlled by i915.ko and only associated with its connectors > >> and also only associated with the intel_drmfb fbcon, controlled by > >> i915.ko. In

The Apple GMUX is the one managing the backlight, so there is no need for Nouveau to register its own backlight interface. v2: Do not split information message on two lines as it prevents from grepping it, as pointed out by Hans de Goede Signed-off-by: Pierre Moreau <pierre.morrow at free.fr> --- drm/nouveau/nouveau_backlight.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git