similar to: APIs affected by btrfs subvolumes

We've currently got a bug in libguestfs which means we can't inspect filesystems in btrfs subvolumes: https://bugzilla.redhat.com/show_bug.cgi?id=824021 This is the default configuration if you select btrfs in F17+. The issue is that it requires an api to fix it, as the return values of inspect_os, inspect_get_filesystems and inspect_get_mountpoints can't express a btrfs

This is the (incomplete) patch which reimplements inspection APIs in the daemon. All ‘XXX’s in this patch indicate areas which are not yet implemented or need further work. Rich.

Add a way to generate OCaml interfaces for a whilelist of modules in the daemon that implement APIs: this makes sure that for them the interface of each function matches the actual API specified in the generator. Only the modules specified in a list are generated for now, although this coverts almost all the daemon APIs implemented in OCaml. --- .gitignore | 15 ++++++++++

Add a way to generate OCaml interfaces for all the modules in the daemon that implement APIs: this makes sure that for them the interface of each function matches the actual API specified in the generator. --- .gitignore | 17 +++++++++++ daemon/blkid.mli | 19 ------------ daemon/btrfs.mli | 20 ------------- daemon/devsparts.mli | 25 ---------------- daemon/file.mli | 19

This is essentially a line-for-line translation of the C inspection code. --- daemon/Makefile.am | 8 + daemon/inspect.ml | 396 +++++++++++++++++++++ daemon/inspect.mli | 41 +++ daemon/inspect_fs.ml | 363 +++++++++++++++++++ daemon/inspect_fs.mli | 23 ++ daemon/inspect_fs_unix.ml | 745

This is essentially a line-for-line translation of the C inspection code. --- daemon/Makefile.am | 8 + daemon/inspect.ml | 396 ++++++++++++++++++++ daemon/inspect.mli | 41 ++ daemon/inspect_fs.ml | 363 ++++++++++++++++++ daemon/inspect_fs.mli | 23 ++ daemon/inspect_fs_unix.ml | 788

These 3 patches implement support for APIs which must accept a mountable, but don't update apis which must return mountables. Matt

Hi, I have a box with / and /home being subvolumes from the same btrfs filesystem. /etc/fstab: UUID=c0686... / btrfs subvol=root,x-systemd.device-timeout=0 1 1 UUID=c0686... /home btrfs subvol=home,x-systemd.device-timeout=0 1 1 ... / is initially mounted readonly by the initramfs, and then after switching to the real system, /home is attempted to be mounted in parallel with /

It seems that the BTRFS_IOC_CLONE ioctl fails when trying to do a cross-subvolume clone of a file. Chris Mason suggested in the past ([1]) that this should be possible. Am I missing something? [1] http://kerneltrap.org/mailarchive/linux-btrfs/2010/6/10/6884911 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to

Hey there! Here are a few patches to fix unrelated things: one fixes the configure for older ncurses releases having no pkg-config files. The other two are fixing what Richard mentioned about guestfs subvolumes display Cédric Bosdonnat (3): configure: handle older version of ncurses api: add mountable_device and mountable_subvolume fish: fix btrfs subvolumes display in error case

Hi there, Latest and greatest version including all new remarks from both Pino and Rich. Cédric Bosdonnat (3): configure: handle older version of ncurses api: add mountable_device and mountable_subvolume fish: fix btrfs subvolumes display in error case fish/options.c | 28 ++++++++++++++++++++++++++- generator/actions.ml | 26 +++++++++++++++++++++++++ m4/guestfs_libraries.m4

Hi all, Here is version 2 of the patch series, including the changes for Pino's remarks. Cédric Bosdonnat (3): configure: handle older version of ncurses api: add mountable_device and mountable_subvolume fish: fix btrfs subvolumes display in error case fish/options.c | 28 ++++++++++++++++++++++++++- generator/actions.ml | 26 +++++++++++++++++++++++++

I'm currently working on gobject bindings for libguestfs. I haven't got as far as compiling anything yet, but I've attached the C header for initial review. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- An embedded and

The current code does not cover all subvolume variants. If a subvolume exists which covers the entire root filesystem the result is two mountables that have is_root set. This leads to failures in virt-ls and other tools because they work only with a single root. Update the btrfs subvolume call to use the "-o" option. This fixes two cases: first it skips the subvolume for the root

New option to subvolume list that acts as a global filter and applies the other filters to either live subvolumes or the uncleaned ones. The path to the deleted subvolumes is lost at the deletion time, sample output looks like: ID 259 gen 7 top level 0 path <FS_TREE>/DELETED Signed-off-by: David Sterba <dsterba@suse.cz> --- btrfs-list.c | 24 +++++++++++++++++++++---

The list of filesystems that is printed when there was an error prints the internal mountable string even for the btrfs subvolumes. Let's printing a valid -m option value instead. --- fish/options.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/fish/options.c b/fish/options.c index da5015d..9222b69 100644 --- a/fish/options.c +++

On Tuesday 01 March 2016 11:17:19 Cédric Bosdonnat wrote: > The list of filesystems that is printed when there was an error prints > the internal mountable string even for the btrfs subvolumes. Let's > printing a valid -m option value instead. > --- > fish/options.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/fish/options.c

Hi BTRFS community I have a problem using btrfs/nfs to store my vmware images. - following setup :(debian wheezy + backports) Linux sncubetest02 3.14-0.bpo.1-amd64 #1 SMP Debian 3.14.12-1~bpo70+1 (2014-07-13) x86_64 GNU/Linux > btrfs --version Btrfs v3.14.1 > btrfs fi show Label: none uuid: 8e37c8d0-e0ef-4857-ae9f-9a1be21901ed Total devices 2 FS bytes used 210.27GiB

On Friday 21 November 2014 13:17:55 Hu Tao wrote: > btrfs_subvolume_create creates only subvolumes. btrfs_subvolume_delete > deletes subvolumes or snapshots. > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> > --- > generator/actions.ml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/generator/actions.ml b/generator/actions.ml

virt-filesystem -l tries to get the size of btrfs subvolumes, which results in an error. Teach it to skip the subvolumes. --- cat/filesystems.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/cat/filesystems.c b/cat/filesystems.c index f1c2852..f679517 100644 --- a/cat/filesystems.c +++ b/cat/filesystems.c @@ -476,9 +476,27 @@ do_output_filesystems