similar to: New comment interfaces

Hi all, I tend to compile my code with all GCC warnings turned on. However, when I do this : vorbis_comment_add_tag(&vdata->vc,"ENCODER","libsndfile"); I get the following warning messages: warning: passing argument 2 of 'vorbis_comment_add_tag' discards qualifiers from pointer target type warning: passing argument 3 of

I was looking over the comment manipulations routines defined in vorbis/codec.h and info.c and I noticed that each "char *" could/should really be defined as "const char*". Is it expected that this will change or was it defined like this for reason? void vorbis_comment_add(vorbis_comment *vc, char *comment); void vorbis_comment_add_tag(vorbis_comment *vc,

I've been working towards a mp3info like tool, OggInfo, which will surplant vorbiscomment in functionality, and also incorportate mp3info like featuers. Looking at existing vorbis api calls, i find: vorbis_comment_add() /* unsupervised string insertion */ vorbis_comment_add_tag() /* formated TAG=text insertion */ vorbis_comment_query() /* scans for matching tag (up to count duplicates) and

Here's a propsed heavy-duty solution for your UTF-8 problems. I'm including a patch in this message, but I'll put the new files on my web site at http://rano.org/tmp/xiph_files.tar.gz I've tested this by running vorbiscomment with and without -DHAVE_ICONV=1 in vorbis-tools/share/Makefile. It seems to work. Changed files: acinclude.m4: Add a test for nl_langinfo(CODESET). This

Hi, after banging my head against the wall for quite a while I finally found what crashes my code: Because I'm working with Codewarrior 8 on OS X I had to compile the ogg / vorbis libs with CW. To do so I used the CW projects for OS 9 and modified them. Howerver, they don't work as expected. Everything seems to be fine, encoding & decoding works, only vorbis_comment_add_tag() crashes

typedef struct vorbis_comment{ /* unlimited user comment fields. libvorbis writes 'libvorbis' whatever vendor is set to in encode */ char **user_comments; int *comment_lengths; int comments; char *vendor; } vorbis_comment; 'user_comments' is the associative array of sorts that the usual comments are. 'vendor' is just a string that's also stored

typedef struct vorbis_comment{ /* unlimited user comment fields. libvorbis writes 'libvorbis' whatever vendor is set to in encode */ char **user_comments; int *comment_lengths; int comments; char *vendor; } vorbis_comment; 'user_comments' is the associative array of sorts that the usual comments are. 'vendor' is just a string that's also stored

Hi Aaron thats interesting, I made a similar change to icecast some time ago myself. It writes ALL metadata to the log, not only ARTIST and TRACK. We wanted to include more information into the playlist of our radio but unfortunately we discovered that oddcast doesn't send more than ARTIST and TRACK... so I am looking for something that sends really everything. What do you use as your

Ok, so I finally got the id3/mp3 end of things worked out for the next release of QTagger and I'm back to implementing tag reading for Ogg Vorbis. I've got some code that will read tags, but I haven't been able to figure out how to write them. Here's the code that I'm using. It's a fine C/C++ mix. The code will eventually be in a C++ app, so I don't mind

I apologize for bugging you all again, but I've been trying to wrap my head around the encoding process and I'm about to have an aneurysm :P I've gone through oggenc.c, encode.c, and audio.c and I think I have a basic idea of what happens. I got it down in pseudocode as follows: --- 1 get parameters 2 init vorbis_comment -- vorbis_comment_init() 3 init vorbis_info --

Dear Vorbis devs, I'm Robert Kausch, author of fre:ac - free audio converter. Please consider using _ogg_malloc/_ogg_free in place of alloca in vorbis_comment_add_tag. alloca will cause undefined behaviour/crashing when it causes a stack overflow which can easily happen when adding cover art in a METADATA_BLOCK_PICTURE comment. I had a user trying to convert a FLAC file with a 2 MB

Hi, I added metadata support for the stdinpcm module of ices. The metadata have to be submitted via file (as stdin is already used for the strem). Please apply this patch to the current cvs sources. <p>Deti <p> Index: im_stdinpcm.c =================================================================== RCS file: /usr/local/cvsroot/ices/src/im_stdinpcm.c,v retrieving revision 1.8 diff

Hi, I am creating a new ogg stream for theatrical/stage/disco lighting and am having trouble encoding my comment header with the following code in _tp_writelsbint function, it does not write the second byte to the ogg buffer. I am using windows and have created a new win32 library project with visual studio and added my code, what do i have to do to get the function working? Is there a project

The theora_unpack_comment casts a pointer-to-int to pointer-to-long. This is incorrect on AMD64, where ints and longs are of different size. On my system (Debian unstable, gcc 4.1) this causes players to crash when they reach the end of a movie. The patch below fixes this bug. --- libtheora-0.0.0.alpha7/lib/toplevel.c 2006-06-13 00:57:36.000000000 +0200 +++ libtheora-pdw/lib/toplevel.c

This patch offers interface to get the library name which software uses. Function: char *vorbis_version_string(void); PATCH (for libvorbis-1.2.1RC2): diff -crN libvorbis-1.2.1RC2/include/vorbis/codec.h libvorbis-1.2.1RC2_NI/include/vorbis/codec.h *** libvorbis-1.2.1RC2/include/vorbis/codec.h Mon Aug 25 05:57:44 2008 --- libvorbis-1.2.1RC2_NI/include/vorbis/codec.h Sat Sep 13 05:00:22 2008

Package: libtheora0 Version: 0.0.0.alpha7-1 Severity: important Tags: patch The theora_unpack_comment casts a pointer-to-int to a pointer-to-long, which breaks badly if ints and longs are different sizes. The attached patch fixes this. -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture:

When a locale is in effect that does not use the point as the decimal mark (e.g., sv_SE or de_DE, which use a comma) and a ReplayGain tag is read for --apply-replaygain-which-is-not-lossless, the gain value was misinterpreted (e.g., "-2.29" truncated to "-2"). This is fixed by resetting the locale to "C" temporarily, based on Josh Coalson's fix of the dual case

Erik de Castro Lopo wrote: > Working on a fix for this and re-visiting some of this realloc() > stuff. I noticed that your patch removes the call to vorbiscomment_entry_array_delete_() in FLAC__metadata_object_vorbiscomment_resize_comments() function, and I think that it reintroduces one place of a potential memory leak: 'object->data.vorbis_comment.comments' is a pointer to an

metaflac --import-vc-from ... used on flac file without vorbis comment destroys the file. This patch fix it. -- Miroslav Lichvar -------------- next part -------------- --- src/metaflac/main.c.orig 2002-09-28 14:45:49.000000000 +0200 +++ src/metaflac/main.c 2002-10-06 23:36:26.000000000 +0200 @@ -1754,20 +1754,24 @@ found_vc_block = true; } while(!found_vc_block &&

Hi, i just joined the list. I was wondering if anyone would be interested in a change to icecast that logs album info as well as ARTST and TRACK. I have made the changes to the source code and it's working fine. If there is any interest, I could look into making it an addition to the code. Let me know. thanks, -- Aaron -------------- next part -------------- An HTML attachment was