similar to: [PATCH] virtio_console: correct error message on failure of debugfs_create_dir

debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error code, but it's always just NULL. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..ad2cd6d 100644 --- a/drivers/char/virtio_console.c +++

debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. Also my static checker doesn't like it when we print the error code, but it's always just NULL. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..ad2cd6d 100644 --- a/drivers/char/virtio_console.c +++

On Friday 19 July 2013, Dan Carpenter wrote: > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > Also my static checker doesn't like it when we print the error code, but > it's always just NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> This looks wrong. debugfs_create_dir intentionally returns non-NULL so failing to create

On Friday 19 July 2013, Dan Carpenter wrote: > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > Also my static checker doesn't like it when we print the error code, but > it's always just NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> This looks wrong. debugfs_create_dir intentionally returns non-NULL so failing to create

On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > The PTR_ERR(NULL) here is not useful. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > v2: completely different > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456fe..4cf46d8 100644 > --- a/drivers/char/virtio_console.c > +++

On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > The PTR_ERR(NULL) here is not useful. > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > --- > v2: completely different > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index 1b456fe..4cf46d8 100644 > --- a/drivers/char/virtio_console.c > +++

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add information so rproc-serial can be easily recogniced from user space. Add the following information to uevent: DRIVER=virtio_console|virtio_rproc_serial INTERFACE=grand-parent/parent/name Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> --- Hi, I need some way to identify the major/minor number for the

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add information so rproc-serial can be easily recogniced from user space. Add the following information to uevent: DRIVER=virtio_console|virtio_rproc_serial INTERFACE=grand-parent/parent/name Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> --- Hi, I need some way to identify the major/minor number for the

On Mon, Jul 29, 2013 at 06:12:31AM -0700, Greg Kroah-Hartman wrote: > On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote: > > On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > > > The PTR_ERR(NULL) here is not useful. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > > --- > > > v2: completely

On Mon, Jul 29, 2013 at 06:12:31AM -0700, Greg Kroah-Hartman wrote: > On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote: > > On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > > > The PTR_ERR(NULL) here is not useful. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > > --- > > > v2: completely

The PTR_ERR(NULL) here is not useful. Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- v2: completely different diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 1b456fe..4cf46d8 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -2215,10 +2215,8 @@ static int __init init(void) } pdrvdata.debugfs_dir =

On Saturday 20 July 2013, Dan Carpenter wrote: > On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: > > On Friday 19 July 2013, Dan Carpenter wrote: > > > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > > > Also my static checker doesn't like it when we print the error code, but > > > it's always just NULL. > >

On Saturday 20 July 2013, Dan Carpenter wrote: > On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote: > > On Friday 19 July 2013, Dan Carpenter wrote: > > > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled. > > > Also my static checker doesn't like it when we print the error code, but > > > it's always just NULL. > >

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Use virtio device index for creating unique device port names. Current index allocation in virtio is based on a monotonically increasing variable "index". A better handling of this is to use device index which is allocated by ida. Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> ---

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Use virtio device index for creating unique device port names. Current index allocation in virtio is based on a monotonically increasing variable "index". A better handling of this is to use device index which is allocated by ida. Signed-off-by: Sjur Br?ndeland <sjur.brandeland at stericsson.com> ---

On Mon, Jul 29, 2013 at 12:41:31PM +0530, Amit Shah wrote: > On (Mon) 22 Jul 2013 [23:41:00], Dan Carpenter wrote: > > The PTR_ERR(NULL) here is not useful. > > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> > > --- > > v2: completely different > > > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c

My static checker complains that this sprintf() can overflow. vdev->index is selected by ida_simple_get() in register_virtio_device() so my reading of the code is that this overflow is theoretically possible. The max value of "id" is configurable and I'm not sure what typical values are. Anyway, it's simple enough to make the buffer larger and I changed it to snprintf() as

My static checker complains that this sprintf() can overflow. vdev->index is selected by ida_simple_get() in register_virtio_device() so my reading of the code is that this overflow is theoretically possible. The max value of "id" is configurable and I'm not sure what typical values are. Anyway, it's simple enough to make the buffer larger and I changed it to snprintf() as

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add a simple serial connection driver called VIRTIO_ID_RPROC_SERIAL (0xB) for communicating with a remote processor in an asymmetric multi-processing configuration. This implementation reuses the existing virtio_console implementation, and adds support for DMA allocation of data buffers and disables use of tty console and the virtio

From: Sjur Br?ndeland <sjur.brandeland at stericsson.com> Add a simple serial connection driver called VIRTIO_ID_RPROC_SERIAL (0xB) for communicating with a remote processor in an asymmetric multi-processing configuration. This implementation reuses the existing virtio_console implementation, and adds support for DMA allocation of data buffers and disables use of tty console and the virtio