similar to: [PATCH] lib: update inspect_list_applications to return all installed RPMs (RHBZ#859885)

Here's a partially implemented fix for RHBZ#859949. Seeing as this is my first libguestfs patch, I'd like some other eyeballs on it to make sure I've not done anything completely crazy. If the rpm case looks ok, I'll update the deb and windows cases if/where applicable.

In particular, read the URL, and both the summary and the description. --- lib/inspect-apps.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/inspect-apps.c b/lib/inspect-apps.c index b7adaa2..c324f3b 100644 --- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -257,6 +257,9 @@ read_rpm_name (guestfs_h *g, #define RPMTAG_RELEASE 1002 #define RPMTAG_EPOCH

The application inspection code assumes the data in the RPM database are encoded in UTF-8. However this is not always the case. As a basic workaround, try to parse the string to UTF-8 and if that fails, try converting it from latin-1. --- inspector/expected-fedora.img.xml | 4 ++++ lib/inspect-apps.c | 30 +++++++++++++++++++++++----

The application inspection code assumes the data in the RPM database are encoded in UTF-8. However this is not always the case. As a basic workaround, try to parse the string to UTF-8 and if that fails, try converting it from latin-1. --- inspector/expected-fedora.img.xml | 4 ++++ lib/inspect-apps.c | 30 +++++++++++++++++++++++----

The application inspection code assumes the data in the RPM database are encoded in UTF-8. However this is not always the case. As a basic workaround, try to parse the string to UTF-8 and if that fails, try converting it from latin-1. --- inspector/expected-fedora.img.xml | 4 ++ lib/inspect-apps.c | 75 +++++++++++++++++++++++++--

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings.

This needs Richard's patch: https://www.redhat.com/archives/libguestfs/2018-February/msg00099.html Diff to v1: * factorized the UTF-8 conversion functions * small style fixes Cédric Bosdonnat (2): common: extract UTF-8 conversion function inspector: rpm summary and description may not be utf-8 common/utils/guestfs-utils.h | 1 + common/utils/libxml2-utils.c

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings. New in v2: incorporated feedback from v1, also added patch #3 which updates the documentation where it references the deprecated API. Take it or leave it.

This way source and summary can be specified for any package read from the guest. --- lib/inspect-apps.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/inspect-apps.c b/lib/inspect-apps.c index 1216c52..eabe565 100644 --- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -51,7 +51,7 @@ static struct guestfs_application2_list *list_applications_deb

Diff to v2: * inlined local_string_to_utf8 Cédric Bosdonnat (2): common: extract UTF-8 conversion function inspector: rpm summary and description may not be utf-8 common/utils/guestfs-utils.h | 11 +++++ common/utils/libxml2-utils.c | 69 +-------------------------- common/utils/utils.c | 64 +++++++++++++++++++++++++

This way source and summary can be specified for any package read from the guest. --- lib/inspect-apps.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/inspect-apps.c b/lib/inspect-apps.c index 1216c52..eabe565 100644 --- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -51,7 +51,7 @@ static struct guestfs_application2_list *list_applications_deb

I've got a Powercom Imperial UPS, with an internal USB<=>serial converter. It implements the same protocol as other powercom devices implements, but only when talking over serial port (there's no such port on the device). Someone wrote a draft version of usbserial driver for it, and the UPS works with this kernel-level driver and with powercom driver from nut (using /dev/ttyUSBx

Hi, I am using kernel 3.7-rc6. I have written a test application for extended attributes and have for some folders a wired behaviour: #include <stdio.h> #include <string.h> #include <attr/xattr.h> char attrs[1024]; ssize_t attrslen; int i; char value[1024]; ssize_t valuelen; int main(int argc, char *argv[]) { if (argc != 2) { fprintf(stderr, "Syntax: testxattr

=20 This is an implementation of the key/value pair (KVP) functionality=20 for Linux guests hosted on HyperV. All guest specific data gathering = for=20 KVP will be implemented in a user-level daemon. This kernel component = packaged as part of the hv_utils driver supports communication with the HyperV=20 host.=20 Signed-off-by: ksrinivasan <ksrinivasan at novell.com> ---

=20 This is an implementation of the key/value pair (KVP) functionality=20 for Linux guests hosted on HyperV. All guest specific data gathering = for=20 KVP will be implemented in a user-level daemon. This kernel component = packaged as part of the hv_utils driver supports communication with the HyperV=20 host.=20 Signed-off-by: ksrinivasan <ksrinivasan at novell.com> ---

This is an implementation of the key value/pair (KVP) functionality for Linux guests hosted on HyperV. This component communicates with the host to support the KVP functionality. Signed-off-by: K. Y. Srinivasan <ksrinivasan at novell.com> --- drivers/staging/hv/Makefile | 2 +- drivers/staging/hv/channel_mgmt.c | 23 +++- drivers/staging/hv/hv_kvp.c | 346

This is an implementation of the key value/pair (KVP) functionality for Linux guests hosted on HyperV. This component communicates with the host to support the KVP functionality. Signed-off-by: K. Y. Srinivasan <ksrinivasan at novell.com> --- drivers/staging/hv/Makefile | 2 +- drivers/staging/hv/channel_mgmt.c | 23 +++- drivers/staging/hv/hv_kvp.c | 346

On 08/14/2016 10:13 AM, Nicolas Kovacs wrote: > Le 14/08/2016 ? 11:33, Nicolas Kovacs a ?crit : >> 1. When I edit gnome-terminal.desktop and define "Categories=System;", >> it won't appear in "Outils syst?mes" as expected but remains in >> "Utilitaires". >> >> 2. I have a category "Divers" (something like

On Sun, 2015-05-24 at 19:58 +0200, Tobias Klausmann wrote: > Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de> > --- > src/glsl/ast_to_hir.cpp | 14 +++++ > src/glsl/builtin_variables.cpp | 13 +++- > src/glsl/glcpp/glcpp-parse.y | 3 + > src/glsl/glsl_parser_extras.cpp | 1 + > src/glsl/glsl_parser_extras.h

v1 -> v2: - Remove the unnecessary calls to guestfs_int_lazy_make_tmpdir in the final patch. Rich.