similar to: [PATCH v2] inspection: Fix calls to case_sensitive_path (RHBZ#858126).

Proposed patches to fix https://bugzilla.redhat.com/show_bug.cgi?id=858126

This change refactors guestfs___has_windows_systemroot to guestfs___get_windows_systemroot. The new function returns a dynamically allocated char * which must be freed. The new function is no less efficient than before, as it returns the result of guestfs___case_sensitive_path_silently, which is required anyway. The new code is slightly more efficient than before, as it re-uses the result of this

GCC has two warnings related to large stack frames. We were already using the -Wframe-larger-than warning, but this reduces the threshold from 10000 to 5000 bytes. However that warning only covers the static part of frames (not alloca). So this change also enables -Wstack-usage=10000 which covers both the static and dynamic usage (alloca and variable length arrays). Multiple changes are made

This patch series changes a small part of the library to use __attribute__((cleanup(...))) to automatically free memory when pointers go out of the current scope. In general terms this seems to be a small win although you do have to use it carefully. For functions where you can completely get rid of the "exit code paths", it can simplify things. For a good example, see the

One more after this, and "make syntax-check" will pass once more. >From 5c360133c0d4e09531d432abca0629798b87ff39 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 9 Nov 2009 15:14:53 +0100 Subject: [PATCH libguestfs] indent with spaces, not TABs * HACKING: Expand indentation TABs. * configure.ac: Likewise. * daemon/daemon.h: Likewise. *

--- generator/actions.ml | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/generator/actions.ml b/generator/actions.ml index c73a319..cb6d137 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -7150,13 +7150,32 @@ a problem. Bug or feature? You decide: L<http://www.tuxera.com/community/ntfs-3g-faq/#posixfilenames1> -This

This adds most of the hivex APIs directly to the libguestfs API, so that you can read and write Windows Registry hive files from libguestfs without needing to download and upload hive files from the guest. This is analogous to how Augeas APIs are exposed already (guestfs_aug_*) Also, inspection is now done using the new APIs, which fixes the following bug:

A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights: - Add a new mllib Registry module containing various utility functions that are currently scattered all around. - Only compute the software/system hive paths once during inspection, and

Support arbitrary windows system root for pre-vista systems where boot.ini is on the same partition as the system root. --- src/inspect-fs-windows.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 86 insertions(+) diff --git a/src/inspect-fs-windows.c b/src/inspect-fs-windows.c index 8ddea95..61b2f3b 100644 --- a/src/inspect-fs-windows.c +++ b/src/inspect-fs-windows.c @@

Dear All, I manage a Debian Squeeze GNU/Linux (with kernel 2.6.32-5-686 #1 SMP) with Samba 3.5.6 (samba 2:3.5.6~dfsg-3squeeze8 package is installed). I have a "test" directory with native Linux ACL permissions. getfacl test's output: # file: test # owner: akos # group: grp # flags: -s- user::rwx group::rwx group:read:r-x mask::rwx other::--- default:user::rwx default:group::rwx

--- generator/actions.ml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/generator/actions.ml b/generator/actions.ml index c73a319..32758b1 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -7161,6 +7161,9 @@ created under Windows). I<Note>: This function does not handle drive names, backslashes etc. +C<guestfs_case_sensitive_path> will return an error if

Hello Eric, I am taking Buck and the rsync mailing list into the CC. Buck is the author of the rsync patch, he may know more on that problem. On Wednesday 02 April 2003 00:16, Eric Chen wrote: > From my understanding, the effecive rights mask 'limits the effective > rights granted to all groups and to named users', so if you getfacl on a > file, the group permissions will be

I need to be sure that Wine will be able to run some of my XP applications before I commit to linux, so I installed Lucid Puppy 525 ( a cut down version of Lucid) and Wine - the default install version is set to v1.1.43, so that wasted a lot of time. I then installed Wine v1.3.13 , since the stable v1.2 wasn't on offer. I'm going to need Java Runtime Environment, so I started by

Fix a bogus warning introduced by 5abb196de869cd27a6fa2377d79b9a267120f48e. If a non-windows partition hasn't been detected as something else and falls through to windows detection, inspection would display a bogus warning about missing /boot.ini. --- src/inspect-fs-windows.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/inspect-fs-windows.c

I am seeing an odd behavior with NT4.0 SP3 workstations trying to rename files on Samba 1.9.18p2 shares on SunOS 4.1.3 servers. Rename, whether it is run from Explorer, winfile.exe, or command prompt fails with "Access Denied I don't see the problem from Win95 PCs at all, and I don't have the problem with shares from Samba 1.9.18p2 shares on Solaris 2.5.1 servers using identical

Various changes/fixes to use smaller stack frames. Rich.

HI, All. I face problems when try to use libguestfs in new ubuntu 11.10. 1) My current version of libguest (1.12.0, binaries taken from libguestfs site) can't boot vm with new kernel. You can find log of libguest-test-tool in attachment. I try force it to boot 2.6.38-11 kernel instead of 3.0.0-12 (which is default), but get the same result (error) 2) I can't compile libguestfs from

Map the HIVEX_OPEN_UNSAFE flag into the libguestfs API and use it in various places. Rich.

The first three patches were posted previously: https://www.redhat.com/archives/libguestfs/2010-July/msg00082.html The last two patches in this series change guestfish -i to use this new code. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to

These three patches (two were previously posted) can do simple operating system inspection in C. Example of use: ><fs> add-ro rhel55.img ><fs> run ><fs> inspect-os /dev/VolGroup00/LogVol00 ><fs> inspect-get-type /dev/VolGroup00/LogVol00 linux ><fs> inspect-get-distro /dev/VolGroup00/LogVol00 rhel ><fs> inspect-get-arch