similar to: [PATCH 0/2] Fix calls to case_sensitive_path.

From: "Richard W.M. Jones" <rjones at redhat.com> Don't assume that if guestfs_case_sensitive_path returns NULL, that it means the file does not exist. The (previously undefined) behaviour of case_sensitive_path was that a NULL return meant "either the file doesn't exist or some other error". However in commit 973581780d8a006f336684fef6762801402d775d this was

This patch series changes a small part of the library to use __attribute__((cleanup(...))) to automatically free memory when pointers go out of the current scope. In general terms this seems to be a small win although you do have to use it carefully. For functions where you can completely get rid of the "exit code paths", it can simplify things. For a good example, see the

A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights: - Add a new mllib Registry module containing various utility functions that are currently scattered all around. - Only compute the software/system hive paths once during inspection, and

Various changes/fixes to use smaller stack frames. Rich.

The first three patches were posted previously: https://www.redhat.com/archives/libguestfs/2010-July/msg00082.html The last two patches in this series change guestfish -i to use this new code. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to

This adds most of the hivex APIs directly to the libguestfs API, so that you can read and write Windows Registry hive files from libguestfs without needing to download and upload hive files from the guest. This is analogous to how Augeas APIs are exposed already (guestfs_aug_*) Also, inspection is now done using the new APIs, which fixes the following bug:

These three patches (two were previously posted) can do simple operating system inspection in C. Example of use: ><fs> add-ro rhel55.img ><fs> run ><fs> inspect-os /dev/VolGroup00/LogVol00 ><fs> inspect-get-type /dev/VolGroup00/LogVol00 linux ><fs> inspect-get-distro /dev/VolGroup00/LogVol00 rhel ><fs> inspect-get-arch

Previously discussed here: https://www.redhat.com/archives/libguestfs/2010-August/msg00002.html -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/

This change refactors guestfs___has_windows_systemroot to guestfs___get_windows_systemroot. The new function returns a dynamically allocated char * which must be freed. The new function is no less efficient than before, as it returns the result of guestfs___case_sensitive_path_silently, which is required anyway. The new code is slightly more efficient than before, as it re-uses the result of this

Map the HIVEX_OPEN_UNSAFE flag into the libguestfs API and use it in various places. Rich.

As described here previously: https://www.redhat.com/archives/libguestfs/2010-March/msg00129.html Here is the three part patch to reimplement virt-win-reg to support exporting and merging Windows Registry entries in the 'regedit' format. Tested by me on a local Windows VM. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top'

The following patches address issues when dealing with hives that have corrupted data in them but are otherwise readable/writable. Those were found on some rather rare Windows installations that seem to work fine but current hivex fails to even open. Those patches change hivex to simply log and ignore such "corrupted" regions instead of aborting because the caller might be looking at

GCC has two warnings related to large stack frames. We were already using the -Wframe-larger-than warning, but this reduces the threshold from 10000 to 5000 bytes. However that warning only covers the static part of frames (not alloca). So this change also enables -Wstack-usage=10000 which covers both the static and dynamic usage (alloca and variable length arrays). Multiple changes are made

From: "Richard W.M. Jones" <rjones@redhat.com> Use the macro like this to create temporary variables which are automatically cleaned up when the scope is exited: { CLEANUP_FREE (char *, foo, strdup (bar)); /* char *foo = strdup (bar) */ ... // no need to call free (foo)! } On GCC and LLVM, this is implemented using __attribute__((cleanup(...))). On other

I am having consistent difficulty with write access and installing applications. The errors show up as write protect errors or not enough disk space errors. 'winefile' shows the disks as being NTFS. Is this correct or is it a winefile anomaly? Are these conditions related? What is the correct file system type? How can this be managed? 'winecfg' does not seem to allow

Dear All, I manage a Debian Squeeze GNU/Linux (with kernel 2.6.32-5-686 #1 SMP) with Samba 3.5.6 (samba 2:3.5.6~dfsg-3squeeze8 package is installed). I have a "test" directory with native Linux ACL permissions. getfacl test's output: # file: test # owner: akos # group: grp # flags: -s- user::rwx group::rwx group:read:r-x mask::rwx other::--- default:user::rwx default:group::rwx

The current location doesn't exist unless you've installed GNOME, which is not so common on Ubuntu. Unfortunately I couldn't find any other location containing a clean, high quality logo. This adds another low quality icon source, and also prevents any icon being returned if the highquality flag was set (note this prevents virt-manager from displaying an icon, but there's nothing

Fix a bogus warning introduced by 5abb196de869cd27a6fa2377d79b9a267120f48e. If a non-windows partition hasn't been detected as something else and falls through to windows detection, inspection would display a bogus warning about missing /boot.ini. --- src/inspect-fs-windows.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/inspect-fs-windows.c

I am seeing an odd behavior with NT4.0 SP3 workstations trying to rename files on Samba 1.9.18p2 shares on SunOS 4.1.3 servers. Rename, whether it is run from Explorer, winfile.exe, or command prompt fails with "Access Denied I don't see the problem from Win95 PCs at all, and I don't have the problem with shares from Samba 1.9.18p2 shares on Solaris 2.5.1 servers using identical

HI, All. I face problems when try to use libguestfs in new ubuntu 11.10. 1) My current version of libguest (1.12.0, binaries taken from libguestfs site) can't boot vm with new kernel. You can find log of libguest-test-tool in attachment. I try force it to boot 2.6.38-11 kernel instead of 3.0.0-12 (which is default), but get the same result (error) 2) I can't compile libguestfs from