similar to: [PATCH] sysprep: remove apache2, audit and ntp in logfile operation

Remove the logfiles configured by /etc/logrotate.d/*. Omit the logfile of "samba" and "sssd" which we removed them separately . Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- sysprep/sysprep_operation_logfiles.ml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/sysprep/sysprep_operation_logfiles.ml

Remove the cache files generated by fontconfig. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- sysprep/sysprep_operation_logfiles.ml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sysprep/sysprep_operation_logfiles.ml b/sysprep/sysprep_operation_logfiles.ml index a2b1585..1bca0dd 100644 --- a/sysprep/sysprep_operation_logfiles.ml +++

audit.log is already included in /var/log/audit/*. Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> --- sysprep/sysprep_operation_logfiles.ml | 1 - 1 file changed, 1 deletion(-) diff --git a/sysprep/sysprep_operation_logfiles.ml b/sysprep/sysprep_operation_logfiles.ml index 842b855..cdfe8fc 100644 --- a/sysprep/sysprep_operation_logfiles.ml +++

--- sysprep/sysprep_operation_logfiles.ml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sysprep/sysprep_operation_logfiles.ml b/sysprep/sysprep_operation_logfiles.ml index 8994af9..3055ca4 100644 --- a/sysprep/sysprep_operation_logfiles.ml +++ b/sysprep/sysprep_operation_logfiles.ml @@ -41,6 +41,7 @@ let globs = List.sort compare [ "/var/log/apache2/*_log";

We just remove the process accounting files previously without touch a empty file, this will cause psacct runs error. Restart the service can't help us create this file auto. couldn't open file '/var/account/pacct': No such file or directory Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- po/POTFILES-ml | 1 + sysprep/Makefile.am

Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> --- sysprep/sysprep_operation_logfiles.ml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sysprep/sysprep_operation_logfiles.ml b/sysprep/sysprep_operation_logfiles.ml index a8b24f1..8994af9 100644 --- a/sysprep/sysprep_operation_logfiles.ml +++ b/sysprep/sysprep_operation_logfiles.ml @@ -85,6 +85,9 @@ let globs = List.sort

--- sysprep/sysprep_operation_logfiles.ml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sysprep/sysprep_operation_logfiles.ml b/sysprep/sysprep_operation_logfiles.ml index 3055ca4..2558af1 100644 --- a/sysprep/sysprep_operation_logfiles.ml +++ b/sysprep/sysprep_operation_logfiles.ml @@ -91,6 +91,13 @@ let globs = List.sort compare [ (* log file of ntp *)

On Wed, Feb 03, 2016 at 07:28:16PM +0100, Pino Toscano wrote: > Help the OCaml compiler by expliciting Guestfs.guestfs as type for 'g' > in some functions. Looks mechanical, ACK. Does Hindley-Milner type inference have problems here? I've not seen them in this case. Rich. > get-kernel/get_kernel.ml | 2 +- >

Hi Rich, I tried to implement the logging feature, but I can't though compiling with this patch now, could you please give me some comments? The error message is below, --- ocamlfind ocamlopt -g -warn-error CDEFLMPSUVYZX -package unix -I ../src/.libs -I ../ocaml -c sysprep_operation.ml -o sysprep_operation.cmx File "sysprep_operation.ml", line 1, characters 0-1: Error: The

Help the OCaml compiler by expliciting Guestfs.guestfs as type for 'g' in some functions. --- get-kernel/get_kernel.ml | 2 +- sysprep/sysprep_operation_abrt_data.ml | 2 +- sysprep/sysprep_operation_bash_history.ml | 2 +- sysprep/sysprep_operation_ca_certificates.ml | 2 +- sysprep/sysprep_operation_crash_data.ml

Remove hostname from network interface configuration. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- po/POTFILES-ml | 1 + sysprep/Makefile.am | 1 + sysprep/sysprep_operation_net_hostname.ml | 58 +++++++++++++++++++++++++++++++ 3 files changed, 60 insertions(+) create mode 100644 sysprep/sysprep_operation_net_hostname.ml

Remove the cache of package manager like yum and apt. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- sysprep/Makefile.am | 2 + sysprep/sysprep_operation_package_manager_cache.ml | 49 ++++++++++++++++++++ 2 files changed, 51 insertions(+) create mode 100644 sysprep/sysprep_operation_package_manager_cache.ml diff --git

Remove the generated kerberos data in the guest. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- sysprep/Makefile.am | 2 ++ sysprep/sysprep_operation_kerberos_data.ml | 52 ++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 sysprep/sysprep_operation_kerberos_data.ml diff --git a/sysprep/Makefile.am

Flag the system for reconfiguration by touching /.unconfigured . Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- TODO | 2 - sysprep/Makefile.am | 2 + sysprep/sysprep_operation_flag_reconfiguration.ml | 42 +++++++++++++++++++++ 3 files changed, 44 insertions(+), 2 deletions(-) create mode

remove the automatically generated abrt data. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- po/POTFILES-ml | 1 + sysprep/Makefile.am | 2 ++ sysprep/sysprep_operation_abrt_data.ml | 47 ++++++++++++++++++++++++++++++++++ 3 files changed, 50 insertions(+) create mode 100644 sysprep/sysprep_operation_abrt_data.ml diff --git

cron-spool claims to remove at jobs, but it has no code to actually do that. Add patterns to remove files in known at spool locations. Signed-off-by: Olaf Hering <olaf at aepfle.de> --- This patch is only compile tested! sysprep/sysprep_operation_cron_spool.ml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sysprep/sysprep_operation_cron_spool.ml

SuSE based installations store the hostname in /etc/HOSTNAME. Add code to handle both opensuse and sles. Code to properly detect the latter will be added with another patch. Signed-off-by: Olaf Hering <olaf at aepfle.de> diff --git a/sysprep/sysprep_operation_hostname.ml b/sysprep/sysprep_operation_hostname.ml index 3fc8800..363069b 100644 --- a/sysprep/sysprep_operation_hostname.ml +++

Currently firstboot would only work on redhat-based images. Handle redhat-based, suse-based and debian guests, error out in case of an unknown distro. Update firstboot.sh: - make sure scripts exists and can be executed - add LSB header to avoid insserv warnings later on - run script only if called with "start" Update functions, pass only required options. Signed-off-by: Olaf Hering

Remove editor backup files such as *~ and *.bak wherever they occur within the guest filesystem. This also includes a test. --- sysprep/Makefile.am | 2 + sysprep/sysprep_operation_backup_files.ml | 98 +++++++++++++++++++++++++++++++ sysprep/test-virt-sysprep-backup-files.sh | 64 ++++++++++++++++++++ 3 files changed, 164 insertions(+) create mode 100644

On Wednesday, 14 December 2016 13:12:01 CET Richard W.M. Jones wrote: > Remove editor backup files such as *~ and *.bak wherever > they occur within the guest filesystem. > > This also includes a test. > --- Looks nice -- I have few notes below. Also, should this operation include also the swap files that editors can leave while editing? > + let fses = > + match