similar to: Remaining syntax-check errors in libguestfs

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- align/Makefile.am | 2 +- builder/Makefile.am | 2 +- builder/website/Makefile.am | 2 +- cat/Makefile.am | 4 ++-- common-rules.mk | 8 ++++---- customize/Makefile.am | 2 +- df/Makefile.am | 4 ++-- diff/Makefile.am | 2 +-

Hi, This series updates to the latest gnulib, after making most of its "make syntax-check" tests pass. There are still a few tests (listed in cfg.mk) that are simply skipped. To enable one, just remove its test name from the list of tests to skip and run "make syntax-check". [PATCH hivex 01/14] maint: add cfg.mk to prepare for syntax-check [PATCH hivex 02/14] maint: remove

--- cat/Makefile.am | 6 +++--- df/Makefile.am | 2 +- edit/Makefile.am | 2 +- examples/Makefile.am | 12 ++++++------ fish/Makefile.am | 18 +++++++++--------- fuse/Makefile.am | 2 +- inspector/Makefile.am | 2 +- java/examples/Makefile.am | 6 +++--- ocaml/examples/Makefile.am | 6 +++---

I've pushed 10 commits which just clean up errors found by 'make syntax-check'. The remaining syntax-check errors are attached below. I think many of them are false alarms. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages.

As discussed at: https://www.redhat.com/archives/libguestfs/2014-September/msg00215.html Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- maint.mk | 7 ------- 1 file changed, 7 deletions(-) diff --git a/maint.mk b/maint.mk index b6ec1b5..76759d4 100644 --- a/maint.mk +++ b/maint.mk @@ -408,13 +408,6 @@ sc_error_message_uppercase: { echo '$(ME): found capitalized error

> -----Original Message----- > From: Richard W.M. Jones [mailto:rjones@redhat.com] > Sent: Thursday, March 12, 2015 4:32 PM > To: Chen, Hanxiao/陈 晗霄 > Cc: libguestfs@redhat.com > Subject: Re: [Libguestfs] [PATCH] maint.mk: remove error_message_period check > > On Wed, Mar 11, 2015 at 01:18:45AM -0400, Chen Hanxiao wrote: > > As discussed at: > >

Move most of the content of either po-docs/ja/Makefile.am or po-docs/uk/Makefile.am to po-docs/language.mk, and use it exclusively instead of the former contents of the languange-specific Makefile.am. This way, either adding a new documentation or enabling a new language will not require copying over the same make code. --- po-docs/ja/Makefile.am | 174 +-------------------------------------------

Hi Rich, I noticed that libguestfs's cfg.mk had an old (and relatively inefficient) version of the rule that checks for empty lines at EOF. The one in maint.mk is much more efficient: >From cf93f04a980ec01ef37db9a0d4c7b99015169eee Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 17 Sep 2012 11:49:34 +0200 Subject: [PATCH libguestfs] maint: remove a

The API for UNIX sockets limits the path to a static size (usually 104 or 108 characters, NULL included), which is internally represented as UNIX_PATH_MAX. If the temporary directory set is long enough (e.g. when running tools as uninstalled, using "run") then these socket paths get trucated, if not even cause failures when binding the sockets. Introduce a new internal API to create

Introduce a new read-only API to get a path where to store temporary sockets: this is different from tmpdir, as we need short paths for sockets (due to sockaddr_un::sun_path), and it is either XDG_RUNTIME_DIR if set, or /tmp; adapt guestfs_int_create_socketname to create sockets in that location. Furthermore, print sockdir and XDG_RUNTIME_DIR in test-tool for debugging. --- fish/guestfish.pod

By adding common CLEANFILES and DISTCLEANFILES variables to common-rules.mk, we can remove these from most other Makefiles, and also clean files more consistently. Note that bin_PROGRAMS are already cleaned by 'make clean', so I removed cases where these were unnecessarily added to CLEANFILES. --- .gitignore | 1 + Makefile.am | 6

On Fri, Jan 29, 2016 at 07:25:30PM +0100, Pino Toscano wrote: > The API for UNIX sockets limits the path to a static size (usually 104 > or 108 characters, NULL included), which is internally represented as > UNIX_PATH_MAX. If the temporary directory set is long enough (e.g. > when running tools as uninstalled, using "run") then these socket paths > get trucated, if not

Introduce a new read-only API to get a path where to store temporary sockets: this is different than tmpdir, as we need short paths for sockets (due to sockaddr_un::sun_path), and is either XDG_RUNTIME_DIR if set, or /tmp. Adapt guestfs_int_create_socketname to create sockets in that location, checking whether the resulting path still fits in the limited buffer. Furthermore, print sockdir and

From: "Richard W.M. Jones" <rjones at redhat.com> This commit models libvirt authentication events through the API, adding one new event (GUESTFS_EVENT_LIBVIRT_AUTH) and several new APIs: guestfs_set_libvirt_supported_credentials guestfs_get_libvirt_requested_credentials guestfs_get_libvirt_requested_credential_prompt guestfs_get_libvirt_requested_credential_challenge

Hi Rich, This series includes patches to make `make syntax-check` pass. Some of the fix require change to maint.mk, but the file is not in git repo. Is it intended? Thanks! Hu Tao (13): syntax-check: dirty hack to pass bindtextdomain check syntax-check: fix error_message_period check syntax-check: fix makefile_at_at_check syntax-check: fix prohibit_assert_without_use check

Here's a patch series to make libguestfs use gnulib via a git submodule. The first thing I did was to look at the failures from "make syntax-check" and fix the config.h-related ones below. The others are now temporarily disabled via a variable in cfg.mk. I fixed the config-h problems and moved those change sets to precede the test-adding one, so that bisection still works, even if

I ran libguestfs through llvm+clang, today, [http://clang.llvm.org/StaticAnalysis.html] It found only two things worth changing -- neither is a real problems. Adding the noreturn makes it so the tool understands line 541 of guestfs.c is truly reachable only for non-NULL "p": 540 if (!p) g->abort_cb (); 541 memcpy (p, ptr, size); >From

Introduce an internal helper to create paths for sockets -- will be useful for changing later the logic for placing sockets. Futhermore, check that the length of sockets won't overflow the buffer for their filenames. --- src/guestfs-internal.h | 1 + src/launch-direct.c | 4 +++- src/launch-libvirt.c | 10 ++++++---- src/launch.c | 17 +++++++++++++++++ 4 files changed, 27

Hi Rich, I ran this command to spot a few typos: git ls-files|misspellings -f -|grep -v '^po' Here are fixes: >From ec62fad96cc2884c8fd43ecb550a8bcac317cca0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Wed, 18 Apr 2012 11:15:57 +0200 Subject: [PATCH libguestfs] maint: fix doc typos Fix typos spotted by http://github.com/lyda/misspell-check. *

On Thu, Jan 17, Richard W.M. Jones wrote: > On Wed, Jan 16, 2013 at 05:51:53PM +0100, Olaf Hering wrote: > > On Mon, Jan 14, Olaf Hering wrote: > > > This is a first attempt to build libguestfs with just a ocaml bytecode > > > compiler. The three tools written in ocaml will be build only when an > > > ocamlopt compiler is available. > > Here is a more