similar to: [PATCH node] Use vg uuid when detecting whether vg spans multiple disks

This only affects non-HostVG volume groups. rhbz#733578 Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/storage.py | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/scripts/storage.py b/scripts/storage.py index 5f7f0e3..047bcd1 100644 --- a/scripts/storage.py +++ b/scripts/storage.py @@ -90,13 +90,19 @@ class Storage: vg =

This patch introduces the concept of an "Advanced Storage Configuration", specifically for automated installs (although it could be hooked into manual install), while preserving the original style of specifying LVs. It accomplishes the following: * Add an optional AppVG * Offer new optional LVs - Data2,Swap2 - as part of the new AppVG * Allows the specification of multiple disks, per VG

Quote everywhere that we reference wwid in o-c-storage, o-c-boot and ovirt-functions. Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/ovirt-config-boot | 6 +- scripts/ovirt-config-storage | 178 +++++++++++++++++++++--------------------- scripts/ovirt-functions | 38 +++++----- 3 files changed, 111 insertions(+), 111 deletions(-) diff --git

--- scripts/ovirt-config-boot | 13 +++++- scripts/ovirt-config-storage | 111 ++++++++++++++++++++++++------------------ 2 files changed, 75 insertions(+), 49 deletions(-) diff --git a/scripts/ovirt-config-boot b/scripts/ovirt-config-boot index d545878..8cc127b 100755 --- a/scripts/ovirt-config-boot +++ b/scripts/ovirt-config-boot @@ -29,6 +29,12 @@ ovirt_boot_setup() { local disk2

Putting these out for feedback and comments. These will eventually support the new newt/python based ui for installation/configuration storage.py functions will be moved under a class for better data portability before final version --- scripts/ovirtfunctions.py | 672 +++++++++++++++++++++++++++++++++++++++++++++ scripts/storage.py | 451 ++++++++++++++++++++++++++++++ 2 files

This adds the ability to select 2 different disks for root and HostVG. ovirt_init kernel arg still works as intended but does not support multiple arguments, this will be added in next --- scripts/ovirt-config-storage | 150 ++++++++++++++++++++++++++---------------- 1 files changed, 94 insertions(+), 56 deletions(-) diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage index

The appliance has no LVM system ID set, which means that lvm commands will ignore VGs with a system ID set to anything. Since we want to work with them, pass --foreign at least when listing them to see them. See also lvmsystemid(7). --- daemon/lvm.c | 10 ++++++---- generator/daemon.ml | 1 + 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/daemon/lvm.c b/daemon/lvm.c

rhbz#736971 Signed-off-by: Mike Burns <mburns at redhat.com> --- dracut/ovirt-cleanup.sh | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/dracut/ovirt-cleanup.sh b/dracut/ovirt-cleanup.sh index c96d6fe..e9674d8 100755 --- a/dracut/ovirt-cleanup.sh +++ b/dracut/ovirt-cleanup.sh @@ -48,11 +48,16 @@ fi # Check for HostVG lvm pvscan >/dev/null

Used in conjunction with livecd-iso-to-iscsi. Creates a local boot partition with vmlinuz/initrd and grub configuration. Disk Partitioning > enable iscsi target > configure storage > local install and reboot --- scripts/ovirt-config-boot | 131 +++++++++++++++++++-------------- scripts/ovirt-config-storage | 164 +++++++++++++++++++++++++----------------- tools/livecd-iso-to-iscsi

--- scripts/uninstall.py | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 75 insertions(+), 0 deletions(-) create mode 100755 scripts/uninstall.py diff --git a/scripts/uninstall.py b/scripts/uninstall.py new file mode 100755 index 0000000..9e0baff --- /dev/null +++ b/scripts/uninstall.py @@ -0,0 +1,75 @@ +#!/usr/bin/python +# +# uninstall.py - destroys an installed

Signed-off-by: Mike Burns <mburns at redhat.com> --- dracut/ovirt-cleanup.sh | 15 ++++++++++++--- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/dracut/ovirt-cleanup.sh b/dracut/ovirt-cleanup.sh index a6762cf..f800bf2 100755 --- a/dracut/ovirt-cleanup.sh +++ b/dracut/ovirt-cleanup.sh @@ -20,24 +20,29 @@ elif getarg reinstall >/dev/null; then elif getarg uninstall

rhbz#733274 Signed-off-by: Mike Burns <mburns at redhat.com> --- dracut/install | 1 + dracut/ovirt-cleanup.sh | 14 +++++++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/dracut/install b/dracut/install index 1832b89..000272a 100755 --- a/dracut/install +++ b/dracut/install @@ -2,6 +2,7 @@ inst yes inst head +inst awk inst_hook pre-pivot 01

Previous implementation had staticly defined partitions to remove. This would break in the case of split Root and HostVG devices. Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/ovirt-config-boot | 11 +-------- scripts/ovirt-config-uninstall | 48 ++++++++++++++++++++++++--------------- scripts/ovirt-functions | 33 +++++++++++++++++++++++++++ 3 files

Previous implementation had staticly defined partitions to remove. This would break in the case of split Root and HostVG devices. Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/ovirt-config-boot | 11 +-------- scripts/ovirt-config-uninstall | 49 ++++++++++++++++++++++++--------------- scripts/ovirt-functions | 27 ++++++++++++++++++++++ 3 files changed, 58

lvm2 2.02.107 adds the -S/--select option used in lvs to filter out only public LVs (see RHBZ#1278878). To make this work again with versions of lvm2 older than that, only on old versions filter out thin layouts and compose the resulting device strings ourselves. The filtering done is much simplier than what "-S lv_role=public" will do, but should be good enough for our need. ---

--- daemon/Makefile.am | 2 + daemon/lvm.c | 151 ---------------------------------------------- daemon/lvm.ml | 92 ++++++++++++++++++++++++++++ daemon/lvm.mli | 19 ++++++ generator/actions_core.ml | 1 + 5 files changed, 114 insertions(+), 151 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 22a3036f8..e9c71ba3c 100644

lvm2 2.02.107 adds the -S/--select option used in lvs to filter out only public LVs (see RHBZ#1278878). To make this work again with versions of lvm2 older than that, only on old versions filter out thin layouts and compose the resulting device strings ourselves. The filtering done is much simplier than what "-S lv_role=public" will do, but should be good enough for our need. ---

From: "Richard W.M. Jones" <rjones at redhat.com> Callers are supposed to use the availability API to check for functions that may not be available in particular builds of libguestfs. If they don't do this, currently they tend to get obscure error messages, eg: libguestfs: error: zerofree: /dev/vda1: zerofree: No such file or directory This commit changes the error

When a disk image uses LVM thinp (thin provisioning), the guestfs_lvs API would return the thinp pools. This confused other APIs because thinp pools don't have corresponding /dev/VG/LV device nodes. Filter the LVs that are returned using "lv_role=public". Thanks: Fabian Deutsch --- daemon/lvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/daemon/lvm.c

This hook script tries to address the fact that a RHEV-H installation will format all the storage devices available in the machine in order to create HostVG and AppVG with all the available space. It may be the case that RHEV-H needs to respect and co-exist with a proposed partitioning scheme, not getting all the storage space for HostVG and AppVG volume groups. The proposed solution adds the