similar to: [PATCH node] cleanup a couple small issues

Quote everywhere that we reference wwid in o-c-storage, o-c-boot and ovirt-functions. Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/ovirt-config-boot | 6 +- scripts/ovirt-config-storage | 178 +++++++++++++++++++++--------------------- scripts/ovirt-functions | 38 +++++----- 3 files changed, 111 insertions(+), 111 deletions(-) diff --git

This set of patches introduces support for multipath devices for storage. Comments and suggestions are appreciated. Mike

Cleanup the translations of /dev/sdX to /dev/mapper and vice-versa. Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/ovirt-config-storage | 59 +++++++++++++++++++++++++---------------- scripts/ovirt-functions | 22 +++++++++++++++ 2 files changed, 58 insertions(+), 23 deletions(-) diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage index

Cleanup the translations of /dev/sdX to /dev/mapper and vice-versa. Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/ovirt-config-storage | 24 +++++++++++++++--------- scripts/ovirt-functions | 22 ++++++++++++++++++++++ 2 files changed, 37 insertions(+), 9 deletions(-) diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage index aea73f8..cf73aa4

Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/ovirt-config-storage | 21 +++++++++++++++------ 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage index c8fb049..46f7e19 100755 --- a/scripts/ovirt-config-storage +++ b/scripts/ovirt-config-storage @@ -83,6 +83,7 @@ get_multipath_deps() {

Putting these out for feedback and comments. These will eventually support the new newt/python based ui for installation/configuration storage.py functions will be moved under a class for better data portability before final version --- scripts/ovirtfunctions.py | 672 +++++++++++++++++++++++++++++++++++++++++++++ scripts/storage.py | 451 ++++++++++++++++++++++++++++++ 2 files

--- scripts/ovirt-config-boot | 13 +++++- scripts/ovirt-config-storage | 111 ++++++++++++++++++++++++------------------ 2 files changed, 75 insertions(+), 49 deletions(-) diff --git a/scripts/ovirt-config-boot b/scripts/ovirt-config-boot index d545878..8cc127b 100755 --- a/scripts/ovirt-config-boot +++ b/scripts/ovirt-config-boot @@ -29,6 +29,12 @@ ovirt_boot_setup() { local disk2

This patch introduces the concept of an "Advanced Storage Configuration", specifically for automated installs (although it could be hooked into manual install), while preserving the original style of specifying LVs. It accomplishes the following: * Add an optional AppVG * Offer new optional LVs - Data2,Swap2 - as part of the new AppVG * Allows the specification of multiple disks, per VG

On Mon, Jun 10 2019 at 5:07am -0400, Pankaj Gupta <pagupta at redhat.com> wrote: > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > devices of device mapper support synchrononous DAX. If device > mapper consists of both synchronous and asynchronous dax devices, > we don't set 'DAXDEV_SYNC' flag. > > Signed-off-by: Pankaj Gupta

On Tue, May 21, 2019 at 6:43 AM Pankaj Gupta <pagupta at redhat.com> wrote: > > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > devices of device mapper support synchrononous DAX. If device > mapper consists of both synchronous and asynchronous dax devices, > we don't set 'DAXDEV_SYNC' flag. > > Signed-off-by: Pankaj Gupta

dm-* devices are references to existing /dev/sd* and /dev/mapper/<wwid>. We should not depend on them and only present /dev/sd* and /dev/mapper/<wwid> to the user. Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/ovirt-config-storage | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/ovirt-config-storage

Previous implementation had staticly defined partitions to remove. This would break in the case of split Root and HostVG devices. Signed-off-by: Mike Burns <mburns at redhat.com> --- scripts/ovirt-config-boot | 11 +-------- scripts/ovirt-config-uninstall | 49 ++++++++++++++++++++++++--------------- scripts/ovirt-functions | 27 ++++++++++++++++++++++ 3 files changed, 58

--- scripts/ovirt-config-boot | 13 +++++++- scripts/ovirt-config-storage | 73 +++++++++++++++++++++++++---------------- 2 files changed, 56 insertions(+), 30 deletions(-) diff --git a/scripts/ovirt-config-boot b/scripts/ovirt-config-boot index d545878..8cc127b 100755 --- a/scripts/ovirt-config-boot +++ b/scripts/ovirt-config-boot @@ -29,6 +29,12 @@ ovirt_boot_setup() { local disk2

The following patches introduce support for multipath and cciss devices to the ovirt-node and node-image. Comments are appreciated. These patches assume that the 3 patches (2 node, 1 node-image) from Joey are all incorporated. Mike

All other patches from the sequence remain unchanged. Repost of patch 6 based on comments from Joey to follow. Mike

This patch sets dax device 'DAXDEV_SYNC' flag if all the target devices of device mapper support synchrononous DAX. If device mapper consists of both synchronous and asynchronous dax devices, we don't set 'DAXDEV_SYNC' flag. 'dm_table_supports_dax' is refactored to pass 'iterate_devices_fn' as argument so that the callers can pass the appropriate functions.

Hi Mike, Thanks for the review Please find my reply inline. > > dm_table_supports_dax() is called multiple times (from > dm_table_set_restrictions and dm_table_determine_type). It is strange > to have a getter have a side-effect of being a setter too. Overloading > like this could get you in trouble in the future. > > Are you certain this is what you want? I agree with

This patch sets dax device 'DAXDEV_SYNC' flag if all the target devices of device mapper support synchrononous DAX. If device mapper consists of both synchronous and asynchronous dax devices, we don't set 'DAXDEV_SYNC' flag. Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/md/dm-table.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git

This patch sets dax device 'DAXDEV_SYNC' flag if all the target devices of device mapper support synchrononous DAX. If device mapper consists of both synchronous and asynchronous dax devices, we don't set 'DAXDEV_SYNC' flag. Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/md/dm-table.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git

This patch sets dax device 'DAXDEV_SYNC' flag if all the target devices of device mapper support synchrononous DAX. If device mapper consists of both synchronous and asynchronous dax devices, we don't set 'DAXDEV_SYNC' flag. Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/md/dm-table.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git