similar to: [bisected] nouveau: "Failed to idle channel x" after resume

On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > Linux kernel only supports logical block sizes which are power of > > two, > > at least 512 bytes and no more that PAGE_SIZE. > > > > Check this instead of crashing later on. > > > > Note that there is no need to check

On Wed, 2020-07-15 at 06:06 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 12:55:18PM +0300, Maxim Levitsky wrote: > > Linux kernel only supports logical block sizes which are power of > > two, > > at least 512 bytes and no more that PAGE_SIZE. > > > > Check this instead of crashing later on. > > > > Note that there is no need to check

Linux kernel only supports logical block sizes which are power of two, at least 512 bytes and no more that PAGE_SIZE. Check this instead of crashing later on. Note that there is no need to check physical block size since it is only a hint, and virtio-blk already only supports power of two values. Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1664619 Signed-off-by: Maxim Levitsky

Linux kernel only supports logical block sizes which are power of two, at least 512 bytes and no more that PAGE_SIZE. Check this instead of crashing later on. Note that there is no need to check physical block size since it is only a hint, and virtio-blk already only supports power of two values. Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1664619 Signed-off-by: Maxim Levitsky

After 5addcf0a (nouveau: add runtime PM support (v0.9)) I'm getting kernel panics immediately after resuming from suspend. Unfortunately it happens so early that I don't get any more info than the blinking keyboard lights... The nouveau tree still panics up to 2fb9d6c, which fails before I can test it. Any ideas? Martin $ lspci 00:00.0 Host bridge: Intel Corporation 3rd Gen Core

Hi, Here is my patch queue I accumulated over quite a long time. Patches 1-6 are bugfixes, and rest is mostly RFC. Comments are welcome. Best regards, Maxim Levitsky

virtio-scsi currently has limit of 8 outstanding notifications so when more that 8 LUNs are unplugged, some are missed. Commit 5ff843721467 ("scsi: virtio_scsi: unplug LUNs when events missed") Fixed this by checking the 'event overflow' bit and manually scanned the bus to see which LUNs are still there. However there is a corner case when all LUNs are unplugged. In this case

This is more or less simplified series of patches that bring power usage on my NV86 close to that of binary blob. Best regards, Maxim Levitsky

On Tue, 2020-07-21 at 22:55 -0400, Martin K. Petersen wrote: > Christoph, > > > Hmm, I wonder if we should simply add the check and warning to > > blk_queue_logical_block_size and add an error in that case. Then > > drivers only have to check the error return, which might add a lot > > less boiler plate code. > > Yep, I agree. > I also agree that this

On Thu, Oct 10, 2013 at 5:35 AM, Martin Nyhus <martin.nyhus at gmx.com> wrote: > After 5addcf0a (nouveau: add runtime PM support (v0.9)) I'm getting kernel > panics immediately after resuming from suspend. Unfortunately it happens so > early that I don't get any more info than the blinking keyboard lights... > > The nouveau tree still panics up to 2fb9d6c, which fails

Hi, It could be my mistake, but I have uptodate versions of xproto, dri2proto, xserver, nouveau ddx, mesa, libdrm. Still the above commit makes X not load nouveau dri module, and fallback to swrast_dri.so. Nothing in X logs, but that 'Screen is not AIGLX capable' Best regards, Maxim Levitsky

Hi, Here I post these 2 misc patches. Best regards, Maxim Levitsky

On Tue, Jul 21, 2020 at 01:52:31PM +0300, Maxim Levitsky wrote: > Linux kernel only supports logical block sizes which are power of two, > at least 512 bytes and no more that PAGE_SIZE. > > Check this instead of crashing later on. > > Note that there is no need to check physical block size since it is > only a hint, and virtio-blk already only supports power of two values.

On Tue, Jul 21, 2020 at 01:52:31PM +0300, Maxim Levitsky wrote: > Linux kernel only supports logical block sizes which are power of two, > at least 512 bytes and no more that PAGE_SIZE. > > Check this instead of crashing later on. > > Note that there is no need to check physical block size since it is > only a hint, and virtio-blk already only supports power of two values.

This patch series aims to move the logical block size checking to the block code. This was inspired by missing check for valid logical block size in virtio-blk which causes the kernel to crash in a weird way later on when it is invalid. I added blk_is_valid_logical_block_size which returns true iff the block size is one of supported sizes. I added this check to virtio-blk, and also converted

This patch series aims to move the logical block size checking to the block code. This was inspired by missing check for valid logical block size in virtio-blk which causes the kernel to crash in a weird way later on when it is invalid. I added blk_is_valid_logical_block_size which returns true iff the block size is one of supported sizes. I added this check to virtio-blk, and also converted

https://bugs.freedesktop.org/show_bug.cgi?id=73342 Priority: medium Bug ID: 73342 Assignee: nouveau at lists.freedesktop.org Summary: nouveau not working with yuy2 overlay QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: All Reporter: fbs777 at gmail.com

> +/** > + * blk_check_logical_block_size - check if logical block size is supported > + * by the kernel > + * @size: the logical block size, in bytes > + * > + * Description: > + * This function checks if the block layers supports given block size > + **/ > +bool blk_is_valid_logical_block_size(unsigned int size) > +{ > + return size >= SECTOR_SIZE

Hi, I have a problem that my nouveau driver does not properly load every time I boot my laptop. It either: - defaults to the vesa driver (always if my power cord is plugged into the laptop - starts nouveau but without the external monitor - starts nouveau WITH the external monitor (as it should be) (starting without the monitor attached and then connecting it always fails & crashes X)

https://bugs.freedesktop.org/show_bug.cgi?id=41608 Summary: Suspending/resuming system with cursor on external screen prevents said screen from restoring after resume Product: xorg Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium