similar to: [PATCH 1/1] virtio: console: tell host of open ports after resume from s3/s4

If we're using multiport, there's no point in always creating a console port. Create the console port only if the host doesn't support multiport. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 32 +++++++++++++++----------------- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/char/virtio_console.c

If we're using multiport, there's no point in always creating a console port. Create the console port only if the host doesn't support multiport. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 32 +++++++++++++++----------------- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/char/virtio_console.c

When removing a port we don't check if a program was blocked for read. This leads to a crash when SIGTERM is sent to the program after hot-unplugging the port. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c

When removing a port we don't check if a program was blocked for read. This leads to a crash when SIGTERM is sent to the program after hot-unplugging the port. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c

Unfortunately there proved to be at least one bug which requires an ABI change, so we're best off not introducing multiport support until 2.6.35. While I generally left the multiport code paths intact, I really wanted to remove the ABI defines from the header, which meant some quite deep cuts. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> To: Amit Shah <amit.shah at

Unfortunately there proved to be at least one bug which requires an ABI change, so we're best off not introducing multiport support until 2.6.35. While I generally left the multiport code paths intact, I really wanted to remove the ABI defines from the header, which meant some quite deep cuts. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> To: Amit Shah <amit.shah at

Hello, This series reworks the ABI to allow port discovery (only) via the control queue and enable multiport again. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of hvc_remove() as removing one such console port causes other console ports (registered with hvc) to

Hello, This series reworks the ABI to allow port discovery (only) via the control queue and enable multiport again. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of hvc_remove() as removing one such console port causes other console ports (registered with hvc) to

Pretty straight-forward, just use accessors for all fields. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_console.h | 7 ++++--- drivers/char/virtio_console.c | 29 +++++++++++++++++------------ 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/include/uapi/linux/virtio_console.h b/include/uapi/linux/virtio_console.h index

Pretty straight-forward, just use accessors for all fields. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_console.h | 7 ++++--- drivers/char/virtio_console.c | 29 +++++++++++++++++------------ 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/include/uapi/linux/virtio_console.h b/include/uapi/linux/virtio_console.h index

Hey Rusty, These are the patches that rework a few bits to make hot-unplug while ports are open not crash apps (or kernels). The problem is when hot-unplug is performed when a port is open, the cdev struct is kept around by the file pointers and when the app later does a 'close', things go boom-boom. This patch series makes sure port as well as device hot-unplug is now safe to perform

Hey Rusty, These are the patches that rework a few bits to make hot-unplug while ports are open not crash apps (or kernels). The problem is when hot-unplug is performed when a port is open, the cdev struct is kept around by the file pointers and when the app later does a 'close', things go boom-boom. This patch series makes sure port as well as device hot-unplug is now safe to perform

Hello, This patchset is still based on Linus' tree but I'll rebase when Rusty sends out the disable multiport patches. This series reworks the ABI to allow port discovery (only) via the control queue. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of

Hello, This patchset is still based on Linus' tree but I'll rebase when Rusty sends out the disable multiport patches. This series reworks the ABI to allow port discovery (only) via the control queue. In addition, it adds support for non-blocking write() support, which means no spinning. This works fine with the recent patches that are on qemu-devel. Also included is removal of

Hello Rusty, This patch updates the virtio spec (0.8.6) with the new ABI information for virtio-console. Please apply. --- virtio-spec-0.8.6.lyx 2010-04-16 12:06:13.416075709 +0530 +++ virtio-spec-0.8.6-virtio-console.lyx 2010-04-16 12:41:54.656201703 +0530 @@ -36,7 +36,7 @@ \paperpagestyle default \tracking_changes true \output_changes false -\author "" +\author "Amit

Hello Rusty, This patch updates the virtio spec (0.8.6) with the new ABI information for virtio-console. Please apply. --- virtio-spec-0.8.6.lyx 2010-04-16 12:06:13.416075709 +0530 +++ virtio-spec-0.8.6-virtio-console.lyx 2010-04-16 12:41:54.656201703 +0530 @@ -36,7 +36,7 @@ \paperpagestyle default \tracking_changes true \output_changes false -\author "" +\author "Amit

Hey Rusty, Here are a few fixes for virtio and virtio_console. The first patch ensures the data elements of vqs are properly initialised at allocation-time so that we don't trigger BUG_ONs. I found this when hot-unplugging ports and there was just one unused buffer. detach_unused_buffers() kept returning pointers that were invalid. I didn't catch this earlier as I had the in_vq filled

Hey Rusty, Here are a few fixes for virtio and virtio_console. The first patch ensures the data elements of vqs are properly initialised at allocation-time so that we don't trigger BUG_ONs. I found this when hot-unplugging ports and there was just one unused buffer. detach_unused_buffers() kept returning pointers that were invalid. I didn't catch this earlier as I had the in_vq filled

Hello Rusty, To avoid sending the same patches again, this time I'm trying a git pull request. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/amit/vs-kernel.git for-rusty to get the patches that I've sent to the list previously, with a couple of fixes: - Create a console port when not using multiport (fix was sent as a reply to prev. series) - Add hunk that got

Hello Rusty, To avoid sending the same patches again, this time I'm trying a git pull request. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/amit/vs-kernel.git for-rusty to get the patches that I've sent to the list previously, with a couple of fixes: - Create a console port when not using multiport (fix was sent as a reply to prev. series) - Add hunk that got