Displaying 20 results from an estimated 30000 matches similar to: "[PATCH 0/8] virtio: console: Fixes, cleanups, stats for bytes transferred"
2010 Mar 30
1
[PATCH 3/4] virtio: console makes incorrect assumption about virtio API
The get_buf() API sets the second arg to the number of bytes *written*
by the other side; in this case it should be zero as these are output buffers.
lguest gets this right (obviously kvm's console doesn't), resulting in
continual buildup of console writes.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
To: Amit Shah <amit.shah at redhat.com>
---
2010 Mar 30
1
[PATCH 3/4] virtio: console makes incorrect assumption about virtio API
The get_buf() API sets the second arg to the number of bytes *written*
by the other side; in this case it should be zero as these are output buffers.
lguest gets this right (obviously kvm's console doesn't), resulting in
continual buildup of console writes.
Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>
To: Amit Shah <amit.shah at redhat.com>
---
2010 Mar 23
1
[PATCH 0/8] (v4) virtio: console: Fixes, new way of discovering ports
Hello,
This version addresses comments by Gerd and Michael:
- instead of returning -EPIPE if host is not connected in the write
case, just block the write if it's a blocking file and return -EAGAIN
if it's non-blocking.
- Removes early_console_printk after the first console is found
- Adds early_put_chars fix by Fran??ois Diakhat??. It still needs a
sign-off by him.
Standard
2010 Mar 23
1
[PATCH 0/8] (v4) virtio: console: Fixes, new way of discovering ports
Hello,
This version addresses comments by Gerd and Michael:
- instead of returning -EPIPE if host is not connected in the write
case, just block the write if it's a blocking file and return -EAGAIN
if it's non-blocking.
- Removes early_console_printk after the first console is found
- Adds early_put_chars fix by Fran??ois Diakhat??. It still needs a
sign-off by him.
Standard
2013 Aug 01
1
[PATCH v3 9/9] virtio: console: prevent use-after-free of port name in port unplug
Amit Shah <amit.shah at redhat.com> writes:
> On (Mon) 29 Jul 2013 [14:26:09], Rusty Russell wrote:
>> Amit Shah <amit.shah at redhat.com> writes:
>> > Remove the debugfs path before freeing port->name, to prevent a possible
>> > use-after-free.
>> >
>> > Reported-by: Jason Wang <jasowang at redhat.com>
>> > Signed-off-by:
2013 Aug 01
1
[PATCH v3 9/9] virtio: console: prevent use-after-free of port name in port unplug
Amit Shah <amit.shah at redhat.com> writes:
> On (Mon) 29 Jul 2013 [14:26:09], Rusty Russell wrote:
>> Amit Shah <amit.shah at redhat.com> writes:
>> > Remove the debugfs path before freeing port->name, to prevent a possible
>> > use-after-free.
>> >
>> > Reported-by: Jason Wang <jasowang at redhat.com>
>> > Signed-off-by:
2013 Jul 29
2
[PATCH v3 9/9] virtio: console: prevent use-after-free of port name in port unplug
Amit Shah <amit.shah at redhat.com> writes:
> Remove the debugfs path before freeing port->name, to prevent a possible
> use-after-free.
>
> Reported-by: Jason Wang <jasowang at redhat.com>
> Signed-off-by: Amit Shah <amit.shah at redhat.com>
Applied,
Rusty.
> ---
> drivers/char/virtio_console.c | 3 +--
> 1 file changed, 1 insertion(+), 2
2013 Jul 29
2
[PATCH v3 9/9] virtio: console: prevent use-after-free of port name in port unplug
Amit Shah <amit.shah at redhat.com> writes:
> Remove the debugfs path before freeing port->name, to prevent a possible
> use-after-free.
>
> Reported-by: Jason Wang <jasowang at redhat.com>
> Signed-off-by: Amit Shah <amit.shah at redhat.com>
Applied,
Rusty.
> ---
> drivers/char/virtio_console.c | 3 +--
> 1 file changed, 1 insertion(+), 2
2013 Jul 22
3
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
Amit Shah <amit.shah at redhat.com> writes:
> On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote:
>> On 07/19/2013 03:48 PM, Amit Shah wrote:
>> > On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote:
>> >> On 07/19/2013 04:16 AM, Amit Shah wrote:
>> >>> Between poll() being called and processed, the port can be unplugged.
>> >>> Check
2013 Jul 22
3
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
Amit Shah <amit.shah at redhat.com> writes:
> On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote:
>> On 07/19/2013 03:48 PM, Amit Shah wrote:
>> > On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote:
>> >> On 07/19/2013 04:16 AM, Amit Shah wrote:
>> >>> Between poll() being called and processed, the port can be unplugged.
>> >>> Check
2013 Jul 24
1
[PATCH 08/10] virtio: console: add locks around buffer removal in port unplug path
Amit Shah <amit.shah at redhat.com> writes:
> On (Mon) 22 Jul 2013 [15:26:22], Rusty Russell wrote:
>> Amit Shah <amit.shah at redhat.com> writes:
>> > The removal functions act on the vqs, and the vq operations need to be
>> > locked.
>> >
>> > Signed-off-by: Amit Shah <amit.shah at redhat.com>
>>
>> How can userspace
2013 Jul 24
1
[PATCH 08/10] virtio: console: add locks around buffer removal in port unplug path
Amit Shah <amit.shah at redhat.com> writes:
> On (Mon) 22 Jul 2013 [15:26:22], Rusty Russell wrote:
>> Amit Shah <amit.shah at redhat.com> writes:
>> > The removal functions act on the vqs, and the vq operations need to be
>> > locked.
>> >
>> > Signed-off-by: Amit Shah <amit.shah at redhat.com>
>>
>> How can userspace
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
On 07/19/2013 03:48 PM, Amit Shah wrote:
> On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote:
>> On 07/19/2013 04:16 AM, Amit Shah wrote:
>>> Between poll() being called and processed, the port can be unplugged.
>>> Check if this happened, and bail out.
>>>
>>> Signed-off-by: Amit Shah <amit.shah at redhat.com>
>>> ---
>>>
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
On 07/19/2013 03:48 PM, Amit Shah wrote:
> On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote:
>> On 07/19/2013 04:16 AM, Amit Shah wrote:
>>> Between poll() being called and processed, the port can be unplugged.
>>> Check if this happened, and bail out.
>>>
>>> Signed-off-by: Amit Shah <amit.shah at redhat.com>
>>> ---
>>>
2013 Jul 22
2
[PATCH 08/10] virtio: console: add locks around buffer removal in port unplug path
Amit Shah <amit.shah at redhat.com> writes:
> The removal functions act on the vqs, and the vq operations need to be
> locked.
>
> Signed-off-by: Amit Shah <amit.shah at redhat.com>
How can userspace access the port now? By the time we are cleaning up
buffers, there should be no possibility of such accesses.
The number of bugfixes here is deeply disturbing. I wonder if
2013 Jul 22
2
[PATCH 08/10] virtio: console: add locks around buffer removal in port unplug path
Amit Shah <amit.shah at redhat.com> writes:
> The removal functions act on the vqs, and the vq operations need to be
> locked.
>
> Signed-off-by: Amit Shah <amit.shah at redhat.com>
How can userspace access the port now? By the time we are cleaning up
buffers, there should be no possibility of such accesses.
The number of bugfixes here is deeply disturbing. I wonder if
2013 Jul 23
1
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
Jason Wang <jasowang at redhat.com> writes:
> On 07/22/2013 01:45 PM, Rusty Russell wrote:
>> Amit Shah <amit.shah at redhat.com> writes:
>>> On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote:
>>>> On 07/19/2013 03:48 PM, Amit Shah wrote:
>>>>> On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote:
>>>>>> On 07/19/2013 04:16
2013 Jul 23
1
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
Jason Wang <jasowang at redhat.com> writes:
> On 07/22/2013 01:45 PM, Rusty Russell wrote:
>> Amit Shah <amit.shah at redhat.com> writes:
>>> On (Fri) 19 Jul 2013 [18:17:32], Jason Wang wrote:
>>>> On 07/19/2013 03:48 PM, Amit Shah wrote:
>>>>> On (Fri) 19 Jul 2013 [15:03:50], Jason Wang wrote:
>>>>>> On 07/19/2013 04:16
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
On 07/19/2013 04:16 AM, Amit Shah wrote:
> Between poll() being called and processed, the port can be unplugged.
> Check if this happened, and bail out.
>
> Signed-off-by: Amit Shah <amit.shah at redhat.com>
> ---
> drivers/char/virtio_console.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/char/virtio_console.c
2013 Jul 19
2
[PATCH 06/10] virtio: console: fix race in port_fops_poll() and port unplug
On 07/19/2013 04:16 AM, Amit Shah wrote:
> Between poll() being called and processed, the port can be unplugged.
> Check if this happened, and bail out.
>
> Signed-off-by: Amit Shah <amit.shah at redhat.com>
> ---
> drivers/char/virtio_console.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/char/virtio_console.c