similar to: Hyper-V vmbus driver

Greg, A few days ago you applied all the outstanding patches for the Hyper-V drivers. With these patches, I have addressed all of the known review comments for the vmbus driver (and a lot of comments/issues in other drivers as well). I am still hoping I can address whatever other issues/comments there might be with the intention to get the vmbus driver out of staging in the current window.

Greg, A few days ago you applied all the outstanding patches for the Hyper-V drivers. With these patches, I have addressed all of the known review comments for the vmbus driver (and a lot of comments/issues in other drivers as well). I am still hoping I can address whatever other issues/comments there might be with the intention to get the vmbus driver out of staging in the current window.

From: Hank Janssen <hjanssen at microsoft.com> Removed TODO for VMBUS, it mirrors HYPER-V behaviour to closely and does not really share any usable functionality of the Linux kernel facilities. There is not really an easy way to combine functionality. Signed-off-by:Hank Janssen <hjanssen at microsoft.com> Signed-off-by:Haiyang Zhang <haiyangz at microsoft.com> ---

From: Hank Janssen <hjanssen at microsoft.com> Removed TODO for VMBUS, it mirrors HYPER-V behaviour to closely and does not really share any usable functionality of the Linux kernel facilities. There is not really an easy way to combine functionality. Signed-off-by:Hank Janssen <hjanssen at microsoft.com> Signed-off-by:Haiyang Zhang <haiyangz at microsoft.com> ---

I just took a quick look at the vmbus code, and have the following comments: - why is count_hv_channel() even a function? - your .h files need to be consolidated and renamed. You will need a single hyperv.h file for include/linux/ that will contain some of what the vmbus*.h files have in it, but not all. Please merge things together to have: - include/linux/hyperv.h What is

I just took a quick look at the vmbus code, and have the following comments: - why is count_hv_channel() even a function? - your .h files need to be consolidated and renamed. You will need a single hyperv.h file for include/linux/ that will contain some of what the vmbus*.h files have in it, but not all. Please merge things together to have: - include/linux/hyperv.h What is

Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> --- drivers/staging/hv/vmbus_drv.c | 72 +++++++++++++++++++++++++++++++--------- 1 files changed, 56 insertions(+), 16 deletions(-) diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c

Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> --- drivers/staging/hv/vmbus_drv.c | 72 +++++++++++++++++++++++++++++++--------- 1 files changed, 56 insertions(+), 16 deletions(-) diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c

Greg, The TODO file for Hyper-V drivers has not been updated in a while and does not reflect the current state of these drivers: 1) There are no more checkpatch warnings/errors in this code. One of the TODO work items is "fix remaining checkpatch warnings and errors". 2) With your help, we have fixed all of the issues related to these drivers conforming to the Linux Device Driver

Greg, The TODO file for Hyper-V drivers has not been updated in a while and does not reflect the current state of these drivers: 1) There are no more checkpatch warnings/errors in this code. One of the TODO work items is "fix remaining checkpatch warnings and errors". 2) With your help, we have fixed all of the issues related to these drivers conforming to the Linux Device Driver

Show a modalias file in /sys/bus/vmbus/devices/*/ Add a helper function to print the same content in modalias and uevent. Signed-off-by: Olaf Hering <olaf at aepfle.de> --- drivers/staging/hv/vmbus_drv.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) --- a/drivers/staging/hv/vmbus_drv.c +++ b/drivers/staging/hv/vmbus_drv.c @@ -93,6 +93,14 @@ static void

Show a modalias file in /sys/bus/vmbus/devices/*/ Add a helper function to print the same content in modalias and uevent. Signed-off-by: Olaf Hering <olaf at aepfle.de> --- drivers/staging/hv/vmbus_drv.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) --- a/drivers/staging/hv/vmbus_drv.c +++ b/drivers/staging/hv/vmbus_drv.c @@ -93,6 +93,14 @@ static void

Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> --- drivers/staging/hv/vmbus_drv.c | 49 +++++++++++++++++++++++++++------------ 1 files changed, 34 insertions(+), 15 deletions(-) diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c

Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> --- drivers/staging/hv/vmbus_drv.c | 49 +++++++++++++++++++++++++++------------ 1 files changed, 34 insertions(+), 15 deletions(-) diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c

Make vmbus driver a platform pci driver. This is in preparation to cleaning up irq allocation for this driver. Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Mike Sterling <mike.sterling at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen

Make vmbus driver a platform pci driver. This is in preparation to cleaning up irq allocation for this driver. Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Mike Sterling <mike.sterling at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen

Greg, Some weeks ago, I had sent out a fairly large patch-set for your consideration. I know you are very busy; however, I am getting a little nervous since I have not heard from you. Please let me know if I should resend these patches. In addition to this one large patch-set, we have also sent a bunch of other patches as well. I just want to make sure that these patches are still in your

Greg, Some weeks ago, I had sent out a fairly large patch-set for your consideration. I know you are very busy; however, I am getting a little nervous since I have not heard from you. Please let me know if I should resend these patches. In addition to this one large patch-set, we have also sent a bunch of other patches as well. I just want to make sure that these patches are still in your

Hyper-V drivers have supported two device abstractions. This patch implements a single device abstraction. This simplifies the code and avoids duplication of state. Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> --- drivers/staging/hv/blkvsc.c | 17

Hyper-V drivers have supported two device abstractions. This patch implements a single device abstraction. This simplifies the code and avoids duplication of state. Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> --- drivers/staging/hv/blkvsc.c | 17