similar to: [RFC][PATCH] virtio balloon: kill tell-host-first logic

On Wed, Feb 05, 2020 at 05:34:02PM +0100, David Hildenbrand wrote: > Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") > changed the behavior when deflation happens automatically. Instead of > deflating when called by the OOM handler, the shrinker is used. > > However, the balloon is not simply some slab cache that should be > shrunk when under

On Wed, Feb 05, 2020 at 05:34:02PM +0100, David Hildenbrand wrote: > Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") > changed the behavior when deflation happens automatically. Instead of > deflating when called by the OOM handler, the shrinker is used. > > However, the balloon is not simply some slab cache that should be > shrunk when under

On Thu, Feb 06, 2020 at 09:42:34AM +0100, David Hildenbrand wrote: > On 06.02.20 08:40, Michael S. Tsirkin wrote: > > On Wed, Feb 05, 2020 at 05:34:02PM +0100, David Hildenbrand wrote: > >> Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") > >> changed the behavior when deflation happens automatically. Instead of > >> deflating

On Thu, Feb 06, 2020 at 09:42:34AM +0100, David Hildenbrand wrote: > On 06.02.20 08:40, Michael S. Tsirkin wrote: > > On Wed, Feb 05, 2020 at 05:34:02PM +0100, David Hildenbrand wrote: > >> Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") > >> changed the behavior when deflation happens automatically. Instead of > >> deflating

Unless the host requires that requested pages won't be used until he us notified (VIRTIO_BALLOON_F_MUST_TELL_HOST), only notify after deflating the balloon. This will avoid having to take an exit before actually using the pages. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: virtualization at lists.linux-foundation.org Cc:

Unless the host requires that requested pages won't be used until he us notified (VIRTIO_BALLOON_F_MUST_TELL_HOST), only notify after deflating the balloon. This will avoid having to take an exit before actually using the pages. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: virtualization at lists.linux-foundation.org Cc:

On 06.02.20 08:40, Michael S. Tsirkin wrote: > On Wed, Feb 05, 2020 at 05:34:02PM +0100, David Hildenbrand wrote: >> Commit 71994620bb25 ("virtio_balloon: replace oom notifier with shrinker") >> changed the behavior when deflation happens automatically. Instead of >> deflating when called by the OOM handler, the shrinker is used. >> >> However, the

Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: > At this point I am confused. I think there are two changes in your patch: > > 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST > Is this functionally identical to what I proposed? > If yes, I am fine with either change being applied. Yes. > 2. New SILENT_DEFLATE feature > Since guest can get same functionality by not

Il 28/05/2013 16:29, Michael S. Tsirkin ha scritto: > On Tue, May 28, 2013 at 04:06:02PM +0200, Paolo Bonzini wrote: >> Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: >>> At this point I am confused. I think there are two changes in your patch: >>> >>> 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST >>> Is this functionally identical to what I

Workqueues have clean and rich API for all basic operations. The code is usually easier and better readable. It can be easily tuned for the given purpose. In many cases, it allows to avoid an extra kernel thread. It helps to stop the growing number of them. Also there will be less thread-specific hacks all over the kernel code. It forces making the task selfcontained. There is no longer an

Workqueues have clean and rich API for all basic operations. The code is usually easier and better readable. It can be easily tuned for the given purpose. In many cases, it allows to avoid an extra kernel thread. It helps to stop the growing number of them. Also there will be less thread-specific hacks all over the kernel code. It forces making the task selfcontained. There is no longer an

This series contains one cleanup and two bug fixes for the virtio balloon driver.

This series contains one cleanup and two bug fixes for the virtio balloon driver.

Il 28/05/2013 17:09, Michael S. Tsirkin ha scritto: > On Tue, May 28, 2013 at 04:32:44PM +0200, Paolo Bonzini wrote: >> Il 28/05/2013 16:29, Michael S. Tsirkin ha scritto: >>> On Tue, May 28, 2013 at 04:06:02PM +0200, Paolo Bonzini wrote: >>>> Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: >>>>> At this point I am confused. I think there are two

This patchset follows the main idea discussed at 2012 LSFMMS section: "Ballooning for transparent huge pages" -- http://lwn.net/Articles/490114/ to introduce the required changes to the virtio_balloon driver, as well as changes to the core compaction & migration bits, in order to allow memory balloon pages become movable within a guest. Rafael Aquini (4): mm: introduce compaction

This patchset follows the main idea discussed at 2012 LSFMMS section: "Ballooning for transparent huge pages" -- http://lwn.net/Articles/490114/ to introduce the required changes to the virtio_balloon driver, as well as changes to the core compaction & migration bits, in order to allow memory balloon pages become movable within a guest. Rafael Aquini (4): mm: introduce compaction

On Tue, May 28, 2013 at 04:06:02PM +0200, Paolo Bonzini wrote: > Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: > > At this point I am confused. I think there are two changes in your patch: > > > > 1. Handling of VIRTIO_F_GUEST_MUST_TELL_HOST > > Is this functionally identical to what I proposed? > > If yes, I am fine with either change being applied. >

Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. This patchset follows the main idea discussed at 2012 LSFMMS section: "Ballooning for transparent huge

Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. This patchset follows the main idea discussed at 2012 LSFMMS section: "Ballooning for transparent huge

On Tue, May 28, 2013 at 04:32:44PM +0200, Paolo Bonzini wrote: > Il 28/05/2013 16:29, Michael S. Tsirkin ha scritto: > > On Tue, May 28, 2013 at 04:06:02PM +0200, Paolo Bonzini wrote: > >> Il 28/05/2013 15:32, Michael S. Tsirkin ha scritto: > >>> At this point I am confused. I think there are two changes in your patch: > >>> > >>> 1. Handling