similar to: [PATCH] vhost: rcu annotation fixup

When built with rcu checks enabled, vhost triggers bogus warnings as vhost features are read without dev->mutex sometimes, and private pointer is read with our kind of rcu where work serves as a read side critical section. Fixing it properly is not trivial. Disable the warnings by stubbing out the checks for now. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Changes from

When built with rcu checks enabled, vhost triggers bogus warnings as vhost features are read without dev->mutex sometimes, and private pointer is read with our kind of rcu where work serves as a read side critical section. Fixing it properly is not trivial. Disable the warnings by stubbing out the checks for now. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Changes from

Refactor code to make sure features are only accessed under VQ mutex. This makes everything simpler, no need for RCU here anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This is on top of the recent pull request that I sent. drivers/vhost/vhost.h | 11 +++-------- drivers/vhost/net.c | 8 +++----- drivers/vhost/scsi.c | 22 +++++++++++++---------

Refactor code to make sure features are only accessed under VQ mutex. This makes everything simpler, no need for RCU here anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- This is on top of the recent pull request that I sent. drivers/vhost/vhost.h | 11 +++-------- drivers/vhost/net.c | 8 +++----- drivers/vhost/scsi.c | 22 +++++++++++++---------

Refactor code to make sure features are only accessed under VQ mutex. This makes everything simpler, no need for RCU here anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Note: this is on top of my last pull request drivers/vhost/vhost.h | 11 +++-------- drivers/vhost/net.c | 8 +++----- drivers/vhost/scsi.c | 22 +++++++++++++--------- drivers/vhost/test.c | 9

Refactor code to make sure features are only accessed under VQ mutex. This makes everything simpler, no need for RCU here anymore. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Note: this is on top of my last pull request drivers/vhost/vhost.h | 11 +++-------- drivers/vhost/net.c | 8 +++----- drivers/vhost/scsi.c | 22 +++++++++++++--------- drivers/vhost/test.c | 9

We sometimes need to map between the virtio device and the given pci device. One such use is OS installer that gets the boot pci device from BIOS and needs to find the relevant block device. Since it can't, installation fails. Supply softlinks between these to make it possible. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Gleb, could you please ack that this patch below

We sometimes need to map between the virtio device and the given pci device. One such use is OS installer that gets the boot pci device from BIOS and needs to find the relevant block device. Since it can't, installation fails. Supply softlinks between these to make it possible. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Gleb, could you please ack that this patch below

We need to use bit 32 for virtio 1.0 Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index 3eda654..c624b09 100644 --- a/drivers/vhost/vhost.h +++ b/drivers/vhost/vhost.h @@ -106,7 +106,7

We need to use bit 32 for virtio 1.0 Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Reviewed-by: Jason Wang <jasowang at redhat.com> --- drivers/vhost/vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index 3eda654..c624b09 100644 --- a/drivers/vhost/vhost.h +++ b/drivers/vhost/vhost.h @@ -106,7 +106,7

This patch adds mergeable receive buffer support to qemu-kvm, to allow enabling it when vhost_net supports it. It also adds a missing call to vhost_net_ack_features() to push acked features to vhost_net. The patch is relative to Michael Tsirkin's qemu-kvm git tree. +-DLS Signed-off-by: David L Stevens <dlstevens at us.ibm.com> diff -ruNp qemu-kvm.mst/hw/vhost_net.c

This patch adds mergeable receive buffer support to qemu-kvm, to allow enabling it when vhost_net supports it. It also adds a missing call to vhost_net_ack_features() to push acked features to vhost_net. The patch is relative to Michael Tsirkin's qemu-kvm git tree. +-DLS Signed-off-by: David L Stevens <dlstevens at us.ibm.com> diff -ruNp qemu-kvm.mst/hw/vhost_net.c

On Sun, 2014-11-30 at 18:44 +0300, Sergei Shtylyov wrote: > Hello. > > On 11/30/2014 6:11 PM, Michael S. Tsirkin wrote: > > > We need to use bit 32 for virtio 1.0 > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > Reviewed-by: Jason Wang <jasowang at redhat.com> > > --- > > drivers/vhost/vhost.h | 4 ++-- > > 1 file

On Sun, 2014-11-30 at 18:44 +0300, Sergei Shtylyov wrote: > Hello. > > On 11/30/2014 6:11 PM, Michael S. Tsirkin wrote: > > > We need to use bit 32 for virtio 1.0 > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > Reviewed-by: Jason Wang <jasowang at redhat.com> > > --- > > drivers/vhost/vhost.h | 4 ++-- > > 1 file

We need to use bit 32 for virtio 1.0 Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index 3eda654..c624b09 100644 --- a/drivers/vhost/vhost.h +++ b/drivers/vhost/vhost.h @@ -106,7 +106,7 @@ struct vhost_virtqueue { /* Protected by

We need to use bit 32 for virtio 1.0 Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index 3eda654..c624b09 100644 --- a/drivers/vhost/vhost.h +++ b/drivers/vhost/vhost.h @@ -106,7 +106,7 @@ struct vhost_virtqueue { /* Protected by

Asias He (3): vhost: Remove vhost_enable_zcopy in vhost.h vhost: Move VHOST_NET_FEATURES to net.c vhost: Make vhost a separate module drivers/vhost/Kconfig | 8 ++++++++ drivers/vhost/Makefile | 3 ++- drivers/vhost/net.c | 6 ++++++ drivers/vhost/scsi.c | 1 - drivers/vhost/vhost.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++- drivers/vhost/vhost.h | 8 ++------ 6

Asias He (3): vhost: Remove vhost_enable_zcopy in vhost.h vhost: Move VHOST_NET_FEATURES to net.c vhost: Make vhost a separate module drivers/vhost/Kconfig | 8 ++++++++ drivers/vhost/Makefile | 3 ++- drivers/vhost/net.c | 6 ++++++ drivers/vhost/scsi.c | 1 - drivers/vhost/vhost.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++- drivers/vhost/vhost.h | 8 ++------ 6

On Wed, Nov 26, 2014 at 02:54:38PM +0100, Cornelia Huck wrote: > On Tue, 25 Nov 2014 18:43:10 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > "These wrappers are needed to handle virtio endianness conversions." > > ? yes, it's same as virtio ones. I'll add this text, thanks. > > Signed-off-by: Michael S. Tsirkin <mst at

On Wed, Nov 26, 2014 at 02:54:38PM +0100, Cornelia Huck wrote: > On Tue, 25 Nov 2014 18:43:10 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > "These wrappers are needed to handle virtio endianness conversions." > > ? yes, it's same as virtio ones. I'll add this text, thanks. > > Signed-off-by: Michael S. Tsirkin <mst at