similar to: [GIT PULL net-2.6] vhost-net: access_ok fix

On biarch kernels, it is not safe to do copy from/to user, even with use_mm, unless we checked the address range with access_ok previously. Implement these checks to enforce safe memory accesses. Reported-by: Al Viro <viro at zeniv.linux.org.uk> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/net.c | 17 ++++++- drivers/vhost/vhost.c | 111

On biarch kernels, it is not safe to do copy from/to user, even with use_mm, unless we checked the address range with access_ok previously. Implement these checks to enforce safe memory accesses. Reported-by: Al Viro <viro at zeniv.linux.org.uk> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/net.c | 17 ++++++- drivers/vhost/vhost.c | 111

I did an audit for potential integer overflows of values which get passed to access_ok() and here are the results. Signed-off-by: Dan Carpenter <error27 at gmail.com> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index dd3d6f7..c2aa12c 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -429,6 +429,14 @@ static int vq_access_ok(unsigned int num, struct

I did an audit for potential integer overflows of values which get passed to access_ok() and here are the results. Signed-off-by: Dan Carpenter <error27 at gmail.com> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index dd3d6f7..c2aa12c 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -429,6 +429,14 @@ static int vq_access_ok(unsigned int num, struct

access_ok() returns 1 if it's OK otherwise it should return 0. Signed-off-by: Dan Carpenter <error27 at gmail.com> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index c2aa12c..f82fe57 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -371,7 +371,7 @@ static int log_access_ok(void __user *log_base, u64 addr, unsigned long sz) /* Make sure 64 bit math will

access_ok() returns 1 if it's OK otherwise it should return 0. Signed-off-by: Dan Carpenter <error27 at gmail.com> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index c2aa12c..f82fe57 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -371,7 +371,7 @@ static int log_access_ok(void __user *log_base, u64 addr, unsigned long sz) /* Make sure 64 bit math will

It looks like it was a quiet cycle for vhost-net: probably because most of energy was spent on bugfixes that went in for 2.6.36. People are working on multiqueue, tracing but I'm not sure it'll get done in time for 2.6.37 - so here's a tree with a single patch that helps windows guests which we definitely want in the next kernel. Please merge for 2.6.37. Thanks! The following changes

It looks like it was a quiet cycle for vhost-net: probably because most of energy was spent on bugfixes that went in for 2.6.36. People are working on multiqueue, tracing but I'm not sure it'll get done in time for 2.6.37 - so here's a tree with a single patch that helps windows guests which we definitely want in the next kernel. Please merge for 2.6.37. Thanks! The following changes

On Thu, Jan 10, 2013 at 11:57:25AM +0300, Dan Carpenter wrote: > The closing parenthesis is in the wrong place. We want to check > "sizeof(*arg->clone_sources) * arg->clone_sources_count" instead of > "sizeof(*arg->clone_sources * arg->clone_sources_count)". > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Original message id:

Hi, I have to install Broadcom driver because the Dell Optiplex 330 running Centos 5.2 is not able to connect to the network. I am trying to install a Broadcom driver, but I get the followng error: [root at localhost tg3-3.85l]# [root at localhost tg3-3.85l]# make make -C /lib/modules/2.6.18-92.el5/build SUBDIRS=/usr/src/Server/Linux/Driver/tg3-3.85l modules make[1]: Entering directory

On 2017/12/25 3:16, Stephen Hemminger wrote: > On Wed, 20 Dec 2017 13:40:37 +0900 > Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote: > >> + >> +static const struct virtnet_gstats virtnet_gstrings_stats[] = { >> + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, >> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >>

On 2017/12/25 3:16, Stephen Hemminger wrote: > On Wed, 20 Dec 2017 13:40:37 +0900 > Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> wrote: > >> + >> +static const struct virtnet_gstats virtnet_gstrings_stats[] = { >> + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, >> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >>

Full updated EL6: Does someone have the same behaviour, unstable eth interface (tg3/no dhcp)? Jan 19 18:01:46 ane kernel: tg3 0000:04:00.0: eth0: Link is up at 1000 Mbps, full duplex Jan 19 18:01:46 ane kernel: tg3 0000:04:00.0: eth0: Flow control is on for TX and on for RX Jan 19 18:01:46 ane kernel: tg3 0000:04:00.0: eth0: EEE is enabled Jan 19 18:01:46 ane NetworkManager[1735]: <info>

The network device operation for reading statistics is only called in one place, and it ignores the return value. Having a structure return value is potentially confusing because some future driver could incorrectly assume that the return value was used. Fix all drivers with ndo_get_stats64 to have a void function. Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com> ---

The network device operation for reading statistics is only called in one place, and it ignores the return value. Having a structure return value is potentially confusing because some future driver could incorrectly assume that the return value was used. Fix all drivers with ndo_get_stats64 to have a void function. Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com> ---

Dear All, I am having a HP xw4400 with following ethernet controller as reported by lspci Broadcom Corporation NetXtreme BCM5755 Gigabit Ethernet PCI Express (rev 02) This machine was running CentOS 5.2 without any problem. After updating the machine with yum update on 8 April, after which it is showing to be CentOS 5.3, this machine stops communicating

This fixes two issues with recent access checking patch: 1. if (&d->vqs[i].private_data) -> if (d->vqs[i].private_data) 2. we can't forbid log base changes while ring is running, because host needs to resize log in rare cases (e.g. when memory is added with a baloon) and in that case it needs to increase log size with realloc, which might move the log address.

This fixes two issues with recent access checking patch: 1. if (&d->vqs[i].private_data) -> if (d->vqs[i].private_data) 2. we can't forbid log base changes while ring is running, because host needs to resize log in rare cases (e.g. when memory is added with a baloon) and in that case it needs to increase log size with realloc, which might move the log address.

The main purpose of this patch is adding a way of checking per-queue stats. It's useful to debug performance problems on multiqueue environment. $ ethtool -S ens10 NIC statistics: rx_packets: 4172939 tx_packets: 5855538 rx_bytes: 6317757408 tx_bytes: 8865151846 rx_dropped: 0 rx_length_errors: 0 rx_frame_errors: 0 tx_dropped: 0 tx_fifo_errors: 0

The main purpose of this patch is adding a way of checking per-queue stats. It's useful to debug performance problems on multiqueue environment. $ ethtool -S ens10 NIC statistics: rx_packets: 4172939 tx_packets: 5855538 rx_bytes: 6317757408 tx_bytes: 8865151846 rx_dropped: 0 rx_length_errors: 0 rx_frame_errors: 0 tx_dropped: 0 tx_fifo_errors: 0