similar to: [PATCH 09/11] virtio: console: Don't always create a port 0 if using multiport

Pretty straight-forward, just use accessors for all fields. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_console.h | 7 ++++--- drivers/char/virtio_console.c | 29 +++++++++++++++++------------ 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/include/uapi/linux/virtio_console.h b/include/uapi/linux/virtio_console.h index

Pretty straight-forward, just use accessors for all fields. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_console.h | 7 ++++--- drivers/char/virtio_console.c | 29 +++++++++++++++++------------ 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/include/uapi/linux/virtio_console.h b/include/uapi/linux/virtio_console.h index

Unfortunately there proved to be at least one bug which requires an ABI change, so we're best off not introducing multiport support until 2.6.35. While I generally left the multiport code paths intact, I really wanted to remove the ABI defines from the header, which meant some quite deep cuts. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> To: Amit Shah <amit.shah at

Unfortunately there proved to be at least one bug which requires an ABI change, so we're best off not introducing multiport support until 2.6.35. While I generally left the multiport code paths intact, I really wanted to remove the ABI defines from the header, which meant some quite deep cuts. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> To: Amit Shah <amit.shah at

Hello Rusty, This patch updates the virtio spec (0.8.6) with the new ABI information for virtio-console. Please apply. --- virtio-spec-0.8.6.lyx 2010-04-16 12:06:13.416075709 +0530 +++ virtio-spec-0.8.6-virtio-console.lyx 2010-04-16 12:41:54.656201703 +0530 @@ -36,7 +36,7 @@ \paperpagestyle default \tracking_changes true \output_changes false -\author "" +\author "Amit

Hello Rusty, This patch updates the virtio spec (0.8.6) with the new ABI information for virtio-console. Please apply. --- virtio-spec-0.8.6.lyx 2010-04-16 12:06:13.416075709 +0530 +++ virtio-spec-0.8.6-virtio-console.lyx 2010-04-16 12:41:54.656201703 +0530 @@ -36,7 +36,7 @@ \paperpagestyle default \tracking_changes true \output_changes false -\author "" +\author "Amit

Hey Rusty, These updated patches in the series return -EFAULT on copy_xx_user errors and also move the copy_from_user into fops_write() instead of it being in send_buf. This enables send_buf to just read from kernel buffers, making it simpler. This also allows write()s to write more to the host in one go, removingthe 4k limitation. I do limit the writes to 32k at once to not put too much

Hey Rusty, These updated patches in the series return -EFAULT on copy_xx_user errors and also move the copy_from_user into fops_write() instead of it being in send_buf. This enables send_buf to just read from kernel buffers, making it simpler. This also allows write()s to write more to the host in one go, removingthe 4k limitation. I do limit the writes to 32k at once to not put too much

When removing a port we don't check if a program was blocked for read. This leads to a crash when SIGTERM is sent to the program after hot-unplugging the port. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c

When removing a port we don't check if a program was blocked for read. This leads to a crash when SIGTERM is sent to the program after hot-unplugging the port. Signed-off-by: Amit Shah <amit.shah at redhat.com> --- drivers/char/virtio_console.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c

Hello Rusty, To avoid sending the same patches again, this time I'm trying a git pull request. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/amit/vs-kernel.git for-rusty to get the patches that I've sent to the list previously, with a couple of fixes: - Create a console port when not using multiport (fix was sent as a reply to prev. series) - Add hunk that got

Hello Rusty, To avoid sending the same patches again, this time I'm trying a git pull request. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/amit/vs-kernel.git for-rusty to get the patches that I've sent to the list previously, with a couple of fixes: - Create a console port when not using multiport (fix was sent as a reply to prev. series) - Add hunk that got

Hey Rusty, Christian, Christoph Hellwig asked why we don't need a barrier before this code in virtcons_probe(): > + /* Start using the new console output. */ > + early_put_chars = NULL; > return 0; Since only s390 uses early_put_chars so far, you'd know why it's not needed / why we're safe. Thanks, Amit

Hey Rusty, Christian, Christoph Hellwig asked why we don't need a barrier before this code in virtcons_probe(): > + /* Start using the new console output. */ > + early_put_chars = NULL; > return 0; Since only s390 uses early_put_chars so far, you'd know why it's not needed / why we're safe. Thanks, Amit

If a port was open before going into one of the sleep states, the port can continue normal operation after restore. However, the host has to be told that the guest side of the connection is open to restore pre-suspend state. This wasn't noticed so far due to a bug in qemu that was fixed recently (which marked the guest-side connection as always open). CC: stable at vger.kernel.org # Only

If a port was open before going into one of the sleep states, the port can continue normal operation after restore. However, the host has to be told that the guest side of the connection is open to restore pre-suspend state. This wasn't noticed so far due to a bug in qemu that was fixed recently (which marked the guest-side connection as always open). CC: stable at vger.kernel.org # Only

A bug can be easily reproduced: Host# cat guest-agent.xml <channel type="unix"> <source mode="bind" path="/var/lib/libvirt/qemu/stretch.agent"/> <target type="virtio" name="org.qemu.guest_agent.0" state="connected"/> </channel> Host# virsh attach-device instance guest-agent.xml Host# virsh detach-device

On Sun, Apr 28, 2019 at 09:50:04AM +0800, zhenwei pi wrote: > A bug can be easily reproduced: > Host# cat guest-agent.xml > <channel type="unix"> > <source mode="bind" path="/var/lib/libvirt/qemu/stretch.agent"/> > <target type="virtio" name="org.qemu.guest_agent.0" state="connected"/> >

A bug can be easily reproduced: Host# cat guest-agent.xml <channel type="unix"> <source mode="bind" path="/var/lib/libvirt/qemu/stretch.agent"/> <target type="virtio" name="org.qemu.guest_agent.0" state="connected"/> </channel> Host# virsh attach-device instance guest-agent.xml Host# virsh detach-device

A bug can be easily reproduced: Host# cat guest-agent.xml <channel type="unix"> <source mode="bind" path="/var/lib/libvirt/qemu/stretch.agent"/> <target type="virtio" name="org.qemu.guest_agent.0" state="connected"/> </channel> Host# virsh attach-device instance guest-agent.xml Host# virsh detach-device