similar to: INDIRECT and NEXT

On Wed, Jul 11, 2018 at 10:27:09AM +0800, Tiwei Bie wrote: > This commit introduces the support (without EVENT_IDX) for > packed ring. > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > drivers/virtio/virtio_ring.c | 495 ++++++++++++++++++++++++++++++++++- > 1 file changed, 487 insertions(+), 8 deletions(-) > > diff --git

On Wed, Jul 11, 2018 at 10:27:09AM +0800, Tiwei Bie wrote: > This commit introduces the support (without EVENT_IDX) for > packed ring. > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > drivers/virtio/virtio_ring.c | 495 ++++++++++++++++++++++++++++++++++- > 1 file changed, 487 insertions(+), 8 deletions(-) > > diff --git

Currently if VIRTIO_RING_F_INDIRECT_DESC is enabled we will use indirect descriptors even if we have plenty of space in the ring. This means that we take a performance hit at all times due to the overhead of creating indirect descriptors. With this patch, we will use indirect descriptors only if we have less than either 16, or 12% of the total amount of descriptors available. I did basic

Currently if VIRTIO_RING_F_INDIRECT_DESC is enabled we will use indirect descriptors even if we have plenty of space in the ring. This means that we take a performance hit at all times due to the overhead of creating indirect descriptors. With this patch, we will use indirect descriptors only if we have less than either 16, or 12% of the total amount of descriptors available. I did basic

On Thu, 2007-07-19 at 23:13 +0300, S.?a?lar Onur wrote: > Hi; > > Remove -static from Documentation/lguest/Makefile, most distros only provides shared library form of zlib in their default installation. > And shared linking also provides litte tiny security for hypotetical security problems will be introduced by zlib :). Unfortunately, this introduces a security hole. See, the

On Thu, 2007-07-19 at 23:13 +0300, S.?a?lar Onur wrote: > Hi; > > Remove -static from Documentation/lguest/Makefile, most distros only provides shared library form of zlib in their default installation. > And shared linking also provides litte tiny security for hypotetical security problems will be introduced by zlib :). Unfortunately, this introduces a security hole. See, the

The netfilter code had very good documentation: the Netfilter Hacking HOWTO. Noone ever read it. So this time I'm trying something different, using a bit of Knuthiness. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- Documentation/lguest/extract | 58 +++++++++++++++++++++++++++++++++ Documentation/lguest/lguest.c | 9 +++-- drivers/lguest/Makefile

The netfilter code had very good documentation: the Netfilter Hacking HOWTO. Noone ever read it. So this time I'm trying something different, using a bit of Knuthiness. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- Documentation/lguest/extract | 58 +++++++++++++++++++++++++++++++++ Documentation/lguest/lguest.c | 9 +++-- drivers/lguest/Makefile

Add documentation for indirect descriptors Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- virtio-spec.lyx | 118 +++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 114 insertions(+), 4 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 8062e11..b5a8fbd 100644 --- a/virtio-spec.lyx +++ b/virtio-spec.lyx @@ -1,4 +1,4 @@ -#LyX 1.6.4 created

Add documentation for indirect descriptors Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- virtio-spec.lyx | 118 +++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 114 insertions(+), 4 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 8062e11..b5a8fbd 100644 --- a/virtio-spec.lyx +++ b/virtio-spec.lyx @@ -1,4 +1,4 @@ -#LyX 1.6.4 created

Il 03/09/2014 06:29, Rusty Russell ha scritto: > + desc = kmalloc(total_sg * sizeof(struct vring_desc), gfp); > + if (!desc) > + return NULL; > > - return head; > + for (i = 0; i < total_sg; i++) > + desc[i].next = i+1; > + return desc; > } Would it make sense to keep a cache of a few (say) 8- or 16-element indirect descriptors? You'd only have to do this

Il 03/09/2014 06:29, Rusty Russell ha scritto: > + desc = kmalloc(total_sg * sizeof(struct vring_desc), gfp); > + if (!desc) > + return NULL; > > - return head; > + for (i = 0; i < total_sg; i++) > + desc[i].next = i+1; > + return desc; > } Would it make sense to keep a cache of a few (say) 8- or 16-element indirect descriptors? You'd only have to do this

> -----Original Message----- > From: Michael S. Tsirkin [mailto:mst at redhat.com] > Sent: Tuesday, July 18, 2017 7:23 PM > To: Lior Narkis <liorn at mellanox.com> > Cc: virtio-dev at lists.oasis-open.org; virtualization at lists.linux-foundation.org > Subject: Re: [virtio-dev] packed ring layout proposal v2 > > On Sun, Jul 16, 2017 at 06:00:45AM +0000, Lior Narkis

> -----Original Message----- > From: Michael S. Tsirkin [mailto:mst at redhat.com] > Sent: Tuesday, July 18, 2017 7:23 PM > To: Lior Narkis <liorn at mellanox.com> > Cc: virtio-dev at lists.oasis-open.org; virtualization at lists.linux-foundation.org > Subject: Re: [virtio-dev] packed ring layout proposal v2 > > On Sun, Jul 16, 2017 at 06:00:45AM +0000, Lior Narkis

Hi Rusty, On Thu, 2008-12-18 at 17:10 +0000, Mark McLoughlin wrote: > Add a new feature flag for indirect ring entries. These are ring > entries which point to a table of buffer descriptors. > > The idea here is to increase the ring capacity by allowing a larger > effective ring size whereby the ring size dictates the number of > requests that may be outstanding, rather than

Hi Rusty, On Thu, 2008-12-18 at 17:10 +0000, Mark McLoughlin wrote: > Add a new feature flag for indirect ring entries. These are ring > entries which point to a table of buffer descriptors. > > The idea here is to increase the ring capacity by allowing a larger > effective ring size whereby the ring size dictates the number of > requests that may be outstanding, rather than

The netfilter code had very good documentation: the Netfilter Hacking HOWTO. Noone ever read it. So this time I'm trying something different, using a bit of Knuthiness. Start with drivers/lguest/README. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- Documentation/lguest/extract | 58 +++++++++++++++++++++++++++++++++ Documentation/lguest/lguest.c | 9

The netfilter code had very good documentation: the Netfilter Hacking HOWTO. Noone ever read it. So this time I'm trying something different, using a bit of Knuthiness. Start with drivers/lguest/README. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- Documentation/lguest/extract | 58 +++++++++++++++++++++++++++++++++ Documentation/lguest/lguest.c | 9

Thanks to Andrew for pointing these out. This patch moves the parvirtprobe section into .init.data: it's only used in very very early boot, and for similar reasons, puts lguest_maybe_init and lguest_memory_setup in init.text. As well as fixing some warnings, this frees up a tiny bit more memory. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> diff -r ecec388180b2

Thanks to Andrew for pointing these out. This patch moves the parvirtprobe section into .init.data: it's only used in very very early boot, and for similar reasons, puts lguest_maybe_init and lguest_memory_setup in init.text. As well as fixing some warnings, this frees up a tiny bit more memory. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> diff -r ecec388180b2