similar to: [PATCH] Reflow logic to make it easier to follow

- added lots of comments, discussed comments with ahuillet and refined comments - replaced two constants with MACROs - no changes to actual code diff --git a/src/nv_video.c b/src/nv_video.c index cf4f88d..d9ee700 100644 --- a/src/nv_video.c +++ b/src/nv_video.c @@ -25,6 +25,15 @@ #include "nv_include.h" #include "nv_dma.h" +/* +2046 is the maximum image size in one

http://bugs.freedesktop.org/show_bug.cgi?id=19860 Summary: xv texture adaptor kills X Product: xorg Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org ReportedBy:

in nv10_exa.c : check_texture does : if (w > 2046 || h > 2046) NOUVEAU_FALLBACK("picture too large, %dx%d\n", w, h); check_render_target does : if (w > 4096 || h > 4096) return FALSE; So we have different size limits for the source and the destination ? Another thing is that nv20 uses nv10_exa.c code, and the limit in

int i is accessed outside immediate scope so leave declaration at the highest common scope level: 1073: int ret, i; ... // Highest common scope ... 1193: if (newTTSize <= destination_buffer->size) { ... // Used in this scope ... 1248: } else { ... // Used in this scope ... 1316: }

Based on the original patch by Christoph Bumiller, but since it depends on kernel support patched I cannot push it yet. The changes are that I enable vblank by default, and offset takes OFFSET_HIGH/LOW instead of something relative to notifier_bo. Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com> --- diff --git a/man/nouveau.man b/man/nouveau.man index 7c72907..8765569

The 'w' argument to NVCopyNV12ColorPlanes is used to index into the source image. line_len is rounded up to 8 on NV50+, so if the source image (+ left offset) is not rounded to 8, NVCopyNV12ColorPlanes could read past the end of the array and crash X. This change can cause the last few horizontal pixels of dst to not be initialized, but they should be truncated by the renderer anyways.

Warning reported by gcc 8.2: nouveau_xv.c: In function ‘NVPutImage’: nouveau_xv.c:1369:7: warning: declaration of ‘ret’ shadows a previous local [-Wshadow] int ret = BadImplementation; ^~~ nouveau_xv.c:1073:6: note: shadowed declaration is here int ret, i; ^~~ Fixes: a50bba6 ("xv: misc cleanups") Cc: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Rhys Kidd

http://bugs.freedesktop.org/show_bug.cgi?id=12825 Summary: TvTime shows only the upper left corner (~ 1280x1024) in Randr1.2 Product: xorg Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau

Hi there, I got a problem when trying to read in a .cel file using ReadAffy(). R codes: require(affy) ReadAffy(filenames="CH1.CEL") It failed and I got the error, Error in read.celfile.header(as.character(filenames[[1]])) : Is CH1.CEL really a CEL file? tried reading as text, gzipped text, binary, gzipped binary, command console and gzipped command console formats Also, I tried

Hi All, I have been able to modify the x-axis to start at zero by adding xlow and xhigh parameters; that was pretty simple. I have been unable to find the location of the code that would turn off the information weighting of the box size (I have smaller randomized trials getting less weight than a much larger non-randomized trial). The function is forestplot() from rmeta. Thanks for any

http://bugs.freedesktop.org/show_bug.cgi?id=14168 Summary: endian bug on powerpc Product: xorg Version: unspecified Platform: PowerPC OS/Version: All Status: NEW Severity: normal Priority: medium Component: Driver/nouveau AssignedTo: nouveau at lists.freedesktop.org ReportedBy: obiwan at

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/nouveau_xv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/nouveau_xv.c b/src/nouveau_xv.c index 8eafcf0..567e30c 100644 --- a/src/nouveau_xv.c +++ b/src/nouveau_xv.c @@ -552,8 +552,11 @@ NVCopyNV12ColorPlanes(unsigned char *src1, unsigned char *src2, if (e) { unsigned short *vud = (unsigned

On 01/07/2013 12:51 PM, syslinux-bot for Matt Fleming wrote: > Commit-ID: 15a67011987c341814533ac4d8e23c9a72dc7605 > Gitweb: http://www.syslinux.org/commit/15a67011987c341814533ac4d8e23c9a72dc7605 > Author: Matt Fleming <matt.fleming at intel.com> > AuthorDate: Mon, 7 Jan 2013 14:42:16 +0000 > Committer: Matt Fleming <matt.fleming at intel.com> > CommitDate:

https://bugs.freedesktop.org/show_bug.cgi?id=63263 Priority: medium Bug ID: 63263 Assignee: nouveau at lists.freedesktop.org Summary: X server crash in nouveau_xv.c:NVPutImage (NVCopyNV12ColorPlanes) QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All)

Hi, I filed a bugreport (found the FAQ for bug reports later...I hope that the adjustments I made (tag -> downloadable, setting priority to trivial, uploading more detailed logfiles) are correct (if I missed something, please tell me). Now I'm kinda stuck...I tried to dig my way into wine and fix that problem myself but I've nearly none experience with c/c++ (I'm a good c#