similar to: [PATCH] sysprep: remove the data and log files of puppet

Help the OCaml compiler by expliciting Guestfs.guestfs as type for 'g' in some functions. --- get-kernel/get_kernel.ml | 2 +- sysprep/sysprep_operation_abrt_data.ml | 2 +- sysprep/sysprep_operation_bash_history.ml | 2 +- sysprep/sysprep_operation_ca_certificates.ml | 2 +- sysprep/sysprep_operation_crash_data.ml

On Wed, Feb 03, 2016 at 07:28:16PM +0100, Pino Toscano wrote: > Help the OCaml compiler by expliciting Guestfs.guestfs as type for 'g' > in some functions. Looks mechanical, ACK. Does Hindley-Milner type inference have problems here? I've not seen them in this case. Rich. > get-kernel/get_kernel.ml | 2 +- >

--- sysprep/sysprep_operation.mli | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sysprep/sysprep_operation.mli b/sysprep/sysprep_operation.mli index 61dde72..eb89db4 100644 --- a/sysprep/sysprep_operation.mli +++ b/sysprep/sysprep_operation.mli @@ -16,14 +16,16 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. *) -(** Structure used to describe sysprep

Remove the generated pam data in the guest. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- sysprep/Makefile.am | 2 ++ sysprep/sysprep_operation_pam_data.ml | 52 +++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 sysprep/sysprep_operation_pam_data.ml diff --git a/sysprep/Makefile.am b/sysprep/Makefile.am index

On Monday, 18 September 2017 18:39:40 CEST Richard W.M. Jones wrote: > dib/output_format_docker.mli | 19 + > dib/output_format_qcow2.mli | 19 + > dib/output_format_raw.mli | 19 + > dib/output_format_squashfs.mli | 19 + > dib/output_format_tar.mli | 19 + >

Remove the cache of package manager like yum and apt. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- sysprep/Makefile.am | 2 + sysprep/sysprep_operation_package_manager_cache.ml | 49 ++++++++++++++++++++ 2 files changed, 51 insertions(+) create mode 100644 sysprep/sysprep_operation_package_manager_cache.ml diff --git

Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> --- po/POTFILES-ml | 1 + sysprep/Makefile.am | 1 + sysprep/sysprep_operation_remove_path.ml | 53 ++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+) create mode 100644 sysprep/sysprep_operation_remove_path.ml diff --git a/po/POTFILES-ml b/po/POTFILES-ml index

Remove the db and log of sssd. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- sysprep/Makefile.am | 2 ++ sysprep/sysprep_operation_sssd_db_log.ml | 50 ++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+) create mode 100644 sysprep/sysprep_operation_sssd_db_log.ml diff --git a/sysprep/Makefile.am b/sysprep/Makefile.am index

We just remove the process accounting files previously without touch a empty file, this will cause psacct runs error. Restart the service can't help us create this file auto. couldn't open file '/var/account/pacct': No such file or directory Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- po/POTFILES-ml | 1 + sysprep/Makefile.am

Hi Rich, I tried to implement the logging feature, but I can't though compiling with this patch now, could you please give me some comments? The error message is below, --- ocamlfind ocamlopt -g -warn-error CDEFLMPSUVYZX -package unix -I ../src/.libs -I ../ocaml -c sysprep_operation.ml -o sysprep_operation.cmx File "sysprep_operation.ml", line 1, characters 0-1: Error: The

Don't pass these flags to dozens of functions. --- builder/builder.ml | 47 +++++++++-------- builder/cache.ml | 4 +- builder/cache.mli | 2 +- builder/cmdline.ml | 13 ++--- builder/downloader.ml | 14 +++-- builder/downloader.mli

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

This works reliably for me ... Rich.

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623

--- .gitignore | 3 + builder/Makefile.am | 3 + builder/builder.mli | 19 + builder/paths.mli | 28 ++ builder/utils.mli | 30 ++ common/mlstdutils/Makefile.am | 2 +

Remove the implemented features from TODO list. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- TODO | 3 --- 1 file changed, 3 deletions(-) diff --git a/TODO b/TODO index 93f8787..b2d53d7 100644 --- a/TODO +++ b/TODO @@ -377,15 +377,12 @@ virt-sysprep ideas ------------------ - other Spacewalk / RHN IDs (?) - - Kerberos keys - Puppet registration - Windows

Version 1 of the patch, for discussion, but not to be applied. It does work, but needs a lot more testing. This removes all the psychopathic gettextify cruft, and replaces it with a 99 line Makefile.am. A large win, I think. The third patch implements gettext support in the OCaml tools. The fourth patch is just for illustration. It shows the consequent changes to libguestfs.pot and the po

remove the automatically generated abrt data. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- po/POTFILES-ml | 1 + sysprep/Makefile.am | 2 ++ sysprep/sysprep_operation_abrt_data.ml | 47 ++++++++++++++++++++++++++++++++++ 3 files changed, 50 insertions(+) create mode 100644 sysprep/sysprep_operation_abrt_data.ml diff --git

Remove hostname from network interface configuration. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- po/POTFILES-ml | 1 + sysprep/Makefile.am | 1 + sysprep/sysprep_operation_net_hostname.ml | 58 +++++++++++++++++++++++++++++++ 3 files changed, 60 insertions(+) create mode 100644 sysprep/sysprep_operation_net_hostname.ml