similar to: [virt-tools-list] find0 in (perl) Sys::Guestfs

Per discussion on IRC, here are two changes to convert all TABs-as-indentation to spaces. The first one is the fully-automated conversion. However, note that the command mentioned uses a file (the .x-sc* one) that is added only in the following patch. The second patch adds rules to help keep things that way: Document and enforce the new spaces-only indentation policy. * cfg.mk

Currently any api which takes a FileIn or FileOut parameter is implicitly cancellable. This change make cancellable an explicit flag in anticipation of it being added to other apis. --- generator/generator_actions.ml | 53 ++++++++++++++++++++++++++------------- generator/generator_checks.ml | 3 +- generator/generator_types.ml | 1 + 3 files changed, 38 insertions(+), 19 deletions(-)

The visibility field in action replaces in_fish, in_docs and internal. The defined types are: VPublic: A public API. This is exported and documented in all language bindings, and in guestfish. VStateTest: A public API which queries the library state machine. It is exported and documented in all language bindings, but not guestfish. VBindTest: An internal API used only for testing

There is precisely one such function at the moment (guestfs_wait_ready). --- generator/GObject.ml | 6 +- generator/OCaml.ml | 7 +- generator/actions_core_deprecated.ml | 102 ++++++++++++++--------------- generator/actions_inspection_deprecated.ml | 2 +- generator/actions_properties_deprecated.ml | 12 ++-- generator/c.ml

One more after this, and "make syntax-check" will pass once more. >From 5c360133c0d4e09531d432abca0629798b87ff39 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 9 Nov 2009 15:14:53 +0100 Subject: [PATCH libguestfs] indent with spaces, not TABs * HACKING: Expand indentation TABs. * configure.ac: Likewise. * daemon/daemon.h: Likewise. *

It eases the debugging, instead of getting just the name of the struct returned. --- generator/c.ml | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/generator/c.ml b/generator/c.ml index 9af4529..7446412 100644 --- a/generator/c.ml +++ b/generator/c.ml @@ -1348,6 +1348,7 @@ and generate_client_actions hash () = #include

This type is initially identical to Device. --- generator/bindtests.ml | 2 +- generator/c.ml | 7 +++++-- generator/csharp.ml | 6 ++++-- generator/daemon.ml | 4 ++-- generator/erlang.ml | 6 +++--- generator/fish.ml | 8 ++++---- generator/gobject.ml | 11 ++++++----- generator/haskell.ml | 11 +++++++---- generator/java.ml | 10 +++++-----

Mostly like StringList (so it can used in current StringList parameters), but checking client- and daemon-side that the elements are file names. --- generator/bindtests.ml | 3 ++- generator/c.ml | 29 ++++++++++++++++++++++++----- generator/csharp.ml | 4 ++-- generator/daemon.ml | 20 ++++++++++++++++++-- generator/erlang.ml | 2 +- generator/fish.ml | 10

Mostly like StringList (so it can used in current StringList parameters), but checking client- and daemon-side that the elements are relative paths. --- generator/bindtests.ml | 3 ++- generator/c.ml | 29 ++++++++++++++++++++++++----- generator/csharp.ml | 4 ++-- generator/daemon.ml | 20 ++++++++++++++++++-- generator/erlang.ml | 2 +- generator/fish.ml |

Previously we had lots of types like String, Device, StringList, DeviceList, etc. where Device was just a String with magical properties (but only inside the daemon), and DeviceList was just a list of Device strings. Replace these with some simple top-level types: String StringList and move the magic into a subtype. The change is mechanical, for example: old

This two-part patch implements the 'hexedit' command described here: http://rwmj.wordpress.com/2010/09/18/new-feature-guestfish-hexedit/#content The first part implements two new APIs for partial writing and reading of files. These are modelled after guestfs_upload and guestfs_download but allow you to specify an offset and (for download only) a size: int guestfs_download_offset

Hello Richard, Ok, I'll give it a shot. Thanks! Jin A On Nov 25, 2013 4:19 PM, "Richard W.M. Jones" <rjones@redhat.com> wrote: > On Mon, Nov 25, 2013 at 04:12:40PM -0700, Jon wrote: > > Hello Richard, > > > > I'm using: > > > > >> virt-sysprep 1.25.6 > > > > I honestly don't remember if the currently installed

* Jon: > I'm having trouble connecting to rbd images. It seems like somewhere > the name is getting chewed up.  I wonder if this is related to my > previous troubles [1] [2] with rbd images. The "W: kvm binary is deprecated, please use qemu-system-x86_64 instead" message looks like the one I know from Debian. From the names of the kernel images, I'm guessing that

On Tue, Nov 26, 2013 at 03:59:49AM -0700, Jon wrote: > How do you normally deal with that warning? The warning is just that, so it doesn't really matter at the moment. However you can configure libguestfs like this if you want to use a particular binary: ./configure --with-qemu="qemu-system-x86_64" > I typically rename the kvm binary, then link qemu-system-x86_64 but >

On Thursday 25 February 2016 08:59:18 Richard W.M. Jones wrote: > It means you have to rerun `make -C perl clean ; make' every time you > add an API, and is useless anyway. > --- > generator/perl.ml | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/generator/perl.ml b/generator/perl.ml > index 5250ce1..f11477b 100644 > ---

Otherwise the man page cannot contain any non-7-bit-ASCII characters. The test error seen was: Wide character in print at /usr/share/perl5/vendor_perl/Test2/Formatter/TAP.pm line 112. t/910-pod.t ................ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests --- generator/perl.ml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/generator/perl.ml b/generator/perl.ml index

On Fri, Mar 31, 2017 at 10:32:22AM +0100, Richard W.M. Jones wrote: > Otherwise the man page cannot contain any non-7-bit-ASCII characters. > > The test error seen was: > > Wide character in print at /usr/share/perl5/vendor_perl/Test2/Formatter/TAP.pm line 112. > t/910-pod.t ................ > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/1 subtests Somehow I

On Mon, Nov 25, 2013 at 12:52:21PM -0700, Jon wrote: > Hello, > > I'm having trouble connecting to rbd images. It seems like somewhere the > name is getting chewed up. I wonder if this is related to my previous > troubles [1] [2] with rbd images. > > I'm trying to add an rbd image, but when I launch the guestfs object I get > an error: > > >>

If you have a struct containing ?field?, eg: type t = { field : int } then previously to pattern-match on this type, eg. in function parameters, you had to write: let f { field = field } = (* ... use field ... *) In OCaml >= 3.12 it is possible to abbreviate cases where the field being matched and the variable being bound have the same name, so now you can just write: let f {

Hello Richard, I'm using: >> virt-sysprep 1.25.6 I honestly don't remember if the currently installed version is from the tarball or pulled from the github source... Now that you mention it, I think it could even be the version with my "hack" to fix virt-sysprep... Which version are you building? I see there's a: >>