similar to: [PATCH] Do not run test-virt-format.sh if appliance has not been built

Here are some of the patches that I have maintained in the patch queue of my packages that I maintain within the Debian distribution (http://packages.qa.debian.org/libg/libguestfs.html). All of them address FTBFS (fail to build from source) errors that happened with the particular configuration that is used for building the Debian package. Cheers, -Hilko

Overwriting LD_LIBRARY_PATH broke some tests when running with fakeroot. --- align/Makefile.am | 2 +- cat/Makefile.am | 2 +- clone/Makefile.am | 2 +- df/Makefile.am | 2 +- edit/Makefile.am | 2 +- fish/Makefile.am | 2 +- haskell/Makefile.am | 2 +- ocaml/Makefile.am |

This takes advantage of glibc's MALLOC_PERTURB_. If you develop on glibc-based systems and don't yet set this via your shell's init scripts, add something like this to e.g., .bashrc: export MALLOC_PERTURB_=$(($RANDOM % 255 + 1)) This change ensures that it's enabled for anyone running "make check" and in particular for koji. There's probably documentation

Set LIBGUESTFS_PATH to the default value compiled into and output a warning to STDERR, instead. The previous behavior caused the build to abort when trying to build the sysprep documentation -- without much of a hint of what went wrong. When LIBGUESTFS_PATH was not set, test-events.sh would fail. --- run.in | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/run.in

Erik, I was thinking of doing this: export MALLOC_PERTURB_=$(awk 'BEGIN { srand(); print int(rand() * 32767 % 255 + 1) }') Or would you prefer using 'date'? On Tue, Mar 19, 2013 at 10:22 PM, Erik de Castro Lopo <mle+la at mega-nerd.com>wrote: > Jesse Weinstein wrote: > > > The subject line mostly says it all, but for reference, having #!/bin/sh > causes

In case the appliance is disabled at configure, then all the phony guests will not be built during the 'make check' time. Since the tests already handle an empty windows.vmdk fine (in case ntfs-3g is not available), then just create it empty in this case. Reported by: Martin Kletzander. --- v2v/Makefile.am | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/v2v/Makefile.am

That enables an special implementation that checks for common memory errors and will save us from a lot pain. --- test/test_bins.sh | 2 ++ test/test_flac.sh | 2 ++ test/test_grabbag.sh | 2 ++ test/test_libFLAC++.sh | 2 ++ test/test_libFLAC.sh | 3 +++ test/test_metaflac.sh | 2 ++ test/test_seeking.sh | 2 ++ test/test_streams.sh | 2 ++ 8 files

We use a similar trick to libvirt to allow external C programs that use libguestfs to be compiled against the built (but not installed) libguestfs with: ../libguestfs/run ./configure make What actually happens is we have a second pkg-config file (lib/local/libguestfs.pc) which points to the locally built libguestfs. The ./run script sets up PKG_CONFIG_PATH to point to this directory.

These changes allow virt-v2v to be compiled against the build directory of a non-installed libguestfs. Note that some small changes are also required to common and virt-v2v itself. I will post those separately. Rich.

We use a similar trick to libvirt and libguestfs to allow external C programs that use libnbd to be compiled against the built (but not installed) libnbd with: ../libnbd/run ./configure make What actually happens is we have a second pkg-config file (lib/local/libnbd.pc) which points to the locally built libnbd. The ./run script sets up PKG_CONFIG_PATH to point to this directory. Assuming

You have to use: ../libguestfs/run ./configure ../libguestfs/run make Use of the second ../libguestfs/run against make is unfortunate but I believe it's unavoidable due to the way that ocamlfind works. --- .gitignore | 1 + ocaml/Makefile.am | 19 ++++++++++++++++++- run.in | 2 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore

On 18/04/12 09:08, Erik de Castro Lopo wrote: > Cristian Rodr?guez wrote: > >> That enables an special implementation that checks >> for common memory errors and will save us from a lot pain. >> --- >> test/test_bins.sh | 2 ++ >> test/test_flac.sh | 2 ++ >> test/test_grabbag.sh | 2 ++ >> test/test_libFLAC++.sh | 2 ++

--- golang/Makefile.am | 7 ++++++- golang/src/libguestfs.org/guestfs/guestfs_100_launch_test.go | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/golang/Makefile.am b/golang/Makefile.am index a60c9ba..f59488e 100644 --- a/golang/Makefile.am +++ b/golang/Makefile.am @@ -37,6 +37,11 @@ EXTRA_DIST = \ if HAVE_GOLANG +GOFLAGS = +if

This is a cheap way to find some use-after-free and uninitialized read problems when using glibc. This in fact reveals a race during filter shutdown (which this commit does not fix): Thread 2 (Thread 0x7f1caaa5ffc0 (LWP 7223)): #0 0x00007f1cab0a05f8 in pthread_rwlock_wrlock () from /lib64/libpthread.so.0 #1 0x0000000000408842 in lock_unload () at locks.c:97 #2 0x00000000004066ff in

The previous behavior caused the build to abort when trying to build the sysprep documentation -- without much of a hint of what went wrong. --- run.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/run.in b/run.in index 7545f0b..9f92306 100755 --- a/run.in +++ b/run.in @@ -66,9 +66,10 @@ chcon --reference=/tmp tmp 2>/dev/null ||: if [ "x at

https://bugzilla.redhat.com/show_bug.cgi?id=701814

They will fail anyway in that case, so run them only when the FUSE support is built in. --- fish/Makefile.am | 6 +++++- sysprep/Makefile.am | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/fish/Makefile.am b/fish/Makefile.am index fc7c729..5ffa0f1 100644 --- a/fish/Makefile.am +++ b/fish/Makefile.am @@ -297,7 +297,6 @@ TESTS += \ test-find0.sh \ test-inspect.sh

This way they can be properly shipped also when creating a distribution tarball ('make dist') from a build configured with --disable-appliance. --- p2v/Makefile.am | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/p2v/Makefile.am b/p2v/Makefile.am index e0b194c29..4e2405e9d 100644 --- a/p2v/Makefile.am +++ b/p2v/Makefile.am @@ -25,7 +25,7 @@ BUILT_SOURCES = \

For these simple compile tests where we want to ensure that a basic external program could be compiled using libnbd, we shouldn't include <config.h>. This is because we want to test here that <libnbd.h> can stand alone, without needing anything defined by the GNU autotools infrastructure. Of course we can use <config.h> in other test programs where we aren't evaluating

This patch is incomplete but it illustrates the idea. virt-sysprep is rewritten as a modular tool in OCaml. Only the 'utmp' and 'hostname' operations are implemented at the moment. Rich.