similar to: [PATCH 1/3] daemon: pwrite/pread: Don't double close on error path.

This is a possibly better work-around for bug 769304, the bug where blkid runs from udev whenever a device closes, causing the subsequent operation to fail. For background to this change, see: https://rwmj.wordpress.com/2012/01/19/udev-unexpectedness/#content So far we have noticed this problem in two places (although I'm fairly certain it affects many more): - in virt-resize, after

From: "Richard W.M. Jones" <rjones at redhat.com> This reverts commit a9c8123c72db47bcab8dd738e8d5256a9ae87f11. --- daemon/file.c | 18 +++--------------- daemon/parted.c | 3 +-- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/daemon/file.c b/daemon/file.c index 057e15d..91746e0 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -525,7 +525,7 @@

‘file’ is a small, self-contained API which runs a single command, so it's a good test case for reimplementing APIs. --- daemon/Makefile.am | 2 ++ daemon/file.c | 80 ----------------------------------------------- daemon/file.ml | 60 +++++++++++++++++++++++++++++++++++ daemon/file.mli | 19 +++++++++++ generator/actions_core.ml | 1 + 5 files

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in some cases, the code comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva <gustavo at

Source: klibc Version: 2.0.2 Severity: important Tags: Patch On the hppa arch (32bit userspace and 32 or 64bit kernel), the fstype program fails to detect the filesystem. The reason for this failure is, that fstype calls the pread() syscall, which has on some architectures with 32bit userspace a different calling syntax. I noticed this bug on hppa, but I assume s390 (32bit) and others might run

Hi everyone, One of my teammates here at HP uncovered this, and I thought it deserved proactive mention on the list: It covers non-HP builds of Samba, so HP CIFS Server (HP's version of Samba bundled with all 11.0 and above OS'es) customers are not directly affected but those of you on the list who might build Samba yourselves on 11.11 could be affected. Customers building their own

If the plugin .pread method did not fill the buffer with data then the contents of the heap could be leaked back to the client. To avoid this create a thread-local data buffer which is initialized to zero and expanded (with zeroes) as required. This buffer is shared between pread and pwrite which makes the code a little bit simpler. Also this may improve locality by reusing the same memory for

Commit-ID: 75895304280f597f46551deb8b87c27ac18a013c Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=75895304280f597f46551deb8b87c27ac18a013c Author: Helge Deller <deller at gmx.de> AuthorDate: Wed, 6 Jan 2016 00:43:50 +0000 Committer: H. Peter Anvin <hpa at linux.intel.com> CommitDate: Tue, 5 Jan 2016 17:45:50 -0800 [klibc] Add pread and pwrite 32bit syscall

On 4/23/19 10:09 AM, Richard W.M. Jones wrote: > If the plugin .pread method did not fill the buffer with data then the > contents of the heap could be leaked back to the client. To avoid > this create a thread-local data buffer which is initialized to zero > and expanded (with zeroes) as required. > > This buffer is shared between pread and pwrite which makes the code a >

On Fri, Feb 15, 2019 at 11:08 AM Gustavo A. R. Silva <gustavo at embeddedor.com> wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in some cases, the code comment is modified > in accordance with what GCC is expecting to find.

This patch series is just FYI at the moment. However it does pass the tests. The daemon is a self-contained program. We don't need to write it all in C. Writing parts of it in OCaml would make it simpler and less error-prone. In particular if the daemon was written in a more sane programming language then we could move the inspection code to run entirely inside the appliance, which would

An HTML attachment was scrubbed... URL: <http://listman.redhat.com/archives/ext3-users/attachments/20060828/ce9c7bc0/attachment.htm>

I have downloaded what I think is the latest CVS sources using: cvs -d :pserver:cvs@pserver.samba.org:/cvsroot login cvs -d :pserver:cvs@pserver.samba.org:/cvsroot co samba Changed to the samba/source directory and done ./configure when I do a make i get: make: *** Warning: File `Makefile.in' has modification time in the future (2001-02-27 13:09:49 > 2001-02-27 07:20:20) WARNING: you

I''ve been using lvm under centos to create the backing store for domUs and although the performance seems acceptable it has some shortcomings. The biggest of which is the LVM bug which prevents me from removing an lv (it says it is still mounted and it definitely isnt). I thought this was just a centos bug but it appears to be evident in debian and ubuntu too and I really can''t

On Tue, Jan 13, 2015 at 10:27 PM, Sameer Sahasrabuddhe < sameer.sahasrabuddhe at amd.com> wrote: > Ping! We need to close on whether everyone is convinced that symbolic > memory scopes have a significant advantage over opaque numbers. Either of > them will be examined by optimizations using a target-implemented API. I > personally don't think that readability in the LLVM

Hi, I would like to figure out how to determine what the id of the last element in a table is. Is there an equivalent to the Table.find() method which will tell me the number of elements in a table? also, maybe more importantly, where are the available methods on tables documented? What i am trying to do is to increment the id and work through a table and check whether the id i am currently

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html -------------- next part -------------- >From d634c9780b55b6bb21bffc997e483e5b12491eb8 Mon Sep 17

This patch changes pwrite such that it will never return a short write. This is a backwards compatible API change, as checking for short writes remains correct, but redundant. --- daemon/file.c | 20 +++++++++++++------- src/generator.ml | 6 ------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/daemon/file.c b/daemon/file.c index da899b6..9ce0783 100644 ---

These two very simple patches add a pwrite-device API call. I have been conservative and not yet added the equivalent pread-device call, although that could be added in future. The motivation for this is in virt-resize: We need a way to zap the partition table cleanly[1], and obviously parted isn't working out for us[2]. Using this call we can zap MBR and GPT partition tables by overwriting

--- src/internal.h | 2 +- src/plugins.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/internal.h b/src/internal.h index d0c60f2..2617337 100644 --- a/src/internal.h +++ b/src/internal.h @@ -162,7 +162,7 @@ struct backend { int (*is_rotational) (struct backend *, struct connection *conn); int (*can_trim) (struct backend *, struct connection *conn); int