similar to: [PATCH v2 1/3] ext2: tweak the error returned message of resize2fs-M(BZ755729)

From: Wanlong Gao <gaowanlong at cn.fujitsu.com> Tweak the error message "e2fsck -f" and "e2fsck -fy". Indicate the user to use the correct and/or forceall options. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- daemon/ext2.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index

https://bugzilla.redhat.com/show_bug.cgi?id=755729 This bug reports that the error message printed by the resize2fs API calls (which comes directly from the resize2fs command) says: Please run 'e2fsck -f /dev/vda1' first. That command is not possible from guestfish (where it would be 'e2fsck-f' or 'e2fsck ... forceall:true'). Fixing that bug caused this bug:

Tweak the error message "e2fsck -f" and "e2fsck -fy" to "e2fsck-f" and "e2fsck-fy". Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- daemon/ext2.c | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index 79fd354..9fe938e 100644 --- a/daemon/ext2.c +++ b/daemon/ext2.c

e2fsck returns 1 in case of "file system errors corrected". We treat it as success in normal e2fsck, but fail if e2fsck is run by resize2fs. Change 'manual' execution of e2fsck to dedicated function call. --- daemon/ext2.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index 5dd67c7..95a65ae 100644 ---

This miscellaneous patch adds bindings for: - ntfsfix - ntfsclone - ntfslabel and unifies filesystem label setting through a single API 'set-label' which replaces 'set-e2label' and is also able to set labels on NTFS using the ntfslabel program. 'ntfsfix' has been added as a possible way to fix RHBZ#797760. However I have not found a way to fully fix this bug. See

Added support for getting ext2/3/4 filesystem minimum size. This is needed primarily for shrinking images. Difference to v1: added test, style fixes. --- daemon/ext2.c | 35 +++++++++++++++++++++++++++++++++++ generator/actions.ml | 14 ++++++++++++++ src/MAX_PROC_NR | 2 +- 3 files changed, 50 insertions(+), 1 deletion(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index

The changes since the previous patch: - safe ADD_ARG macro for adding arguments to a fixed size stack array - support for testing functions that return RHashtable, ie. tune2fs-l. - add tests that set (tune2fs) and get (tune2fs-l) various parameters. - only one 'intervalbetweenchecks' parameter (in seconds) Rich.

guestfsd calls many different tools. Keeping track of all of them is error prone. This patch introduces a new helper macro to put the command string into its own ELF section: GUESTFS_EXT_CMD(C_variable, command_name); This syntax makes it still possible to grep for used command names. The actual usage of the collected list could be like this: objcopy -j .guestfs_ext_cmds -O binary

fix the double free of err. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- daemon/ext2.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index 2cd3da3..5deff24 100644 --- a/daemon/ext2.c +++ b/daemon/ext2.c @@ -280,7 +280,6 @@ do_resize2fs_M (const char *device) r = command (NULL, &err, prog, "-M",

Added support for getting ext2/3/4 filesystem minimum size. This is needed primarily for shrinking images. --- daemon/ext2.c | 35 +++++++++++++++++++++++++++++++++++ generator/actions.ml | 10 ++++++++++ src/MAX_PROC_NR | 2 +- 3 files changed, 46 insertions(+), 1 deletion(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index ebaf0f0..3dae40f 100644 --- a/daemon/ext2.c +++

At the moment OpenStack uses kpartx and nbd to resize filesystems and inject files to guests. I sincerely hope they don't allow untrusted users to upload guest images / AMIs :-( To fix this I'm looking into adding libguestfs support as an optional backend in OpenStack. The only missing feature in libguestfs is the ability to call tune2fs on a filesystem. This patch series adds tune2fs

Use commandrvf() instead of commandvf() to execute e2fsck. A non-zero exit status does not always indicate a failure. Signed-off-by: Nikos Skalkotos <skalkoto@grnet.gr> --- daemon/ext2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/daemon/ext2.c b/daemon/ext2.c index 65ddae6..8ef6d5f 100644 --- a/daemon/ext2.c +++ b/daemon/ext2.c @@ -296,9 +296,9 @@ do_e2fsck

On Fri, Jan 14, 2011 at 04:07:39PM +0300, Nikita A Menkovich wrote: [...] Thanks, I have pushed a modified version of this patch upstream: http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=4ffa2d6798f7a2bf0baec8e1084659cf6358bc31 Rich. > diff --git a/daemon/ext2.c b/daemon/ext2.c > index 725352e..85ce316 100644 > --- a/daemon/ext2.c > +++ b/daemon/ext2.c > @@ -266,6

hi, just wanted to mention that using 1.36-rc1 fixes the following bug: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=144771 thanks to benjamin scott for the hint, and theodore ts'o for fixing. building a source and binary rpm with the provided spec file works flawlessly under fc3 (just had to remove -rc1 from the archive name and Version: in the spec file). if you are replying to

Hi all, Can I ask if zerofree or resize2fs could also be applicable to ext4? Guestfish help of these two commands indicates that they are applicable to ext2/3. But ext4 is not covered in the help. However, I have tested these two commands in my Fedora 12 laptop, and it seems that both commands work well with ext4. So I don't quite understand why the help of these two commands only mention

On Sat, Apr 19, 2014 at 05:42:12PM +0200, Patrik Horník wrote: > > Please confirm that this is fully correct solution (for my purpose, not > elegant clean way for official fix) and it has no negative consequences. It > seems that way but I did not analyze all code paths the fixed code is in. Yes, that's a fine solution. What I'll probably do is disable the check if

-------- Forwarded Message -------- Subject: Re: [Libguestfs] Question: running appliance commands over guest fs (resize2fs -P). Date: Tue, 15 Sep 2015 17:17:16 +0300 From: Maxim Perevedentsev <mperevedentsev@virtuozzo.com> To: Richard W.M. Jones <rjones@redhat.com> On 09/15/2015 04:57 PM, Richard W.M. Jones wrote: >> 2) More general, how to execute commands from

On Tue, Sep 15, 2015 at 04:31:46PM +0300, Maxim Perevedentsev wrote: > Hello everyone! > > I am working on resizing qcow2 images using virt-resize+liguestfs. If you're shrinking, I believe a better way to do this is to sparsify the image. > E.g. I when shrinking a partition, I have to resize filesystem using > resize2fs-size. The problem is that I cannot find out minimal >

On Tue, Sep 15, 2015 at 05:17:16PM +0300, Maxim Perevedentsev wrote: > On 09/15/2015 04:57 PM, Richard W.M. Jones wrote: > >>2) More general, how to execute commands from appliance but make > >>them run over image (which may not have anything but filesystem) - I > >>saw something like that in source. > >Not sure I understand the question? > > As I

On 09/15/2015 04:57 PM, Richard W.M. Jones wrote: > On Tue, Sep 15, 2015 at 04:31:46PM +0300, Maxim Perevedentsev wrote: >> Hello everyone! >> >> I am working on resizing qcow2 images using virt-resize+liguestfs. > If you're shrinking, I believe a better way to do this is to sparsify > the image. And how would it help? If I shrink, a want a VM to occupy less maximum