similar to: [PATCH] build: Fix automake warnings

Overwriting LD_LIBRARY_PATH broke some tests when running with fakeroot. --- align/Makefile.am | 2 +- cat/Makefile.am | 2 +- clone/Makefile.am | 2 +- df/Makefile.am | 2 +- edit/Makefile.am | 2 +- fish/Makefile.am | 2 +- haskell/Makefile.am | 2 +- ocaml/Makefile.am |

--- builder/Makefile.am | 18 +++++++++++++- configure.ac | 2 ++ mllib/Makefile.am | 60 +++++++++++++++++++++++++++++++--------------- ocaml/Makefile.am | 28 +++++++++++++++------- ocaml/examples/Makefile.am | 13 ++++++++++ resize/Makefile.am | 18 +++++++++++++- sparsify/Makefile.am | 18 +++++++++++++- sysprep/Makefile.am | 18

For convenience you can pull it from the 'build' branch in: git://heisenbug.com/matthew/libguestfs.git Matt

version 2: - Fixed handling of clean & distclean. - Use 'all-local' instead of 'all'. - Don't use abs_* paths in Build.PL.in. Rich.

Switch from 'ExtUtils::MakeMaker' to 'Module::Build'. There's not really a huge difference here. The interfacing gymnastics that we have to do to make Makefile.am and Module::Build talk to each other is probably a little bit simpler. I compared the output of 'make install' before and after, and there's not much difference. 'perllocal.pod' is not

Automating the master build from scratch requires some annoying hassles thanks to 1ea1646e6f224dbc5b3922bb3c65aab4d71a9cb9. This can be worked around by running the requisite commands first, i.e., rm -f po-docs/podfiles && make -C po-docs update-po && make But after that, there still appears to be a race in the po-docs build (reproduced on -j12 on an E5-1650 v2):

version 3: - Split requires into configure_requires/etc. - Use lists for extra_compiler_flags, extra_linker_flags. - Suppress .packlist file. - Set the release_status field. Rich.

* Richard W.M. Jones: > On Fri, Feb 28, 2014 at 02:35:56PM +0100, Hilko Bengen wrote: >> diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am >> index 5dd2c9b..708b2e7 100644 >> --- a/ocaml/Makefile.am >> +++ b/ocaml/Makefile.am > [...] >> +# Tell version 3.79 and up of GNU make to not build goals in this >> +# directory in parallel. >> +.NOTPARALLEL:

Remaining issue: The C file that is generated from XS is still built in the source directory --- configure.ac | 1 + perl/Makefile.PL.in | 2 +- perl/Makefile.am | 16 ++++++++++++---- perl/run-perl-tests | 21 --------------------- perl/run-perl-tests.in | 21 +++++++++++++++++++++ 5 files changed, 35 insertions(+), 26 deletions(-) delete mode 100755

Instead of hardcoding "make" in run-perl-tests, pass the actual name of make from the Makefile; the default is still "make", mostly to use the script without having to set $MAKE. --- perl/Makefile.am | 4 +++- perl/run-perl-tests | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/perl/Makefile.am b/perl/Makefile.am index a0ae863..4632719 100644 ---

* Richard W.M. Jones: > (1) Removing .NOTPARALLEL. This fails, as expected. > > (2) mlguestfs.cmxa: mlguestfs.cma -- fails > > (3) mlguestfs.cmxa: | mlguestfs.cma -- fails after a longer time I find it strange that (2) and (3) fail. > (4) The attached patch which is derived from dce94f -- this ran > without failing for 120 iterations (and still going). The patch looks

Here are some of the patches that I have maintained in the patch queue of my packages that I maintain within the Debian distribution (http://packages.qa.debian.org/libg/libguestfs.html). All of them address FTBFS (fail to build from source) errors that happened with the particular configuration that is used for building the Debian package. Cheers, -Hilko

* Richard W.M. Jones: >> I think that an extra target (mlguestfs.cmxa: mlguestfs.cma) would make >> the .NOTPARALLEL unnecessary. > > Right, I remember this was a problem now. > > It was fixed by: > > https://github.com/libguestfs/libguestfs/commit/dce94f3e266ed3f1fc634a1ef6953f2db1510963 > > Do you think we could re-add the stamp-file / touch $@ ? Sure, it

This reverts commit 4ea016dae96ed4fc3ca6d057f17fde9697f0e627. --- .gitignore | 1 - configure.ac | 2 -- perl/Makefile.PL.in | 6 +++--- perl/Makefile.am | 14 ++------------ perl/run-perl-tests | 21 +++++++++++++++++++++ perl/run-perl-tests.in | 21 --------------------- run.in | 4 ++-- 7 files changed, 28 insertions(+), 41

--- perl/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/perl/Makefile.am b/perl/Makefile.am index 7b8f5d3..1eb0469 100644 --- a/perl/Makefile.am +++ b/perl/Makefile.am @@ -67,6 +67,7 @@ all: Makefile-pl src_deps $(MAKE) -f Makefile-pl Makefile-pl: Makefile.PL + -[ $(srcdir) != $(builddir) ] && cp -rsu $(abs_srcdir)/. $(builddir)/. perl Makefile.PL

Because this 'feature' is broken (since 2013): https://debbugs.gnu.org/cgi/bugreport.cgi?bug=13928 we have to replace all instances of $(top_srcdir) in *_SOURCES lines with a relative path. According to what I read, this shouldn't break split builds, but I didn't test it. The only things automake moans about now are: * Unescaped left brace in regex is deprecated, passed

Without this change all the tests in the haskell bindings are rebuilt every time. The primary motivation for this change is to fix this. The fix for the above also allows parallel builds to be re-enabled. --- haskell/Makefile.am | 56 +++++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 41 insertions(+), 15 deletions(-) diff --git a/haskell/Makefile.am b/haskell/Makefile.am

Here are two more patches that I had missed before.

Signed-off-by: Doug Goldstein <cardoe at gentoo.org> --- Makefile.am | 2 +- configure.ac | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: fee51bc27d60c7ec9d0371af88a476a232d9a8bd.diff Type: text/x-patch Size: 761 bytes Desc: not available Url :

From: "Richard W.M. Jones" <rjones at redhat.com> Earlier versions of automake complain if they get a configuration parameter which they don't understand. The error is: configure.ac:27: error: option 'serial-tests' not recognized Use some m4 hackery to work around this. --- configure.ac | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff