similar to: Seeking in large files

No #if. On May 12, 2014 6:26:18 PM PDT, Kang Kai <Kai.Kang at windriver.com> wrote: >On 2014?05?12? 22:38, H. Peter Anvin wrote: >> That is because it needs to use fseeko() and use off_t. > >Do you mean it does need a patch for isohybrid.c. And the patch looks >like: > >#if _FILE_OFFSET_BITS == 64 > fseeko(...) >#else > fseek(...) > >

> This is an older issue reported in 2007: > http://lists.xiph.org/pipermail/flac-dev/2007-September/002423.html > > The fix would be to use _ftelli64 instead of ftell with Visual Studio. > http://msdn.microsoft.com/en-us/library/0ys3hc0b%28v=vs.110%29.aspx That's not enough. At least, the followings are also needed. 1. Change off_t to something else. off_t can lead to ABI

On 2014?05?12? 22:38, H. Peter Anvin wrote: > That is because it needs to use fseeko() and use off_t. Do you mean it does need a patch for isohybrid.c. And the patch looks like: #if _FILE_OFFSET_BITS == 64 fseeko(...) #else fseek(...) Regards, Kai > > On May 11, 2014 11:53:17 PM PDT, Kang Kai <Kai.Kang at windriver.com> wrote: >> On 2014?05?12? 10:49, H. Peter

It seems unwise to offer future programmers fseek(3) calls for copy+paste. They are simply insufficient for large image files. This change switches all calls of fseek(3) to fseeko(3) and takes care that the offset value if of type off_t. --- utils/isohybrid.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/utils/isohybrid.c b/utils/isohybrid.c index

Hi, Ady: > > > http://www.syslinux.org/archives/2014-June/022259.html me: > > Already reported in may and diagnosed by hpa: > > http://www.syslinux.org/archives/2014-May/022041.html: > > > The right thing to do is compile it with #define _FILE_OFFSET_BITS 64 > > > and change fseek to fseeko with the appropriate type being off_t. Ady: > This has been

On 03/04/2013 10:57 PM, nu774 wrote: >> This is an older issue reported in 2007: >> http://lists.xiph.org/pipermail/flac-dev/2007-September/002423.html >> >> The fix would be to use _ftelli64 instead of ftell with Visual Studio. >> http://msdn.microsoft.com/en-us/library/0ys3hc0b%28v=vs.110%29.aspx > > That's not enough. At least, the followings are also

That is because it needs to use fseeko() and use off_t. On May 11, 2014 11:53:17 PM PDT, Kang Kai <Kai.Kang at windriver.com> wrote: >On 2014?05?12? 10:49, H. Peter Anvin wrote: >> On 05/11/2014 06:56 PM, Kai Kang wrote: >>> When call isohybrid with option '-u', it overflows on a 32 bits >host. It >>> seeks to 512 bytes before the end of the image to

Full_Name: John Brzustowski Version: R-devel-trunk, R-2.4.0 OS: linux Submission from: (NULL) (206.248.132.197) DESCRIPTION seek() on files larger than 2 gigabytes fails for large values of "where" on i386 linux 2.6.13 (and presumably other 32-bit unix-like platforms). e.g.: > f<-file("3gigabytefile.dat", "rb") > seek(f, 3e9, "start",

Hi, Geert Stappers > You will see the recent commits, including the 'fseek' to 'fseeko' change. I was looking at http://git.kernel.org/cgit/boot/syslinux/syslinux.git which is what Google brings up on "syslinux git" and looks quite official. Now i wonder about +#define _FILE_OFFSET_BITS 64 after it was already done in Makefile some time earlier. Luckily,

Great. I need to correct my statement, the check for _MSC_VER <= 1600 was the culprit, like this case: #if defined _MSC_VER || defined __BORLANDC__ || defined __MINGW32__ #include <sys/types.h> /* for off_t */ #if _MSC_VER <= 1600 || defined __BORLANDC__ /* @@@ [2G limit] */ #ifndef fseeko #define fseeko fseek #ifndef fseeko #define fseeko fseek #endif #endif Cheers, Cristian. On

This should be enough to fix it > Great. > > I need to correct my statement, the check for _MSC_VER <= 1600 > was the culprit, like this case: > > #if defined _MSC_VER || defined __BORLANDC__ || defined __MINGW32__ > #include <sys/types.h> /* for off_t */ > #if _MSC_VER <= 1600 || defined __BORLANDC__ /* @@@ [2G limit] */ > #ifndef fseeko > #define fseeko

1. Add support for files >2GB via Paul Eggert's AC_SYS_LARGEFILE macro. This macro is now part of autoconf 2.50. Because of this, "config.h" needs to be included before system headers to get the appropriate defines for LFS support. openbsd-compat/sigact.c configure.in acinclude.m4 2. AIX defines TILDE in <sys/ioctl.h>. Rename to TILDE_CHAR. Feel

On 2014?05?12? 10:49, H. Peter Anvin wrote: > On 05/11/2014 06:56 PM, Kai Kang wrote: >> When call isohybrid with option '-u', it overflows on a 32 bits host. It >> seeks to 512 bytes before the end of the image to install gpt header. If >> the size of image is larger than LONG_MAX, it overflows fseek() and >> cause error: >> >> isohybrid:

Hi, hpa: > The right thing to do is compile it with #define _FILE_OFFSET_BITS 64 > and change fseek to fseeko with the appropriate type being off_t. And for GPT names it should really use 16-bit UTF-16LE characters and not 8-bit characters padded up by the same number of random bytes from the program memory. See e.g.:

On 05/11/2014 06:56 PM, Kai Kang wrote: > When call isohybrid with option '-u', it overflows on a 32 bits host. It > seeks to 512 bytes before the end of the image to install gpt header. If > the size of image is larger than LONG_MAX, it overflows fseek() and > cause error: > > isohybrid: wrlinux-image-x86-64-20140505110100.iso: seek error - 8: Invalid argument >

Hi, > All the "isohybrid.exe" I know of are based on the Perl variant. I just got one from http://www.filewatcher.com/m/isohybrid.exe.39568-0.html Its strings seem not to stem from isohybrid.pl. Digging in slitaz source brought a shell script (that would be variant #5 then): http://hg.slitaz.org/wok/file/313b384e2a06/syslinux/stuff/tools/isohybrid.sh But isohybrid.exe must

Hello Recently while playing with bigger iso images (>2G) looks like isohybrid from syslinux-4.02 fails. Sometimes tunning heads/sectors (-h/-s) works, because no padding is needed depending of size of the image. Some debug info provided, if more info is needed please just ask. # isohybrid -v pandereta-2010.09.13-i686.iso catalogue offset: 326 ve[0]: 1, cs: 1 ve[1]: 0, cs: 1 ve[2]: 25927,

Hi all, I tried 1.3.0pre4 with ICL on Windows and found some issues. Not sure if this is the right place to submit patches, but someone suggested this on the apparently dead SourceForge patch tracker. The first two are quite straight forward: - The ICL patch fixes a typo in bitmath.h and adds FLAC__bitwriter_write_zeroes to the external declarations in bitwriter.c. - The Ogg patch replaces

__USE_LARGEFILE is a standard Unix way to allow > 2Gb files on 32-bit OSes by using f{seek,tell}o Take a look at the definition of f_tell: #if defined(HAVE_OFF_T) && defined(__USE_LARGEFILE) #define f_seek fseeko #define f_tell ftello #else #ifdef Win32 #define f_seek fseeko64 #define f_tell ftello64 #else #define f_seek fseek #define f_tell ftell #endif #endif Windows support for

Hi, This patch addresses the following issue: [Problem] MinGW build of flac command fails to parse piped WAV input with WAVEFORMATEXTENSIBLE format. [Description] This is because MinGW fseeko() doesn't return error for the attempt to seek on non seekable file (same behavior as MSVC). The simplest solution would be to change #ifdef _MSC_VER to #ifdef _WIN32 here. Instead, this patch tests