similar to: [PATCH] libguestfs: Added gnulib includes from builddir, as suggested by the Gnulib documentation

Since some modules (`getopt', for example) may copy files into the build directory, `top_builddir/lib' is needed as well as `top_srcdir/lib'. -- GNU Gnulib manual, section 2.2 Initial import This fixes an in-tree build failure on a Debian/sid system (see below). hivexml could be built out-of-tree, but it turned out that due to a missing include path, in this case the

Here's a patch series to make libguestfs use gnulib via a git submodule. The first thing I did was to look at the failures from "make syntax-check" and fix the config.h-related ones below. The others are now temporarily disabled via a variable in cfg.mk. I fixed the config-h problems and moved those change sets to precede the test-adding one, so that bisection still works, even if

--- capitests/Makefile.am | 4 ++- capitests/check-noexec-stack.pl | 58 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+), 1 deletions(-) create mode 100755 capitests/check-noexec-stack.pl diff --git a/capitests/Makefile.am b/capitests/Makefile.am index 71928ec..08466ac 100644 --- a/capitests/Makefile.am +++ b/capitests/Makefile.am @@ -22,13 +22,15 @@

Here are four small patches. First, I enabled all the warnings, then I fixed the newly exposed offenses, then I put the warning-enabling patch at the end, for the sake of future bisectors: [1/4] ocaml/guestfs_c.c avoid signed/unsigned-comparison warning [2/4] ocaml/guestfs_c.c: avoid warning about initialization discarding "const" [3/4] ocaml/guestfs_c.c: avoid warning about missing

There's a new syntax check rule from gnulib. It requires that you write e.g., exit (EXIT_SUCCESS), not exit (0). And the same for 1/EXIT_FAILURE and any other constants. There were a lot of violations, including a few false positives, so I started with the exemptions (see the .x-sc file below). Then I converted the vast majority automatically, with this: maint: use EXIT_SUCCESS and

gnulib's error.c requires program_name to be externally defined for !_LIBC systems. This defines program_name for Darwin only. --- configure.ac | 3 +++ src/Makefile.am | 6 ++++++ src/program_name.c | 4 ++++ 3 files changed, 13 insertions(+) create mode 100644 src/program_name.c diff --git a/configure.ac b/configure.ac index 37850a3..a2fb99e 100644 --- a/configure.ac +++

This change adds an explicit dependency on generator.ml for every file it generates, except java files. Java is left for another time because it's considerably trickier. This fixes parallel make, and will automatically re-create generated files when make is run from any directory. It also fixes the problem which efad4f53 was targetting. Specifically, src/guestfs_protocol.(c|h) had an

glibc in Fedora is currently configured with `--enable-obsolete-rpc', so I guess we can see the way the wind is blowing. (1) This changes our configure script to prefer libtirpc if it is available. If libtirpc is _not_ available then: (a) Headers must be located in <rpc/xdr.h>, or the user must supply the right CFLAGS. (b) XDR functions must be located in one of -lportablexdr, -lrpc,

Hello-- I've been trying to build libguestfs 1.2.14 with the appliance enabled on an older type of system at my company. Getting all the required dependencies installed has been an arduous process, but I've finally hit an obstacle I don't know how to get around. The final output of "make": + febootstrap-run initramfs -- /sbin/depmod -a ABOUT-NLS BUGS COPYING COPYING.LIB

I think this patch is required for "make check": diff --git a/Makefile.am b/Makefile.am index e5ca43c..258cebe 100644 --- a/Makefile.am +++ b/Makefile.am @@ -15,7 +15,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -ACLOCAL_AMFLAGS = -I m4 +ACLOCAL_AMFLAGS = -I m4 -I gnulib/m4 SUBDIRS = gnulib/lib src

I'm going to rename some test directories to make the names more logical: * caution -> tests/qemu This directory contains tests of qemu (safety and liveness). 'make check' will be changed so that this directory is tested first. At present, 'make check' happens to build images/ first which makes it harder to track down qemu breakage. * capitests -> tests/c-api

Just code motion. This commit makes it clearer what is a utility and what is part of the library. It also makes it clear that we should rename: guestfs-internal-frontend.h -> utils.h guestfs-internal-frontend-cleanups.h -> cleanups.h (?) but this commit does not make that change. --- .gitignore | 10 ++--- Makefile.am

Use CLEANFILES to remove the generated symlinks, and just ignore the errors when copying the scripts in srcdir!=builddir situations. Followup of commit 40ac54829d4e71b1bac76343872a2674a40c7ac0. --- bash/Makefile.am | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bash/Makefile.am b/bash/Makefile.am index 780da64..ee9c10c 100644 --- a/bash/Makefile.am +++

--- builder/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index a0d139b..29f7556 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -309,7 +309,7 @@ CLEANFILES += \ if HAVE_OCAML # Automake-generated makefile has a rule ".y.c" but lacks a rule ".y.h". index-parse.h: index-parse.y - touch

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 188bed76f..1ab54500d 100644 --- a/configure.ac +++ b/configure.ac @@ -94,7 +94,7 @@ dnl Find the release date for this version. This is used in dnl the website 'index.html' file. We have to do this after dnl testing for awk in guestfs_progs.m4 above.

On Tue, Jan 14, 2020 at 12:04:49AM +0100, Hilko Bengen wrote: > This avoids build failures in separate builds such as this one: > > ,---- > | ocamlfind ocamlc -package str,unix -I . -a guestfs_config.cmo stringMap.cmo stringSet.cmo std_utils.cmo -o mlstdutils.cma > | ar cr libmlstdutils.a libmlstdutils_a-dummy.o > | ranlib libmlstdutils.a > | File "_none_", line 1:

On Tuesday, 14 January 2020 00:04:49 CET Hilko Bengen wrote: > This avoids build failures in separate builds such as this one: > > ,---- > | ocamlfind ocamlc -package str,unix -I . -a guestfs_config.cmo stringMap.cmo stringSet.cmo std_utils.cmo -o mlstdutils.cma > | ar cr libmlstdutils.a libmlstdutils_a-dummy.o > | ranlib libmlstdutils.a > | File "_none_", line 1:

* Pino Toscano: > I do not think this is the correct approach. See my analysis here: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946594#46 This issue is for a different problem that appeared on some architectures after I forced *config.ml to be regenerated for the Debian builds of libguestfs 1.40.2, see

Hi. The small patch below fixes the building of 'mkrounding.o' when the build directory is outside the source directory. Art Haas Index: Makefile.in =================================================================== RCS file: /cvsroot/rsync/Makefile.in,v retrieving revision 1.128 diff -u -r1.128 Makefile.in --- Makefile.in 17 Dec 2006 00:40:18 -0000 1.128 +++ Makefile.in 27 Dec 2006

This patch series implements user cancellation. What this means is that the "user" (or any library caller) can cancel certain long-running operations. Currently it is only possible to cancel upload and download operations (ie. anything in the generator which uses FileIn and FileOut). The mechanism in the protocol to implement cancellation already exists, and it is already used to