similar to: [PATCH] Improve zeroing and detection of zeroes.

On Thu, Mar 17, 2016 at 12:25:18PM +0100, Pino Toscano wrote: > In case /usr is a symlink to /usr/bin, then we cannot rely on /usr/bin > to exist, since /usr might be in a different partition. Thus, in case > /bin is a symlink, check it points to "usr/bin". > --- > src/inspect-fs.c | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) >

On Tue, Apr 10, 2018 at 03:25:47PM +0000, Nir Soffer wrote: > On Tue, Apr 10, 2018 at 5:50 PM Richard W.M. Jones <rjones@redhat.com> > wrote: > > > On Tue, Apr 10, 2018 at 02:07:33PM +0000, Nir Soffer wrote: > > > This makes sense if the device is backed by a block device on oVirt side, > > > and the NBD support efficient zeroing. But in this case the device

On Mon, Nov 18, 2019 at 12:15 PM Richard W.M. Jones <rjones@redhat.com> wrote: > > > I've pushed a few commits which fix various aspects of the build and > may improve things for you: With current master building virt-v2v succeeds, thanks! I think we still have an issue with new checkout, having to delete common/ and update the submodule. > commit

I've pushed a few commits which fix various aspects of the build and may improve things for you: commit d5ce9c91469d3d384aa32735453a1f8a20d4ec25 Author: Richard W.M. Jones <rjones@redhat.com> Date: Mon Nov 18 10:11:57 2019 +0000 tests: Add TESTS_ENVIRONMENT in a couple of makefiles. We were accidentally testing the installed virt-v2v rather than the locally built

On Tue, Jan 24, 2017 at 08:51:05AM -0600, Eric Blake wrote: > On 01/24/2017 05:38 AM, Richard W.M. Jones wrote: > > On Mon, Jan 23, 2017 at 09:13:23PM -0600, Eric Blake wrote: > >> Begin the language binding followups to my new .zero callback, since > >> Rich was indeed correct that we want them. > >> > >> I'm more familiar with python and perl (at

Rich, I've followed your instructions to trace, but I am not very skilful with gdb, maybe I made a mistake : (1) As root do: echo core.%p > /proc/sys/kernel/core_pattern -> OK (2) Before running virt-v2v, do: ulimited -c unlimited -> I think it's ulimit -c unlimited -> -> OK and you should get a core.* file in the current directory when qemu-img

On Thu, Jul 21, 2016 at 07:31:51PM +0800, Chen Hanxiao wrote: > At 2016-07-21 19:04:07, "Richard W.M. Jones" <rjones@redhat.com> wrote: > >On Thu, Jul 21, 2016 at 06:50:52PM +0800, Chen Hanxiao wrote: > >> > >> > >> At 2016-07-21 18:43:04, "Richard W.M. Jones" <rjones@redhat.com> wrote: > >> >On Thu, Jul 21, 2016 at

On Thu, Aug 02, 2018 at 10:05:28PM +0300, Nir Soffer wrote: > File systems not supporting FALLOC_FL_ZERO_RANGE yet fall back to manual > zeroing. > > We can avoid this by combining two fallocate calls: > > fallocate(FALLOC_FL_PUNHCH_HOLE) "PUNCH" > fallocate(0) > +#ifdef FALLOC_FL_PUNCH_HOLE > + /* If we can punch hole but may not trim, we can

On Wed, Mar 22, 2017 at 05:16:34PM +0100, Pino Toscano wrote: > Check for a "product.id" file in an architecture-specific subdirectory > of the main partition, and use its data to improve the data on the > media. > > Only Mageia as distribution name is recognized there, since most > probably this file will not be available on other distros. > --- >

On Wed, Jun 10, 2015 at 06:47:44PM +0200, Pino Toscano wrote: > index e2ee1b5..eebab53 100644 > --- a/src/guestfs.pod > +++ b/src/guestfs.pod > @@ -3540,6 +3540,30 @@ Finally, the child process sends asynchronous messages back to the > main program, such as kernel log messages. You can register a > callback to receive these messages. > > +=head1 FIXED APPLIANCE > +

On Tue, Dec 12, 2017 at 2:13 PM, Richard W.M. Jones <rjones@redhat.com> wrote: > On Thu, Nov 23, 2017 at 02:05:32PM +0000, Richard W.M. Jones wrote: > > On Thu, Nov 23, 2017 at 03:00:45PM +0200, Yaniv Kaul wrote: > > > On Thu, Nov 23, 2017 at 10:57 AM, Richard W.M. Jones < > rjones@redhat.com> > > > wrote: > > > > > > > On Tue, Nov

I agree we should only be zeroing this buffer on NBD_CMD_READ, so the patch is wrong as it stands. Having an "I promise not to be bad!" flag I think just adds more complexity to plugins. It would be nice to do the best thing automatically. If we have a per-thread buffer then we're still (potentially) leaking data between clients, even if that data only consists of previously read

On Tue, Nov 13, 2018 at 03:17:33PM +0200, Peter Dimitrov wrote: > I was extending the virt plugin. > It already collects similar data (about VMs) using Libvirt's API, but lacks > disk usage information. > > I went through some hoops to link libguestfs correctly to collectd. > Is it okay to just include fork(), waitpid() example? It does reproduce the > issue. Yes, I

Hello Richard, I'm using: >> virt-sysprep 1.25.6 I honestly don't remember if the currently installed version is from the tarball or pulled from the github source... Now that you mention it, I think it could even be the version with my "hack" to fix virt-sysprep... Which version are you building? I see there's a: >>

FYI, I just posted two pull requests on libguestfs/supermin One adds urpmi support. The other adds xz support to supermin. On Fri, Aug 16, 2013 at 3:58 PM, Richard W.M. Jones <rjones at redhat.com>wrote: > On Fri, Aug 16, 2013 at 02:07:40PM +0800, Joseph Wang wrote: > > /etc/rc.d/init.d is required but the problem is the /etc/init.d symlink, > > which doesn't seem to

Killall does nothing the process is still alive... If I do kill -9, do I get a core dump ? Each time I got this hang, I find only umount -f /tmp/xxxx to force qemu-img to stop. Alain -----Message d'origine----- De : Richard W.M. Jones [mailto:rjones@redhat.com] Envoyé : mercredi 15 octobre 2014 14:41 À : VONDRA Alain Cc : libguestfs@redhat.com Objet : Re: [Libguestfs] Virt-v2v conversion

On Tue, Sep 24, 2019 at 05:24:34PM -0500, Eric Blake wrote: > On 9/24/19 4:07 PM, Richard W.M. Jones wrote: > > /* New-style handshake server reply when using NBD_OPT_EXPORT_NAME. > > * Modern clients use NBD_OPT_GO instead of this. > > @@ -167,7 +167,7 @@ struct nbd_new_handshake_finish { > > uint64_t exportsize; > > uint16_t eflags; /*

THINK YOU! I'm from China! but,my network is can &nbsp;reaching http://builder.libguestfs.org/ ------------------&nbsp;原始邮件&nbsp;------------------ 发件人:&nbsp;"rjones"<rjones@redhat.com&gt;; 发送时间:&nbsp;2020年6月23日(星期二) 晚上6:37 收件人:&nbsp;"雁渡寒潭"<chnlcq@qq.com&gt;;"libguestfs"<libguestfs@redhat.com&gt;;

The zero command is quite broken (along error paths). You must call reply_with_{,p}error along every error path. This patch fixes it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do:

On Sat, Jun 6, 2020 at 3:39 AM Richard W.M. Jones <rjones@redhat.com> wrote: > [To continue the conversation from > https://github.com/libguestfs/nbdkit/issues/5] > > > Currently there's no way for the Rust plugin to report an error. The > > idiomatic way to do it would be for each callback to return a Result > > object, much like how the Go plugin currently