similar to: [PATCH] Don't set distro for non-Linux guests

This change is part of an ongoing effort to remove use of $desc and inspect the OS directly as required during conversion. --- lib/Sys/VirtConvert/Connection/LibVirtTarget.pm | 4 +- lib/Sys/VirtConvert/Connection/RHEVTarget.pm | 41 +++++++++--------- lib/Sys/VirtConvert/Converter.pm | 35 ++++++++++++---- lib/Sys/VirtConvert/Converter/RedHat.pm | 45

On Tuesday, October 08, 2013 10:05:17 AM Matthew Booth wrote: > Feel free to remove ^$path. However, for robustness I ditch the leading > ^ from your replacement. The difference will be down to a different > version of file included in the libguestfs appliance on SUSE. I think I've addressed all the concerns you raised in the following patch. Can you take a look and let me know if

We have a problem with btrfs subvolumes, as they can hold a filesystem which can be mounted, but aren't describable using only the name of a block device. Specifically they need at least a block device and a subvolume name. There are several APIs which operate on filesystems which currently describe it using only a block device. I've listed them all below. In all cases, these APIs need

On Friday, October 11, 2013 04:57:32 PM Mike Latimer wrote: > I think I've addressed all the concerns you raised in the following patch. > Can you take a look and let me know if I've created any new ones? ;) Other than the concern about being a little too obsessed about the 79 character line length. ;) This version of the patch has all the unecessary cleanup removed, and only

The following series of patches adds support for converting SUSE guests through virt-v2v. These changes should not impact non-SUSE guest conversions. Mike Latimer (4): Add perl-Bootloader support to grub packages Add conversion support for SUSE guests Add SUSE to capabilities db and conf Add SUSE support documentation lib/Sys/VirtConvert/Converter/Linux.pm | 480

On Friday, October 04, 2013 09:38:58 AM Matthew Booth wrote: > It's specifically an error if we're attempting to configure virtio, and > there's no detected virtio kernel. It shouldn't have been possible to > get here in that state, hence it's a programmer error. The code below > attempts to install *any* kernel in the case that we aren't configuring >

Use the newly added API instead of the local implementation. --- builder/repository_main.ml | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/builder/repository_main.ml b/builder/repository_main.ml index bb440563b..c020a6413 100644 --- a/builder/repository_main.ml +++ b/builder/repository_main.ml @@ -170,23 +170,6 @@ let get_disk_image_info filepath =

This is a proposed patch which changes the RedHat.pm converter to Linux.pm, and adds support for SUSE guest conversion. This is first approach recommended by Matt Booth in: https://www.redhat.com/archives/libguestfs/2013-September/msg00076.html Some aspects of this patch still need additional testing, and a couple of changes are not foolproof (such as the lack of grub2 support in the menu.lst

*** BLURB HERE *** Pino Toscano (3): python: modernize inspect_vm example perl: silence usage of add_cdrom in test python: silence usage of add_cdrom in test perl/t/060-handle-properties.t | 7 +++++-- python/examples/inspect_vm.py | 26 ++++++++++++-------------- python/t/test050HandleProperties.py | 5 ++++- 3 files changed, 21 insertions(+), 17 deletions(-) -- 2.20.1

In preparation for an upcoming patch which adds support for SUSE guest conversions, it makes sense to have an intermediate steps that changes the RedHat.pm converter into a more generic Linux converter. The SUSE changes will then be limited in scope to only what is required for SUSE support. This series of patches accomplishes the following: - Renames RedHat.pm to Linux.pm - Modifies Linux.pm

This is a new conversion module to convert SUSE Linux and openSUSE guests. The converter is based on the RedHat module, and should offer the same functionality on both SUSE and RedHat hosts. There are a few additional messages in this module, such as reporting of packages when installing through zypper or the local virt-v2v repo. These messages don't necessarily flow unless verbose switches

Mike, This is great. I have a couple of minor comments inline, but this looks good. I do have a major concern, though, which is this is basically a fork of RedHat.pm. There are well over 1,000 identical lines of code between the 2 modules. Many of the differences are relatively minor, and could be handled with additional cases. I've also fixed a couple of bits in RedHat.pm since you forked

The SUSE converter itself, based on the RedHat converter. This supports converting SLES 10/11 and openSUSE 10/11/12/13. --- MANIFEST | 1 + lib/Sys/VirtConvert/Converter/SUSE.pm | 2527 +++++++++++++++++++++++++++++++++ 2 files changed, 2528 insertions(+) diff --git a/MANIFEST b/MANIFEST index 3724fde..615ec32 100644 --- a/MANIFEST +++ b/MANIFEST @@ -17,6 +17,7

Try to guess the possible osinfo-db short ID for the specified OS. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1544842 --- generator/actions_inspection.ml | 14 ++++++++ lib/Makefile.am | 1 + lib/inspect-osinfo.c | 75 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 90 insertions(+) create mode 100644 lib/inspect-osinfo.c diff --git

One day I'm going to run a virt-p2v that works to completion. But evidently not today. The source physical machine is Windows 2003. This one copied the whole system drive and then died at the end and deleted the virtual disk it made. Here is the top and bottom of the trace log file on the conversion server. If the email garbles what I'm pasting in below, I can email the log as an

From: "Richard W.M. Jones" <rjones at redhat.com> This is the default since libguestfs 1.6. It does not need to be explicitly set. See also https://bugzilla.redhat.com/show_bug.cgi?id=799798#c6 --- lib/Sys/VirtConvert/GuestfsHandle.pm | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/lib/Sys/VirtConvert/GuestfsHandle.pm

Hi Richard I've noticed this snippet in import-to-ovirt.pl my $minor_version = $g->inspect_get_major_version ($root); I guess you meant here my $minor_version = $g->inspect_get_minor_version ($root); Emmanuel

The $vmdk value is a directory name in ESX.pm, although the later codes replace '/' with '_', the volume name isn't still friendly, for example, it looks like this: # virsh vol-list pool-dir Name Path ----------------------------------------- esx4.1-rhel6.2-x86_64_esx4.1-rhel6.2-x86_64

--- lib/Sys/VirtConvert/Converter/Windows.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConvert/Converter/Windows.pm index 765ed9f..59d273f 100644 --- a/lib/Sys/VirtConvert/Converter/Windows.pm +++ b/lib/Sys/VirtConvert/Converter/Windows.pm @@ -338,7 +338,7 @@ sub _prepare_virtio_drivers

Although not fatal, _unconfigure_xenpv should report a warning and return if firstboot is not available (during Windows conversions). --- lib/Sys/VirtConvert/Converter/Windows.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/Sys/VirtConvert/Converter/Windows.pm b/lib/Sys/VirtConvert/Converter/Windows.pm index 59d273f..ce8b474 100644 --- a/lib/Sys/VirtConvert/Converter/Windows.pm