similar to: [PATCH libguestfs] include string.h and libintl.h, as needed

Don't include <libintl.h> (for gettext etc) in <guestfs-internal.h>. Include include it only in files that use internationalized strings. --- src/appliance.c | 1 + src/conn-socket.c | 1 + src/copy-in-out.c | 1 + src/create.c | 1 + src/dbdump.c | 1 + src/drives.c | 1 + src/errors.c | 1 + src/filearch.c | 1 +

Look for libint/gettext and link to it; this properly detects whether libint is part of libc. --- align/Makefile.am | 1 + builder/Makefile.am | 2 ++ cat/Makefile.am | 4 ++++ configure.ac | 3 +++ customize/Makefile.am | 2 +- df/Makefile.am | 1 + diff/Makefile.am | 1 + edit/Makefile.am | 1 + erlang/Makefile.am

On Tue, Nov 04, 2014 at 04:35:26PM +0100, Pino Toscano wrote: > Look for libint/gettext and link to it; this properly detects whether > libint is part of libc. I'm a little confused by this patch, and also worried that it may be reverting commit 75514ab57a. Does this require gettextize? Rich. > --- > align/Makefile.am | 1 + > builder/Makefile.am | 2 ++ >

On Tuesday 04 November 2014 16:09:56 Richard W.M. Jones wrote: > On Tue, Nov 04, 2014 at 04:35:26PM +0100, Pino Toscano wrote: > > Look for libint/gettext and link to it; this properly detects > > whether > > libint is part of libc. > > I'm a little confused by this patch, and also worried that it may be > reverting commit 75514ab57a. It is basically looking for

Greetings, Trying to get current, but having problems building samba 4.x on Solaris 9/10. I've Been trying to build either samba 4.0.19 or 4.1.9 on Sparc boxes running both Solaris 9 and Solaris 10. I am using gcc 3.4.6 from the old www.sunfreeware.com site. I also have libintl 3.4.0 from them as well. My machines are domain member servers in an Active Directory environment run by

I noticed that virt-v2v, which is written exclusively in perl, failed to generate virt-v2v.pot. After much head scratching I also noticed that libguestfs.pot didn't include any messages from perl sources. Some reading of libintl-perl shows that a somewhat more complicated xgettext command line is required, as it doesn't understand Locale::TextDomain syntax by default. After a little more

Tests are run via the ./run binary, so all the binaries in the build directory are available via $PATH already. Followup of commit e85a976c5a474d751c6e8352370047a3177a7c45. --- cat/Makefile.am | 2 +- df/Makefile.am | 2 +- fuse/test-fuse-umount-race.sh | 4 ++-- fuse/test-guestmount-fd.c | 4 ++-- fuse/test-guestunmount-fd.c

Cédric pointed out this problem we have: $ guestmount -a /var/lib/libvirt/images/sles12sp1-pv.img -m '/dev/sda1:/:subvol=.snapshots/2/snapshot:btrfs' /mnt libguestfs: error: mount_vfs: /dev/sda1 on / (options: 'subvol=.snapshots/2/snapshot'): mount: mount(2) failed: No such file or directory guestmount: '/dev/sda1' could not be mounted. guestmount: Check mount(8) man page

guestmount.c: In function 'main': guestmount.c:899: error: implicit declaration of function 'setlocale' [-Wimplicit-function-declaration] guestmount.c wasn't including locale.h. --- fuse/guestmount.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fuse/guestmount.c b/fuse/guestmount.c index b4a917f..27a4cef 100644 --- a/fuse/guestmount.c +++

syntax-check failed with this: fuse/guestmount.c:364: free ((char *) r); maint.mk: don't cast free argument make: *** [sc_cast_of_argument_to_free] Error 1 >From ed007e673b00ec545fcff2a708a57d98075c6460 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 9 Nov 2009 15:06:36 +0100 Subject: [PATCH libguestfs] avoid "syntax-check"

barely worth mentioning... >From 459fa00dd144aef2c7287eb99354c9b39eaa62c3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 9 Nov 2009 15:09:35 +0100 Subject: [PATCH libguestfs] fix doc typo * fuse/guestmount.pod: Avoid "the the". --- fuse/guestmount.pod | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fuse/guestmount.pod

On Mon, Nov 25, 2019 at 12:08:33PM +0100, Fabien Dupont wrote: > Hi, > > I'm experiencing a weird behavior when tried to use guestmount with a XFS > formatted volume. I have created a RHEL 8 virtual machine using libvirt. I > have retrieved the disk image on a RHEL 7.7 server to mount the image root > filesystem and explore it. > > The command returns an error

On Tue, Jan 28, 2014 at 08:16:45PM -0500, Andre Goree wrote: > Is r/w to a UFS partition using 'guestmount' still an impossibility? > From everything I've found, it seems to be something that is not > possible at the moment. I was just wondering if that has changed or > if there are plans to change that? libguestfs just uses the Linux kernel's ufs driver. If the

Also turns the --selinux option of guestfish, guestmount and virt-rescue into a no-op -- it didn't work before so this is effectively no change. --- builder/builder.ml | 6 ----- customize/customize_main.ml | 5 ---- dib/dib.ml | 6 ----- fish/fish.c | 5 ++-- fish/guestfish.pod | 2 +- fuse/guestmount.c | 5 ++--

Also turns the --selinux option of guestfish, guestmount and virt-rescue into a no-op -- it didn't work before so this is effectively no change. --- builder/builder.ml | 6 ----- customize/customize_main.ml | 5 ---- dib/dib.ml | 6 ----- fish/fish.c | 5 ++-- fish/guestfish.pod | 2 +- fuse/guestmount.c | 5 ++--

Hi, I'm experiencing a weird behavior when tried to use guestmount with a XFS formatted volume. I have created a RHEL 8 virtual machine using libvirt. I have retrieved the disk image on a RHEL 7.7 server to mount the image root filesystem and explore it. The command returns an error message: # guestmount -a /disks/jamesdream.qcow2 -m /dev/sda1 /mnt/ libguestfs: error: mount_options: mount

Fix compilation failure on F17 --- fuse/guestmount.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fuse/guestmount.c b/fuse/guestmount.c index 7c5e0af..379346f 100644 --- a/fuse/guestmount.c +++ b/fuse/guestmount.c @@ -28,6 +28,7 @@ #include <unistd.h> #include <getopt.h> #include <signal.h> +#include <locale.h> /* We're still using some of FUSE to

guestmount.c: In function 'fg_utimens': guestmount.c:537: error: 'UTIME_NOW' undeclared (first use in this function) guestmount.c:537: error: (Each undeclared identifier is reported only once guestmount.c:537: error: for each function it appears in.) guestmount.c:539: error: 'UTIME_OMIT' undeclared (first use in this function) I'm not sure what's the best thing to

Change hard code 3 to O_ACCMODE. it'll be more sensible. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- fuse/guestmount.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fuse/guestmount.c b/fuse/guestmount.c index bd7ba50..a9bf4e3 100644 --- a/fuse/guestmount.c +++ b/fuse/guestmount.c @@ -583,7 +583,7 @@ fg_open (const char *path, struct

I: Program returns random data in a function E: libguestfs no-return-in-nonvoid-function guestmount.c:75 The function fuse_opt_add_opt_escaped has only one caller and a return code is not checked. Signed-off-by: Olaf Hering <olaf at aepfle.de> --- diff --git a/fuse/guestmount.c b/fuse/guestmount.c index 17e94ba..1eb0553 100644 --- a/fuse/guestmount.c +++ b/fuse/guestmount.c @@ -49,7 +49,7