similar to: hivex, ENOKEY and cygwin

Hi, Few changes in hivex, sent as series to be clearly identified as hivex ones. After these patches, what about a new release of it? The last one is basically one year old, and the changes after 1.3.11 make hivex build and work fine on FreeBSD (and maybe more non-Linux OSes). Thanks, Pino Toscano (3): Fix shebang in perl scripts Update gnulib to latest. Update .gitignore with more

OS X does not include pkg-config by default. When installed, pkg.m4 tends to end up in some place that is not the autotool-expected /usr/share/aclocal/. Add to bootstrap a path check so pkg.m4 can be found, so ./configure does not fail invoking PKG_CHECK_MODULES. Signed-off-by: Alex Nelson <ajnelson at cs.ucsc.edu> --- bootstrap | 7 ++++++- 1 files changed, 6 insertions(+), 1

Hi Rich, I've updated hivex to use the latest from gnulib and fixed a few syntax-check failures. With these changes, almost all of "make distcheck" succeeds. (details coming separately) >From c6300c44a1eda1a55a23249fde94882ea5a1c430 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 28 Aug 2012 11:28:40 +0200 Subject: [PATCH hivex 1/2] maint:

On Fri, Nov 26, 2010 at 10:03:05AM -0800, Yandell, Henri wrote: > We?re looking into using Hivex and came across something odd. While > the license of hivex.c is LGPL 2.1, it appears to require the GPL > 3.0 licensed gnulib package for a few minor functions ( full_read, > full_write and c_toupper ). There are also a few GPL 3.0 build > files. It has always been our intention to

Hi, This series updates to the latest gnulib, after making most of its "make syntax-check" tests pass. There are still a few tests (listed in cfg.mk) that are simply skipped. To enable one, just remove its test name from the list of tests to skip and run "make syntax-check". [PATCH hivex 01/14] maint: add cfg.mk to prepare for syntax-check [PATCH hivex 02/14] maint: remove

Commit 4d3601eb4ed1e314a8d4944a09a7f81638396cb6 made it clear that ocaml-hivex is required, implying also that hivex is required. However the configure test was still optional, and if you built libguestfs without hivex you got a very long and confusing error in the daemon/ subdirectory. Thanks: Cédric Bosdonnat --- m4/guestfs_daemon.m4 | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

Since some modules (`getopt', for example) may copy files into the build directory, `top_builddir/lib' is needed as well as `top_srcdir/lib'. -- GNU Gnulib manual, section 2.2 Initial import This fixes an in-tree build failure on a Debian/sid system (see below). hivexml could be built out-of-tree, but it turned out that due to a missing include path, in this case the

Do a configure check for the OPEN_UNSAFE flag in the OCaml binding of Hivex, using it only when available. This makes it possible to use hivex < 1.3.14 to build libguestfs (the daemon, actually). Amend the building documentation accordingly, bringing the minimum version of hivex back as it was before commit 64f49df747c0937d9433eb11d4191d92a4af748c. --- .gitignore | 1 +

Do a configure check for the OPEN_UNSAFE flag in the OCaml binding of Hivex, using it only when available. This makes it possible to use hivex < 1.3.14 to build libguestfs (the daemon, actually). Amend the building documentation accordingly. --- .gitignore | 1 + configure.ac | 1 + daemon/Makefile.am | 2 ++ daemon/config_daemon.ml.in | 20

Since commit d5b6f1df5ff2d387a5dfc89b8316c0dff67ce2c9, the daemon requires ocaml-hivex; OTOH, nothing checks it is actually available, so the build of the daemon will fail with a semi-cryptic error about the lack of a directory in the OCaml install prefix. As fix, check for the presence of the hivex module at build time, failing earlier if not present. The check is performed only when the daemon

It was brought to my attention that dumping a registry hive causes a lot of time spent in disk I/O activity because iconv_open() and iconv_close() are called for every key. Every iconv_open() call causes /usr/lib/.../gconv/$ENCODING.so to be opened and mapped. The iconv_t handles are now cached in the hive_h struct; they are opened on-demand and re-used. On my ~10 year old Lenovo T60, I have

Hello all, I found OS X still has one remaining issue in the autotools. OS X does not include pkg-config by default, and whatever mechanism installs it places pkg.m4 in some location among: /opt/local/share/aclocal/pkg.m4 /usr/local/share/aclocal/pkg.m4 PKG_CHECK_MODULES isn't defined if pkg.m4 isn't in /usr/share/aclocal, so ./configure dies without augmenting aclocal's search

--- configure.ac | 2 +- images/Makefile.am | 5 +++-- lib/Makefile.am | 14 +++++++------- ocaml/Makefile.am | 3 ++- ocaml/t/hivex_300_fold.ml | 3 +-- python/run-python-tests | 25 ------------------------- python/run-python-tests.in | 25 +++++++++++++++++++++++++ 7 files changed, 39 insertions(+), 38 deletions(-) delete mode

From: Jim Meyering <meyering at redhat.com> * lib/hivex.c (hivex_node_set_value): Remove unnecessary test-before-free. --- lib/hivex.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/hivex.c b/lib/hivex.c index d042f4f..a72fa77 100644 --- a/lib/hivex.c +++ b/lib/hivex.c @@ -2748,8 +2748,7 @@ hivex_node_set_value (hive_h *h, hive_node_h node, leave_partial:

On Friday, 9 February 2018 19:01:53 CEST Richard W.M. Jones wrote: > My contention is that the libguestfs git repository is too large and > unwieldy. There are too many separate, unrelated projects and as a > result of that the source has too many dependencies and takes too long > to build and test. > > The project divides (sort of) naturally into layers -- the library, >

Note this requires either the following fix in autoconf: http://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=e17a30e98 OR gnulib sys_types module plus gnulib commit a512e041120e9012e69afa2f5c3adc196ec4999a (any gnulib more recent than Sep 2016) which corrects the AC_HEADER_MAJOR macro in a similar way. --- bootstrap | 1 + cat/ls.c | 7 +++++++ daemon/mknod.c

Use the newer copy shipped locally as 3rdparty, instead of the one in the common submodule, as the latter copy will go away soon. --- .gitignore | 1 + Makefile.am | 6 +++--- configure.ac | 2 +- daemon/Makefile.am | 4 ++-- docs/guestfs-hacking.pod | 19 ++++++++++++++----- ocaml-dep.sh.in | 2 +- 6 files changed, 22 insertions(+), 12

Copy over the bash completion machinery from libguestfs, along with the simple completion script; use this script for all the tools. --- .gitignore | 2 + Makefile.am | 3 ++ bash/Makefile.am | 68 +++++++++++++++++++++++++++++++++ bash/README | 6 +++ bash/test-complete-in-script.sh | 40 +++++++++++++++++++

Sorry for the late reply to this ... On Tue, Apr 30, 2019 at 06:28:01PM +0200, Pino Toscano wrote: > On Friday, 9 February 2018 19:01:53 CEST Richard W.M. Jones wrote: > > My contention is that the libguestfs git repository is too large and > > unwieldy. There are too many separate, unrelated projects and as a > > result of that the source has too many dependencies and takes

virt-v2v is definitely used by the functional tests that run virt-p2v, so check for it, and require it for running those tests. Reported by Rich. --- m4/p2v-tests.m4 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/m4/p2v-tests.m4 b/m4/p2v-tests.m4 index f679bc4..7de356d 100644 --- a/m4/p2v-tests.m4 +++ b/m4/p2v-tests.m4 @@ -25,11 +25,12 @@ AC_ARG_ENABLE([gnulib-tests],