similar to: [PATCH] Improve cleanup of libguestfs handle with Sys::VirtV2V::GuestfsHandle

This removes another chunk of functionality from GuestOS. --- MANIFEST | 1 + lib/Sys/VirtV2V/Config.pm | 339 +++++++++++++++++++++++++++++++++++++ lib/Sys/VirtV2V/Converter.pm | 56 +----- lib/Sys/VirtV2V/GuestOS.pm | 94 ---------- lib/Sys/VirtV2V/GuestOS/RedHat.pm | 46 ++++-- v2v/virt-v2v.pl | 96 +---------- 6 files

We were assuming that guests wouldn't use multiple interfaces, or if they did, drive letters wouldn't clash between the interfaces. An ESX guest with a CDROM device breaks this because hard disks will be presented a SCSI, starting at sda, and CDROM devices are presented as IDE, starting at hda. This is in contrast to QEMU, which starts at hdc by default. Firstly, this change causes disks

The code for mounting the transfer iso in Converter::Windows didn't do the same level of error checking as the same code in GuestOS::RedHat. This change moves the GuestOS code into Config, and updates both GuestOS::RedHat and Converter::Windows to use Config. Fixes RHBZ#596091 --- lib/Sys/VirtV2V/Config.pm | 51 ++++++++++++++++++++++++ lib/Sys/VirtV2V/Converter/Windows.pm |

From: "Richard W.M. Jones" <rjones at redhat.com> This is the default since libguestfs 1.6. It does not need to be explicitly set. See also https://bugzilla.redhat.com/show_bug.cgi?id=799798#c6 --- lib/Sys/VirtConvert/GuestfsHandle.pm | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/lib/Sys/VirtConvert/GuestfsHandle.pm

This is my lightly tested patch which allows pre-conversion of Windows guests. You also need to supply rhsrvany.exe and firstboot scripts. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.

We previously wouldn't create a Config object if no config file was specified. This change ensures that a Config object is always created, but will do nothing interesting if there is no config file. Apart from being slightly cleaner, this allows information provided by Config to be later supplied from the command line instead. --- lib/Sys/VirtV2V/Config.pm | 34

Cleanup was not happening properly if a migration to RHEV was killed prematurely with a Ctrl-C. Firstly, the SIGINT and SIGQUIT handlers were not being registered early enough in virt-v2v.pl. Secondly, if Ctrl-C killed the guestfs qemu process first it would deliver a SIGPIPE to v2v, which caused an unclean shutdown without cleanup. Fixes RHBZ#596015 --- v2v/virt-v2v.pl | 17 ++++++++++++++---

Previously, only the LibVirtXML connection translated network and bridge names in imported metadata. This change moves this functionality in Converter, making it available to LibVirt connections as well. At the same time, the format of the config file is switched to XML. The primary driver for this is that the allowable syntax of a foreign network/bridge name is not known. Rather than create a

These 2 patches are mostly code motion. They were prompted by an apparent augeas error in BZ 613967 which didn't display useful error message. The error seems to happen in Converter::Linux. GuestOS::RedHat had a handy function which displayed verbose augeas error messages. This function moves into the new module where it can be used by both modules. The second patch is an consequential tidy

inspect_os() shouldn't do this, but ultimately it's heuristic. As we know what the transfer device is, we can double-check the output. --- v2v/virt-v2v.pl | 18 +++++++++++++++++- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/v2v/virt-v2v.pl b/v2v/virt-v2v.pl index fe07ae9..6e73102 100755 --- a/v2v/virt-v2v.pl +++ b/v2v/virt-v2v.pl @@ -496,11 +496,18 @@ my $g = new

Move all target-specific functionality into its own module in preparation for output to RHEV. --- MANIFEST | 1 + lib/Sys/VirtV2V/Connection.pm | 46 ++--- lib/Sys/VirtV2V/Converter.pm | 138 +------------ lib/Sys/VirtV2V/Target/LibVirt.pm | 419 +++++++++++++++++++++++++++++++++++++ lib/Sys/VirtV2V/Transfer/ESX.pm | 91 +++------ po/POTFILES.in

Hello, I've trying to move a 32bit CentOS 6.4 on VirtualBox to oVirt on Fedora 19 64bit via virt-v2v. The command I'm currently using is: virt-v2v -i libvirtxml -of qcow2 -oa sparse -o rhev -osd xxx.xxx.xxx.xxx:/usr/local/ovirt/exports --network ovirtmgmt /usr1/home/williams/Downloads/OpenAthens/VMs/OpenAthensLARuntime2.2.xml The exciting bit of the XML is: <devices>

Change 13412f7629133b25fda32c35fdb0276e22de3445 caused Config to keep a reference to the guestfs handle in certain circumstances. This caused a regression in the cleanup code because the handle was no longer closed in close_guest_handle. This change explicitly drops the reference to $config before closing the guest handle. It also localises $guestos, which also keeps a reference to the guestfs

Previously, only the LibVirtXML connection translated network and bridge names in imported metadata. This change moves this functionality in Converter, making it available to LibVirt connections as well. At the same time, the format of the config file is switched to XML. The primary driver for this is that the allowable syntax of a foreign network/bridge name is not known. Rather than create a

This patch refactors the data transfer code with several goals: * Have a common read(source)/write(target) loop so that common processing can happen in the middle of it, e.g. format change/progress bar * Provide volume metadata to transfers to allow smarter reading/writing, e.g. of sparse files * Simplify the data transfer code The patch *isn't* NFC because there are some minor behaviour

If something die()s, the error status can get lost in cleanup when various child processes exit and overwrite $?. Specifically, the RHEV target uses a child process for NFS access, and libguestfs launches a qemu child process. This change ensures that DESTROY and END blocks which perform operations on child processes explicitly preserve $?. --- lib/Sys/VirtV2V/Target/RHEV.pm | 10 ++++++++++

On Tue, Nov 22, 2011 at 08:03:15PM +0000, Wandell, Doug wrote: > Image is a prebuilt VMWare image from Layer7. Downloaded and converted under RHEL6 like this: > > virt-convert --arch=x86_64 SSG_64bit_VirtualAppliance_v6.1/ SSG_64bit_VirtualAppliance_v6.1.xml > qemu-img convert -O qcow2 SSG_64bit_VirtualAppliance_v6.1.raw SSG_64bit_VirtualAppliance_v6.1.qcow2 > > No problem. I

This will allow use of raw data from os description in addition to libvirt XML when writing guest output. --- lib/Sys/VirtV2V/Target/LibVirt.pm | 2 +- lib/Sys/VirtV2V/Target/RHEV.pm | 2 +- v2v/virt-v2v.pl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/Sys/VirtV2V/Target/LibVirt.pm b/lib/Sys/VirtV2V/Target/LibVirt.pm index

If a volume is not an exact multiple of 512 bytes, qemu-img will report its size rounded down to a 512 byte boundary. However, when copying, the file is still read until EOF, which will return more data than was expected. This change prevents that causing a failure in itself. The situation is still not resolved, however, as there are still situations where this will cause a failure. For example,

The iface:ide parameter (used in the libguestfs add_drive call) does not work with a libvirt backend. The error usually seen is: 'iface' parameter is not supported by the libvirt attach-method at /usr/share/perl5/vendor_perl/Sys/VirtConvert/GuestfsHandle.pm line 96. This issue was previously mentioned in this thread: