similar to: [PATCH] fish: Fix build error if built without readline.

Note this bug was very confusing because glob works when you use the -x (trace) option, so when you try to trace the commands being run the bug "disappears". Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.

How about the following? I've made it use a named value (RUN_WRONG_ARGS == -2) instead of just the magic number. Also I removed an incorrect hunk from the original patch (space before synopsis string is required). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is

On Thu, Aug 28, 2014 at 03:21:09PM +0200, Pino Toscano wrote: > /* Edit it. */ > - /* XXX Safe? */ > - snprintf (buf, sizeof buf, "%s %s", editor, filename); > + if (asprintf (&cmd, "%s %s", editor, tmpfilename) == -1) { filename -> tmpfilename. Is that right? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones

On Mon, Dec 01, 2014 at 06:01:25PM +0000, Richard W.M. Jones wrote: > > How about the following? I've made it use a named value > (RUN_WRONG_ARGS == -2) instead of just the magic number. Yes, it looks better! > > Also I removed an incorrect hunk from the original patch (space before > synopsis string is required). The space before synopsis makes the text of synopsis

Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- fish/fish.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fish/fish.c b/fish/fish.c index 0432774..20511f8 100644 --- a/fish/fish.c +++ b/fish/fish.c @@ -641,10 +641,12 @@ shell_script (void) #define FISH "><fs> " +#ifdef HAVE_LIBREADLINE static char *ps1 = NULL; /* GUESTFISH_PS1 */

On Thu, Dec 12, 2019 at 06:05:05PM +0100, Pino Toscano wrote: > src/lib.rs is not created by the generator, while src/guestfs.rs is. > --- > rust/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rust/Makefile.am b/rust/Makefile.am > index edcccffa1..cb16e021f 100644 > --- a/rust/Makefile.am > +++ b/rust/Makefile.am > @@ -19,7

In 1.11.1 / git, I have made some changes to the way that you run guestfish, guestmount and the virt tools from the build directory without installing. Firstly you can't just run ./fish/guestfish or ./fuse/guestmount any more and have those programs magically set LIBGUESTFS_PATH. The automagic code was always error-prone and I have removed it. Secondly, all of the run-*-local scripts have

Ditto for readline. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -------------- next part -------------- >From dc4f3e2cee4d2a0e3030c3e7067e8f3e33df56db Mon Sep 17 00:00:00 2001 From:

On Sun, Jan 05, 2014 at 02:11:21PM +0700, Nguyễn Trường Sơn wrote: > Hi > > I want to build libguestfs on my laptop. > I run Centos 6.4, libguestfs libguestfs-1.24.3. > > I get this error: > > Wide character in print at /root/libguestfs-1.24.3/podwrapper.pl line 418. > podwrapper.pl: wrote guestfish.1 > podwrapper.pl: wrote ../html/guestfish.1.html > touch

hi mr Jones Thank for your quick reply. I only run ./configure. I've just deleted config.cache as you say, but nothing changed. Even i get new library : libguestfs-1.24.4, still get error. 2014/1/5 Richard W.M. Jones <rjones@redhat.com> > On Sun, Jan 05, 2014 at 02:11:21PM +0700, Nguyễn Trường Sơn wrote: > > Hi > > > > I want to build libguestfs on my laptop.

-- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/ -------------- next part -------------- >From 7a14e0509d5cc976deda9b5299f56930e0317502 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones at

On Tue, Sep 24, 2013 at 04:45:30PM +0200, Martin Kletzander wrote: > I'm not sure whether this is the best fix, but it makes the build > pass. Sorry for the delay. For some reason I thought I'd applied this, but actually I'd forgotten about it. I believe the original motivation for creating the tool.pl -> tool symlink was because xgettext didn't know these files were

https://bugzilla.redhat.com/show_bug.cgi?id=516024 Segfault in tab completion (sometimes). This patch fixes it. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next

Fixes for both of these bugs: https://bugzilla.redhat.com/show_bug.cgi?id=633096 virt-resize calculates block device size incorrectly, doesn't work with qcow2 target https://bugzilla.redhat.com/show_bug.cgi?id=633766 virt-resize --shrink fails I'm still doing testing on these, but the patches seem good enough to review. Rich. -- Richard Jones, Virtualization Group, Red Hat

Just for discussion. With this very large patch I am able to get through a build on my local machine at least. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=60d5a50f4d3d9e2c2f5a7d42a6859de709bda3f6 Originally I had the daemon directory use a separate configure script, because we thought we would recompile the daemon for multiple different architectures, so that we could have libguestfs able to run commands in guests which have a different architecture from the host. Well, that didn't really

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From 4891ff9945177e8666af8381d1e0a54b8ce363e2 Mon Sep 17 00:00:00 2001 From: Richard Jones

Two-part patch to fix RHBZ#580246. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

This patchset just fixes the 'hexdump' command as an example. The important part of the patch is #2 since that shows the approach I want to take to fix this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.